All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Stigge <stigge@antcom.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: srinivas.bakki@nxp.com, arnd@arndb.de,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	kevin.wells@nxp.com, linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, alan@linux.intel.com
Subject: Re: [PATCH] serial/of-serial: Add 16654 chip to compatible string list
Date: Mon, 28 May 2012 20:17:58 +0200	[thread overview]
Message-ID: <4FC3C156.5040609@antcom.de> (raw)
In-Reply-To: <20120528180139.GC28290@n2100.arm.linux.org.uk>

On 28/05/12 20:01, Russell King - ARM Linux wrote:
>> Now, introducing a new type, can I add to 8250.c's uart_config[] by
>> introducing a new type (no. 22) after PORT_XR17D15X? Unfortunately,
>> there are the "ARM specific type numbers" after current PORT_MAX_8250
>> (21), but those are not listed in 8250.c's uart_config[]. Or how am I
>> supposed to add a new type?
> 
> If it's 8250, stick it in with the group, otherwise the array will
> become stupidly large.  That's why there's a separation of the two.

Do you mean adding one element to uart_config[] and increasing
PORT_MAX_8250 (actually, the size of uart_config[]) by one? I would also
need to increase the indices of all the following "ARM specific type
numbers" by one (the second group).

Or did I get sth. wrong here?

Thanks in advance,

Roland

WARNING: multiple messages have this Message-ID (diff)
From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial/of-serial: Add 16654 chip to compatible string list
Date: Mon, 28 May 2012 20:17:58 +0200	[thread overview]
Message-ID: <4FC3C156.5040609@antcom.de> (raw)
In-Reply-To: <20120528180139.GC28290@n2100.arm.linux.org.uk>

On 28/05/12 20:01, Russell King - ARM Linux wrote:
>> Now, introducing a new type, can I add to 8250.c's uart_config[] by
>> introducing a new type (no. 22) after PORT_XR17D15X? Unfortunately,
>> there are the "ARM specific type numbers" after current PORT_MAX_8250
>> (21), but those are not listed in 8250.c's uart_config[]. Or how am I
>> supposed to add a new type?
> 
> If it's 8250, stick it in with the group, otherwise the array will
> become stupidly large.  That's why there's a separation of the two.

Do you mean adding one element to uart_config[] and increasing
PORT_MAX_8250 (actually, the size of uart_config[]) by one? I would also
need to increase the indices of all the following "ARM specific type
numbers" by one (the second group).

Or did I get sth. wrong here?

Thanks in advance,

Roland

WARNING: multiple messages have this Message-ID (diff)
From: Roland Stigge <stigge@antcom.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: alan@linux.intel.com, gregkh@linuxfoundation.org,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	kevin.wells@nxp.com, srinivas.bakki@nxp.com,
	linux-arm-kernel@lists.infradead.org, arnd@arndb.de
Subject: Re: [PATCH] serial/of-serial: Add 16654 chip to compatible string list
Date: Mon, 28 May 2012 20:17:58 +0200	[thread overview]
Message-ID: <4FC3C156.5040609@antcom.de> (raw)
In-Reply-To: <20120528180139.GC28290@n2100.arm.linux.org.uk>

On 28/05/12 20:01, Russell King - ARM Linux wrote:
>> Now, introducing a new type, can I add to 8250.c's uart_config[] by
>> introducing a new type (no. 22) after PORT_XR17D15X? Unfortunately,
>> there are the "ARM specific type numbers" after current PORT_MAX_8250
>> (21), but those are not listed in 8250.c's uart_config[]. Or how am I
>> supposed to add a new type?
> 
> If it's 8250, stick it in with the group, otherwise the array will
> become stupidly large.  That's why there's a separation of the two.

Do you mean adding one element to uart_config[] and increasing
PORT_MAX_8250 (actually, the size of uart_config[]) by one? I would also
need to increase the indices of all the following "ARM specific type
numbers" by one (the second group).

Or did I get sth. wrong here?

Thanks in advance,

Roland

  reply	other threads:[~2012-05-28 18:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-28  9:58 [PATCH] serial/of-serial: Add 16654 chip to compatible string list Roland Stigge
2012-05-28  9:58 ` Roland Stigge
2012-05-28 10:03 ` Russell King - ARM Linux
2012-05-28 10:03   ` Russell King - ARM Linux
2012-05-28 11:20   ` Roland Stigge
2012-05-28 11:20     ` Roland Stigge
2012-05-28 15:03     ` Russell King - ARM Linux
2012-05-28 15:03       ` Russell King - ARM Linux
2012-05-28 16:27       ` Roland Stigge
2012-05-28 16:27         ` Roland Stigge
2012-05-28 16:31         ` Russell King - ARM Linux
2012-05-28 16:31           ` Russell King - ARM Linux
2012-05-28 17:48           ` Roland Stigge
2012-05-28 17:48             ` Roland Stigge
2012-05-28 18:01             ` Russell King - ARM Linux
2012-05-28 18:01               ` Russell King - ARM Linux
2012-05-28 18:17               ` Roland Stigge [this message]
2012-05-28 18:17                 ` Roland Stigge
2012-05-28 18:17                 ` Roland Stigge
2012-05-28 18:39                 ` Russell King - ARM Linux
2012-05-28 18:39                   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC3C156.5040609@antcom.de \
    --to=stigge@antcom.de \
    --cc=alan@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=kevin.wells@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=srinivas.bakki@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.