From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Cong Wang <amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Cong Wang
<xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [BUGFIX Patch] fix a wrong usage of vinfo in init.sh
Date: Tue, 29 May 2012 10:20:04 +0200 [thread overview]
Message-ID: <4FC486B4.8090506@redhat.com> (raw)
In-Reply-To: <1338278814-8603-1-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Am 29.05.2012 10:06, schrieb Cong Wang:
> vinfo() reads input from stdin, not from arguments.
>
> This is a regression introduced by:
>
> commit 982d59afea5eac202c8a47f09d06d240af753a24
> Author: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Date: Tue May 22 14:52:36 2012 +0200
>
> drop 10rpmversion module and introduce /etc/initrd-release
>
>
> Signed-off-by: Cong Wang <xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> ---
> diff --git a/modules.d/99base/init.sh b/modules.d/99base/init.sh
> index b8736ec..1146a86 100755
> --- a/modules.d/99base/init.sh
> +++ b/modules.d/99base/init.sh
> @@ -90,7 +90,7 @@ else
> fi
>
> [ -f /etc/initrd-release ] && . /etc/initrd-release
> -[ -n "$VERSION" ] && vinfo "dracut-$VERSION"
> +[ -n "$VERSION" ] && echo "dracut-$VERSION" | vinfo
>
> source_conf /etc/conf.d
>
Thanks! even simpler:
-[ -n "$VERSION" ] && vinfo "dracut-$VERSION"
+[ -n "$VERSION" ] && info "dracut-$VERSION"
next prev parent reply other threads:[~2012-05-29 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 8:06 [BUGFIX Patch] fix a wrong usage of vinfo in init.sh Cong Wang
[not found] ` <1338278814-8603-1-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-29 8:20 ` Harald Hoyer [this message]
[not found] ` <4FC486B4.8090506-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-29 8:28 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC486B4.8090506@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.