* [BUGFIX Patch] fix a wrong usage of vinfo in init.sh
@ 2012-05-29 8:06 Cong Wang
[not found] ` <1338278814-8603-1-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Cong Wang @ 2012-05-29 8:06 UTC (permalink / raw)
To: initramfs-u79uwXL29TY76Z2rM5mHXA; +Cc: Cong Wang, Harald Hoyer
vinfo() reads input from stdin, not from arguments.
This is a regression introduced by:
commit 982d59afea5eac202c8a47f09d06d240af753a24
Author: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Date: Tue May 22 14:52:36 2012 +0200
drop 10rpmversion module and introduce /etc/initrd-release
Signed-off-by: Cong Wang <xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
diff --git a/modules.d/99base/init.sh b/modules.d/99base/init.sh
index b8736ec..1146a86 100755
--- a/modules.d/99base/init.sh
+++ b/modules.d/99base/init.sh
@@ -90,7 +90,7 @@ else
fi
[ -f /etc/initrd-release ] && . /etc/initrd-release
-[ -n "$VERSION" ] && vinfo "dracut-$VERSION"
+[ -n "$VERSION" ] && echo "dracut-$VERSION" | vinfo
source_conf /etc/conf.d
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [BUGFIX Patch] fix a wrong usage of vinfo in init.sh
[not found] ` <1338278814-8603-1-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2012-05-29 8:20 ` Harald Hoyer
[not found] ` <4FC486B4.8090506-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Harald Hoyer @ 2012-05-29 8:20 UTC (permalink / raw)
To: Cong Wang; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA, Cong Wang
Am 29.05.2012 10:06, schrieb Cong Wang:
> vinfo() reads input from stdin, not from arguments.
>
> This is a regression introduced by:
>
> commit 982d59afea5eac202c8a47f09d06d240af753a24
> Author: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Date: Tue May 22 14:52:36 2012 +0200
>
> drop 10rpmversion module and introduce /etc/initrd-release
>
>
> Signed-off-by: Cong Wang <xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> ---
> diff --git a/modules.d/99base/init.sh b/modules.d/99base/init.sh
> index b8736ec..1146a86 100755
> --- a/modules.d/99base/init.sh
> +++ b/modules.d/99base/init.sh
> @@ -90,7 +90,7 @@ else
> fi
>
> [ -f /etc/initrd-release ] && . /etc/initrd-release
> -[ -n "$VERSION" ] && vinfo "dracut-$VERSION"
> +[ -n "$VERSION" ] && echo "dracut-$VERSION" | vinfo
>
> source_conf /etc/conf.d
>
Thanks! even simpler:
-[ -n "$VERSION" ] && vinfo "dracut-$VERSION"
+[ -n "$VERSION" ] && info "dracut-$VERSION"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUGFIX Patch] fix a wrong usage of vinfo in init.sh
[not found] ` <4FC486B4.8090506-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2012-05-29 8:28 ` Cong Wang
0 siblings, 0 replies; 3+ messages in thread
From: Cong Wang @ 2012-05-29 8:28 UTC (permalink / raw)
To: Harald Hoyer; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA
On Tue, May 29, 2012 at 4:20 PM, Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Am 29.05.2012 10:06, schrieb Cong Wang:
>> [ -f /etc/initrd-release ] && . /etc/initrd-release
>> -[ -n "$VERSION" ] && vinfo "dracut-$VERSION"
>> +[ -n "$VERSION" ] && echo "dracut-$VERSION" | vinfo
>>
>> source_conf /etc/conf.d
>>
>
> Thanks! even simpler:
>
> -[ -n "$VERSION" ] && vinfo "dracut-$VERSION"
> +[ -n "$VERSION" ] && info "dracut-$VERSION"
Yeah.. please go ahead to commit it. This blocks my testing.
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-29 8:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-29 8:06 [BUGFIX Patch] fix a wrong usage of vinfo in init.sh Cong Wang
[not found] ` <1338278814-8603-1-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-29 8:20 ` Harald Hoyer
[not found] ` <4FC486B4.8090506-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-29 8:28 ` Cong Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.