* [PATCH] gspca - ov534/ov534_9: Fix sccd_read/write errors
@ 2012-05-28 17:04 Jean-Francois Moine
2012-05-29 9:15 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Jean-Francois Moine @ 2012-05-28 17:04 UTC (permalink / raw)
To: Linux Media Mailing List, Hans de Goede
The ov534 bridge is too slow to handle the sensor accesses
requested by fast hosts giving 'sccb_reg_write failed'.
A small delay fixes the problem.
Signed-off-by: Jean-François Moine <moinejf@free.fr>
---
drivers/media/video/gspca/ov534.c | 1 +
drivers/media/video/gspca/ov534_9.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/media/video/gspca/ov534.c b/drivers/media/video/gspca/ov534.c
index b5acb1e..d5a7873 100644
--- a/drivers/media/video/gspca/ov534.c
+++ b/drivers/media/video/gspca/ov534.c
@@ -851,6 +851,7 @@ static int sccb_check_status(struct gspca_dev *gspca_dev)
int i;
for (i = 0; i < 5; i++) {
+ msleep(10);
data = ov534_reg_read(gspca_dev, OV534_REG_STATUS);
switch (data) {
diff --git a/drivers/media/video/gspca/ov534_9.c b/drivers/media/video/gspca/ov534_9.c
index e6601b8..0120f94 100644
--- a/drivers/media/video/gspca/ov534_9.c
+++ b/drivers/media/video/gspca/ov534_9.c
@@ -1008,6 +1008,7 @@ static int sccb_check_status(struct gspca_dev *gspca_dev)
int i;
for (i = 0; i < 5; i++) {
+ msleep(10);
data = reg_r(gspca_dev, OV534_REG_STATUS);
switch (data) {
--
1.7.10
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gspca - ov534/ov534_9: Fix sccd_read/write errors
2012-05-28 17:04 [PATCH] gspca - ov534/ov534_9: Fix sccd_read/write errors Jean-Francois Moine
@ 2012-05-29 9:15 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2012-05-29 9:15 UTC (permalink / raw)
To: Jean-Francois Moine; +Cc: Linux Media Mailing List
Hi,
Thanks I've added this and the sonixj fixes to my tree and send an
updated pullreq to Mauro to include these in the next round of
fixes for 3.5
Regards,
Hans
On 05/28/2012 07:04 PM, Jean-Francois Moine wrote:
> The ov534 bridge is too slow to handle the sensor accesses
> requested by fast hosts giving 'sccb_reg_write failed'.
> A small delay fixes the problem.
>
> Signed-off-by: Jean-François Moine<moinejf@free.fr>
> ---
> drivers/media/video/gspca/ov534.c | 1 +
> drivers/media/video/gspca/ov534_9.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/media/video/gspca/ov534.c b/drivers/media/video/gspca/ov534.c
> index b5acb1e..d5a7873 100644
> --- a/drivers/media/video/gspca/ov534.c
> +++ b/drivers/media/video/gspca/ov534.c
> @@ -851,6 +851,7 @@ static int sccb_check_status(struct gspca_dev *gspca_dev)
> int i;
>
> for (i = 0; i< 5; i++) {
> + msleep(10);
> data = ov534_reg_read(gspca_dev, OV534_REG_STATUS);
>
> switch (data) {
> diff --git a/drivers/media/video/gspca/ov534_9.c b/drivers/media/video/gspca/ov534_9.c
> index e6601b8..0120f94 100644
> --- a/drivers/media/video/gspca/ov534_9.c
> +++ b/drivers/media/video/gspca/ov534_9.c
> @@ -1008,6 +1008,7 @@ static int sccb_check_status(struct gspca_dev *gspca_dev)
> int i;
>
> for (i = 0; i< 5; i++) {
> + msleep(10);
> data = reg_r(gspca_dev, OV534_REG_STATUS);
>
> switch (data) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-29 9:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-28 17:04 [PATCH] gspca - ov534/ov534_9: Fix sccd_read/write errors Jean-Francois Moine
2012-05-29 9:15 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.