[PATCH] Skip boot-device set for powerpc-ieee1275

[PATCH] Skip boot-device set for powerpc-ieee1275

[Paulo Flabiano Smorigo]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

This patch is to skip the boot-device set for powerpc-ieee1275.  
Changing it could be problematic in some cases.
The choice of the boot device can be done by the SMS menu of the firmware.

-- 
Paulo Flabiano Smorigo
Linux Technology Center Brazil Software Engineer
IBM Systems & Technology Group
pfsmorigo@br.ibm.com / pfsmorigo@linux.vnet.ibm.com
irc: pfsmorigo

[-- Attachment #2: skip_boot-device_set_for_powerpc-ieee1275.patch --]
[-- Type: text/x-patch, Size: 1323 bytes --]

=== modified file 'util/grub-install.in'
--- util/grub-install.in	2012-05-11 19:07:39 +0000
+++ util/grub-install.in	2012-05-29 18:22:55 +0000
@@ -799,14 +799,16 @@
 	    }
 	fi
 
-	"$nvsetenv" boot-device "$boot_device" || {
-	    # TRANSLATORS: The %s will be replaced by an external program name.
-	    gettext_printf "\`%s' failed.\n" "$nvsetenv" 1>&2
-	    gettext "You will have to set \`boot-device' variable manually.  At the IEEE1275 prompt, type:" 1>&2
-	    echo 1>&2
-	    echo "  setenv boot-device $boot_device" 1>&2
-	    exit 1
-	}
+        if [ "${grub_modinfo_target_cpu}-${grub_modinfo_platform}" = "i386-ieee1275" ]; then
+    	    "$nvsetenv" boot-device "$boot_device" || {
+	        # TRANSLATORS: The %s will be replaced by an external program name.
+                gettext_printf "\`%s' failed.\n" "$nvsetenv" 1>&2
+                gettext "You will have to set \`boot-device' variable manually.  At the IEEE1275 prompt, type:" 1>&2
+                echo 1>&2
+                echo "  setenv boot-device $boot_device" 1>&2
+                exit 1
+            }
+        fi
     fi
 elif [ x"${grub_modinfo_target_cpu}-${grub_modinfo_platform}" = xmips-arc ]; then
     dvhtool -d "${install_device}" --unix-to-vh "{grubdir}/${grub_modinfo_target_cpu}-$grub_modinfo_platform/core.${imgext}" grub

Re: [PATCH] Skip boot-device set for powerpc-ieee1275

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 994 bytes --]

On 29.05.2012 20:28, Paulo Flabiano Smorigo wrote:

> This patch is to skip the boot-device set for powerpc-ieee1275. Changing
> it could be problematic in some cases.
> The choice of the boot device can be done by the SMS menu of the firmware.
> 

As I've already told when discussing this patch in fedora, this patch is
both dirty and wrong. On most systems it would just make the result
unbootable and doesn't provide any compensation for the missing step.
The most affected systems would probably be PowerMacs since setting
nvram is the only way currently to boot HD install without involving
user going to OF prompt which on some systems defaults to a serial port
which uses nonstandard connector.
Why isn't completing but issuing the warning like we do on failure not
acceptable solution on those machines?
Why isn't it possible to modify nvram on those machines?
What are the "problems" you're talking about?


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

Re: [PATCH] Skip boot-device set for powerpc-ieee1275

[Lennart Sorensen]

On Tue, May 29, 2012 at 08:36:40PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> As I've already told when discussing this patch in fedora, this patch is
> both dirty and wrong. On most systems it would just make the result
> unbootable and doesn't provide any compensation for the missing step.
> The most affected systems would probably be PowerMacs since setting
> nvram is the only way currently to boot HD install without involving
> user going to OF prompt which on some systems defaults to a serial port
> which uses nonstandard connector.
> Why isn't completing but issuing the warning like we do on failure not
> acceptable solution on those machines?
> Why isn't it possible to modify nvram on those machines?
> What are the "problems" you're talking about?

Well also already have '--no-nvram' which does just fine.

-- 
Len Sorensen