All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 18/22] mfd: Remove redundant Kconfig entry
Date: Wed, 30 May 2012 15:37:18 +0800	[thread overview]
Message-ID: <4FC5CE2E.6000501@linaro.org> (raw)
In-Reply-To: <CACRpkdYpCMRurpDgz5X-Qsv5qUgzeVX3S8trWHByTaw6R35_jg@mail.gmail.com>

On 30/05/12 15:15, Linus Walleij wrote:
> On Wed, May 30, 2012 at 12:47 PM, Lee Jones<lee.jones@linaro.org>  wrote:
>
>> During ab8500-core clean-up the Kconfig entry for AB8500_I2C_CORE
>> was left remnant. This patch simply removes it.
>>
>> Cc: Samuel Ortiz<sameo@linux.intel.com>
>> Cc: linux-kernel at vger.kernel.org
>> Signed-off-by: Lee Jones<lee.jones@linaro.org>
>> ---
>>   drivers/mfd/Kconfig |   10 ----------
>>   1 file changed, 10 deletions(-)
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index 11a1b65..b697136 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -660,16 +660,6 @@ config AB8500_CORE
>>           the irq_chip parts for handling the Mixed Signal chip events.
>>           This chip embeds various other multimedia funtionalities as well.
>>
>> -config AB8500_I2C_CORE
>> -       bool "AB8500 register access via PRCMU I2C"
>> -       depends on AB8500_CORE&&  MFD_DB8500_PRCMU
>
> You need to move these dependencies under the AB8500_CORE config
> entry instead.

Already done and upstreamed: 21f082a66177852365df0c955ecaef50fba9a691

>> -       default y
>
> I wonder if in  arch/arm/mach-ux500/Kconfig MACH_MOP500 should
> select this instead, all MOP500 children have this an *won't* work
> without it.

As described, I have already moved the dependency in the Kconfig file.

I guess what you've just mentioned is a separate patch (for another 
time). I'll stick it on my ever growing TODO.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
	linus.walleij@stericsson.com, grant.likely@secretlab.ca,
	cjb@laptop.org, broonie@opensource.wolfsonmicro.com,
	sameo@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 18/22] mfd: Remove redundant Kconfig entry
Date: Wed, 30 May 2012 15:37:18 +0800	[thread overview]
Message-ID: <4FC5CE2E.6000501@linaro.org> (raw)
In-Reply-To: <CACRpkdYpCMRurpDgz5X-Qsv5qUgzeVX3S8trWHByTaw6R35_jg@mail.gmail.com>

On 30/05/12 15:15, Linus Walleij wrote:
> On Wed, May 30, 2012 at 12:47 PM, Lee Jones<lee.jones@linaro.org>  wrote:
>
>> During ab8500-core clean-up the Kconfig entry for AB8500_I2C_CORE
>> was left remnant. This patch simply removes it.
>>
>> Cc: Samuel Ortiz<sameo@linux.intel.com>
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Lee Jones<lee.jones@linaro.org>
>> ---
>>   drivers/mfd/Kconfig |   10 ----------
>>   1 file changed, 10 deletions(-)
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index 11a1b65..b697136 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -660,16 +660,6 @@ config AB8500_CORE
>>           the irq_chip parts for handling the Mixed Signal chip events.
>>           This chip embeds various other multimedia funtionalities as well.
>>
>> -config AB8500_I2C_CORE
>> -       bool "AB8500 register access via PRCMU I2C"
>> -       depends on AB8500_CORE&&  MFD_DB8500_PRCMU
>
> You need to move these dependencies under the AB8500_CORE config
> entry instead.

Already done and upstreamed: 21f082a66177852365df0c955ecaef50fba9a691

>> -       default y
>
> I wonder if in  arch/arm/mach-ux500/Kconfig MACH_MOP500 should
> select this instead, all MOP500 children have this an *won't* work
> without it.

As described, I have already moved the dependency in the Kconfig file.

I guess what you've just mentioned is a separate patch (for another 
time). I'll stick it on my ever growing TODO.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2012-05-30  7:37 UTC|newest]

Thread overview: 122+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30  4:47 [PATCH 01/22] Fixes and clean-ups for Device Tree on Snowball Lee Jones
2012-05-30  4:47 ` [PATCH 01/22] ARM: ux500: New DT:ed snowball_platform_devs for one-by-one device enablement Lee Jones
2012-05-30  4:47 ` [PATCH 02/22] ARM: ux500: New DT:ed u8500_init_devices " Lee Jones
2012-05-30  4:47 ` [PATCH 03/22] ARM: ux500: Disable SMSC911x platform code registration when DT is enabled Lee Jones
2012-05-30  4:47 ` [PATCH 04/22] ARM: ux500: Remove DB8500 PRCMU platform " Lee Jones
2012-05-30  6:48   ` Linus Walleij
2012-05-30  4:47 ` [PATCH 05/22] ARM: ux500: PRCMU related configuration and layout corrections for Device Tree Lee Jones
2012-05-30  4:47 ` [PATCH 06/22] ARM: ux500: Re-enable SMSC911x platform code registration during non-DT boots Lee Jones
2012-05-30  4:47 ` [PATCH 07/22] ARM: ux500: Use correct format for dynamic IRQ assignment Lee Jones
2012-05-30  4:47 ` [PATCH 08/22] regulator: Change ab8500 match names to reflect Device Tree Lee Jones
2012-05-30  4:47   ` Lee Jones
2012-05-30  6:58   ` Linus Walleij
2012-05-30  6:58     ` Linus Walleij
2012-05-30 10:03     ` Mark Brown
2012-05-30 10:03       ` Mark Brown
2012-05-30 11:40       ` Lee Jones
2012-05-30 12:15         ` Mark Brown
2012-05-30 12:15           ` Mark Brown
2012-05-30 15:01           ` Lee Jones
2012-05-30 15:01             ` Lee Jones
2012-05-30 15:11             ` Mark Brown
2012-05-30 15:11               ` Mark Brown
2012-05-30 15:22               ` Lee Jones
2012-05-30 15:22                 ` Lee Jones
2012-05-30 16:41                 ` Mark Brown
2012-05-30 16:41                   ` Mark Brown
2012-05-31  0:42                   ` Lee Jones
2012-05-31  0:42                     ` Lee Jones
2012-06-01  4:36                   ` Lee Jones
2012-06-01  4:36                     ` Lee Jones
2012-06-01  8:48                     ` Mark Brown
2012-06-01  8:48                       ` Mark Brown
2012-06-05 10:31                       ` Lee Jones
2012-06-05 10:31                         ` Lee Jones
2012-06-05 10:38                         ` Mark Brown
2012-06-05 10:38                           ` Mark Brown
2012-06-11 10:27                           ` Lee Jones
2012-06-11 10:27                             ` Lee Jones
2012-06-11 10:36                             ` Mark Brown
2012-06-11 10:36                               ` Mark Brown
2012-06-11 11:28                               ` Lee Jones
2012-06-11 11:28                                 ` Lee Jones
2012-06-11 11:42                                 ` Mark Brown
2012-06-11 11:42                                   ` Mark Brown
2012-05-31  1:40     ` Linus Walleij
2012-05-31  1:40       ` Linus Walleij
2012-06-01 14:32   ` Mark Brown
2012-06-01 14:32     ` Mark Brown
2012-05-30  4:47 ` [PATCH 09/22] regulator: Change db8500-prcmu " Lee Jones
2012-05-30  4:47   ` Lee Jones
2012-05-30  7:00   ` Linus Walleij
2012-05-30  7:00     ` Linus Walleij
2012-06-05 10:24   ` Lee Jones
2012-06-05 10:24     ` Lee Jones
2012-06-05 10:29     ` Mark Brown
2012-06-05 10:29       ` Mark Brown
2012-06-05 10:34       ` Lee Jones
2012-06-05 10:34         ` Lee Jones
2012-06-05 10:42         ` Mark Brown
2012-06-05 10:42           ` Mark Brown
2012-06-06  8:17           ` Lee Jones
2012-06-11 11:21           ` Lee Jones
2012-06-11 11:21             ` Lee Jones
2012-06-11 12:08             ` Mark Brown
2012-06-11 12:08               ` Mark Brown
2012-06-11 13:34               ` Lee Jones
2012-06-11 13:34                 ` Lee Jones
2012-06-11 14:07                 ` Lee Jones
2012-06-11 14:07                   ` Lee Jones
2012-06-11 14:27                   ` Mark Brown
2012-06-11 14:27                     ` Mark Brown
2012-06-11 14:50                     ` Lee Jones
2012-06-11 14:50                       ` Lee Jones
2012-06-11 15:15                       ` Mark Brown
2012-06-11 15:15                         ` Mark Brown
2012-06-11 15:18                         ` Lee Jones
2012-06-11 15:18                           ` Lee Jones
2012-06-11 15:39                           ` Mark Brown
2012-06-11 15:39                             ` Mark Brown
2012-06-11 15:59                             ` Lee Jones
2012-06-11 15:59                               ` Lee Jones
2012-06-11 16:09                               ` Mark Brown
2012-06-11 16:09                                 ` Mark Brown
2012-05-30  4:47 ` [PATCH 10/22] ARM: ux500: Disable platform setup of the ab8500 when DT is enabled Lee Jones
2012-05-30  4:47 ` [PATCH 11/22] ARM: ux500: Only initialise STE's UIBs on boards which support them Lee Jones
2012-05-30  4:47 ` [PATCH 12/22] ARM: ux500: Apply db8500-prcmu regulator information to db8500 Device Tree Lee Jones
2012-05-30  4:47 ` [PATCH 13/22] ARM: ux500: Allow PRCMU regulator to be probed during a DT enabled boot Lee Jones
2012-05-30  4:47 ` [PATCH 14/22] ARM: ux500: Provide regulator support for SMSC911x via Device Tree Lee Jones
2012-05-30  7:05   ` Linus Walleij
2012-05-30  4:47 ` [PATCH 15/22] ARM: ux500: Add support for ab8500 regulators into the " Lee Jones
2012-05-30  4:47 ` [PATCH 16/22] mfd: ab8500-gpadc: Enable IRQF_ONESHOT when requesting a threaded IRQ Lee Jones
2012-05-30  4:47   ` Lee Jones
2012-05-30  7:10   ` Linus Walleij
2012-05-30  7:10     ` Linus Walleij
2012-06-29 13:21   ` Samuel Ortiz
2012-06-29 13:21     ` Samuel Ortiz
2012-05-30  4:47 ` [PATCH 17/22] rtc: ab8500-rtc: " Lee Jones
2012-05-30  7:11   ` [rtc-linux] " Linus Walleij
2012-05-30  4:47 ` [PATCH 18/22] mfd: Remove redundant Kconfig entry Lee Jones
2012-05-30  4:47   ` Lee Jones
2012-05-30  7:15   ` Linus Walleij
2012-05-30  7:15     ` Linus Walleij
2012-05-30  7:37     ` Lee Jones [this message]
2012-05-30  7:37       ` Lee Jones
2012-05-30  7:43       ` Linus Walleij
2012-05-30  7:43         ` Linus Walleij
2012-06-29 13:24   ` Samuel Ortiz
2012-06-29 13:24     ` Samuel Ortiz
2012-05-30  4:47 ` [PATCH 19/22] net/smsc911x: Repair broken failure paths Lee Jones
2012-05-30  4:47   ` Lee Jones
2012-05-30  7:16   ` Linus Walleij
2012-05-30  7:16     ` Linus Walleij
2012-05-30 21:52     ` David Miller
2012-05-30 21:52       ` David Miller
2012-05-30  4:47 ` [PATCH 20/22] pinctrl-nomadik: Allow Device Tree driver probing Lee Jones
2012-05-30  7:18   ` Linus Walleij
2012-05-30  4:47 ` [PATCH 21/22] ARM: ux500: Enable probing of pinctrl through Device Tree Lee Jones
2012-05-30  7:18   ` Linus Walleij
2012-05-30  4:47 ` [PATCH 22/22] mfd: Enable DT probing of the DB8500 PRCMU Lee Jones
2012-05-30  4:47   ` Lee Jones
2012-05-30  7:19   ` Linus Walleij
2012-05-30  7:19     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC5CE2E.6000501@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.