* Re: [mlmmj] Mlmmj 1.2.18.0 released
2012-05-29 14:14 [mlmmj] Mlmmj 1.2.18.0 released Ben Schmidt
@ 2012-05-30 13:30 ` Thomas Goirand
2012-05-30 13:45 ` Mads Martin Jørgensen
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Thomas Goirand @ 2012-05-30 13:30 UTC (permalink / raw)
To: mlmmj
On 05/29/2012 10:14 PM, Ben Schmidt wrote:
> Hi, everybody!
>
> I am pleased to announce that Mlmmj 1.2.18.0 has been released. Find it
> on the downloads page[1].
Hey, that's just on time for Debian 7 (code name: Wheezy)! Thanks for
that. I've updated the Debian packages today, and uploaded to SID, if
everything goes well, it's going to be in Wheezy.
I'm quite happy to see that I had to remove most of the Debian specific
patches, as they were incorporated upstream (eg: on mlmmj original
sources). Still, there are 2 patches remaining. I believe that this one
could be somehow avoided:
--- a/include/mlmmj.h 2012-01-22 15:36:11.000000000 +0800
+++ b/include/mlmmj.h 2012-01-22 15:36:16.000000000 +0800
@@ -88,7 +88,7 @@
#define CHECKFULLPATH(name) if(strchr(name, '/') = NULL) { \
fprintf(stderr, "All mlmmj binaries have to " \
"be invoked with full path,\n" \
- "e.g. /usr/local/bin/%s\n", name); \
+ "e.g. /usr/bin/%s\n", name); \
exit(EXIT_FAILURE); \
};
what do you think?
The other one is contrib/web/php-admin/htdocs/dot.htaccess:
diff -u -r -N a/contrib/web/php-admin/htdocs/dot.htaccess
b/contrib/web/php-admin/htdocs/dot.htaccess
--- a/contrib/web/php-admin/htdocs/dot.htaccess 2012-01-22
15:40:16.000000000 +0800
+++ b/contrib/web/php-admin/htdocs/dot.htaccess 2012-01-22
15:40:37.000000000 +0800
@@ -1,4 +1,5 @@
Require valid-user
AuthType Basic
-AuthName "mlmmj web-interface"
-AuthUserFile /home/mlmmj/htpasswd
+AuthName "mlmmj web-interface on Debian GNU/Linux"
+AuthUserFile /etc/mlmmj-php-web-admin/htpasswd
+php_value include_path "/usr/share/mlmmj-php-web-admin"
I don't see how this one could be avoided, and I'm fine keeping it in
the package.
Thomas
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [mlmmj] Mlmmj 1.2.18.0 released
2012-05-29 14:14 [mlmmj] Mlmmj 1.2.18.0 released Ben Schmidt
2012-05-30 13:30 ` Thomas Goirand
@ 2012-05-30 13:45 ` Mads Martin Jørgensen
2012-05-30 14:00 ` Ben Schmidt
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Mads Martin Jørgensen @ 2012-05-30 13:45 UTC (permalink / raw)
To: mlmmj
On 30/05/12 15.30, Thomas Goirand wrote:
> I'm quite happy to see that I had to remove most of the Debian specific
> patches, as they were incorporated upstream (eg: on mlmmj original
> sources). Still, there are 2 patches remaining. I believe that this one
> could be somehow avoided:
>
> --- a/include/mlmmj.h 2012-01-22 15:36:11.000000000 +0800
> +++ b/include/mlmmj.h 2012-01-22 15:36:16.000000000 +0800
> @@ -88,7 +88,7 @@
> #define CHECKFULLPATH(name) if(strchr(name, '/') = NULL) { \
> fprintf(stderr, "All mlmmj binaries have to " \
> "be invoked with full path,\n" \
> - "e.g./usr/local/bin/%s\n", name); \
> + "e.g./usr/bin/%s\n", name); \
> exit(EXIT_FAILURE); \
> };
The auto-* macros should substitute this to always Say The Right Thing[tm].
--
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
and totally illogical, with just a little bit more effort?"
-- A. P. J.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [mlmmj] Mlmmj 1.2.18.0 released
2012-05-29 14:14 [mlmmj] Mlmmj 1.2.18.0 released Ben Schmidt
2012-05-30 13:30 ` Thomas Goirand
2012-05-30 13:45 ` Mads Martin Jørgensen
@ 2012-05-30 14:00 ` Ben Schmidt
2012-05-30 14:17 ` Chris Webb
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Ben Schmidt @ 2012-05-30 14:00 UTC (permalink / raw)
To: mlmmj
> Hey, that's just on time for Debian 7 (code name: Wheezy)! Thanks for
> that. I've updated the Debian packages today, and uploaded to SID, if
> everything goes well, it's going to be in Wheezy.
Excellent!
> I'm quite happy to see that I had to remove most of the Debian specific
> patches, as they were incorporated upstream (eg: on mlmmj original
> sources). Still, there are 2 patches remaining. I believe that this one
> could be somehow avoided:
>
> --- a/include/mlmmj.h 2012-01-22 15:36:11.000000000 +0800
> +++ b/include/mlmmj.h 2012-01-22 15:36:16.000000000 +0800
> @@ -88,7 +88,7 @@
> #define CHECKFULLPATH(name) if(strchr(name, '/') = NULL) { \
> fprintf(stderr, "All mlmmj binaries have to " \
> "be invoked with full path,\n" \
> - "e.g. /usr/local/bin/%s\n", name); \
> + "e.g. /usr/bin/%s\n", name); \
> exit(EXIT_FAILURE); \
> };
>
> what do you think?
Yeah, that's really stupid. We should be able to get the prefix in a
macro in config.h if nothing else.
Could you possibly jump on the bug tracker at
http://mlmmj.org/bugs/report.php and add this as a bug, and upload the
patch (even though this patch doesn't fix the bug, it demonstrates and
localises the problem)? Then I should get around to it before the next
release if not before.
One day we might even fix things so you don't need to use the full path
to invoke the binaries. I certainly find it really annoying, and I don't
know any other application that requires it. You'd think we could figure
out what's going on from argv[0] or something.
> The other one is contrib/web/php-admin/htdocs/dot.htaccess:
>
> diff -u -r -N a/contrib/web/php-admin/htdocs/dot.htaccess
> b/contrib/web/php-admin/htdocs/dot.htaccess
> --- a/contrib/web/php-admin/htdocs/dot.htaccess 2012-01-22
> 15:40:16.000000000 +0800
> +++ b/contrib/web/php-admin/htdocs/dot.htaccess 2012-01-22
> 15:40:37.000000000 +0800
> @@ -1,4 +1,5 @@
> Require valid-user
> AuthType Basic
> -AuthName "mlmmj web-interface"
> -AuthUserFile /home/mlmmj/htpasswd
> +AuthName "mlmmj web-interface on Debian GNU/Linux"
> +AuthUserFile /etc/mlmmj-php-web-admin/htpasswd
> +php_value include_path "/usr/share/mlmmj-php-web-admin"
>
> I don't see how this one could be avoided, and I'm fine keeping it in
> the package.
Yeah, I agree. It's really an example file anyway. You just have a more
Debian-specific example. There will be no one-size-fits-all for this.
Ben.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [mlmmj] Mlmmj 1.2.18.0 released
2012-05-29 14:14 [mlmmj] Mlmmj 1.2.18.0 released Ben Schmidt
` (2 preceding siblings ...)
2012-05-30 14:00 ` Ben Schmidt
@ 2012-05-30 14:17 ` Chris Webb
2012-05-30 14:17 ` Mads Martin Jørgensen
2012-05-30 17:40 ` Thomas Goirand
5 siblings, 0 replies; 7+ messages in thread
From: Chris Webb @ 2012-05-30 14:17 UTC (permalink / raw)
To: mlmmj
Ben Schmidt <mail_ben_schmidt@yahoo.com.au> writes:
> One day we might even fix things so you don't need to use the full path
> to invoke the binaries. I certainly find it really annoying, and I don't
> know any other application that requires it. You'd think we could figure
> out what's going on from argv[0] or something.
I always just patch away this code completely when I build mlmmj. Like
almost everyone else, I don't build systems with multiple versions of mlmmj
on my path, and have always found the UI breakage of requiring absolute
paths on the command line because someone might do something that weird
completely bonkers.
Cheers,
Chris.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [mlmmj] Mlmmj 1.2.18.0 released
2012-05-29 14:14 [mlmmj] Mlmmj 1.2.18.0 released Ben Schmidt
` (3 preceding siblings ...)
2012-05-30 14:17 ` Chris Webb
@ 2012-05-30 14:17 ` Mads Martin Jørgensen
2012-05-30 17:40 ` Thomas Goirand
5 siblings, 0 replies; 7+ messages in thread
From: Mads Martin Jørgensen @ 2012-05-30 14:17 UTC (permalink / raw)
To: mlmmj
On 30/05/12 16.00, Ben Schmidt wrote:
> One day we might even fix things so you don't need to use the full path
> to invoke the binaries. I certainly find it really annoying, and I don't
> know any other application that requires it. You'd think we could figure
> out what's going on from argv[0] or something.
It's totally possible to just use path - but it's a security question.
The less you need to parse things from the environment, the better.
--
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
and totally illogical, with just a little bit more effort?"
-- A. P. J.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [mlmmj] Mlmmj 1.2.18.0 released
2012-05-29 14:14 [mlmmj] Mlmmj 1.2.18.0 released Ben Schmidt
` (4 preceding siblings ...)
2012-05-30 14:17 ` Mads Martin Jørgensen
@ 2012-05-30 17:40 ` Thomas Goirand
5 siblings, 0 replies; 7+ messages in thread
From: Thomas Goirand @ 2012-05-30 17:40 UTC (permalink / raw)
To: mlmmj
On 05/30/2012 10:00 PM, Ben Schmidt wrote:
> Could you possibly jump on the bug tracker at
> http://mlmmj.org/bugs/report.php and add this as a bug, and upload the
> patch (even though this patch doesn't fix the bug, it demonstrates and
> localises the problem)? Then I should get around to it before the next
> release if not before.
Done!
Thomas
^ permalink raw reply [flat|nested] 7+ messages in thread