All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [RFC] ath9k: Fix softlockup in AR9485
Date: Thu, 31 May 2012 11:22:55 +0530	[thread overview]
Message-ID: <4FC70737.1070708@qca.qualcomm.com> (raw)
In-Reply-To: <20423.1188.258292.959073@gargle.gargle.HOWL>

On Thursday 31 May 2012 11:11 AM, Sujith Manoharan wrote:
> Mohammed Shafi Shajakhan wrote:
>> should we check  if (work_pending(&sc->hw_reset_work)) like we do in
>> ath_beacon_tasklet in all the other work routine that access hardware
>> registers in case the hw_reset_work is not cancelled(possible in
>> ath_set_channel)
>
> Probably, but this needs to be done in a clean manner.

ok.

>
>> don't know, i put a printk to see the routine seems to get executed for
>> every 200ms(HZ/5). scan work in mac80211 seems to use HZ
>> ieee80211_queue_delayed_work(&local->hw,&local->scan_work, next_delay);
>
> HZ can be configured to a user-defined value, so we need to make sure
> that the timing for the PLL work is what we want.

ok, then we will change it.

>
> Sujith


-- 
thanks,
shafi

WARNING: multiple messages have this Message-ID (diff)
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Sujith Manoharan <c_manoha@qca.qualcomm.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	<linux-wireless@vger.kernel.org>, <stable@vger.kernel.org>,
	Rodriguez Luis <rodrigue@qca.qualcomm.com>,
	<ath9k-devel@lists.ath9k.org>,
	Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
Subject: Re: [ath9k-devel] [RFC] ath9k: Fix softlockup in AR9485
Date: Thu, 31 May 2012 11:22:55 +0530	[thread overview]
Message-ID: <4FC70737.1070708@qca.qualcomm.com> (raw)
In-Reply-To: <20423.1188.258292.959073@gargle.gargle.HOWL>

On Thursday 31 May 2012 11:11 AM, Sujith Manoharan wrote:
> Mohammed Shafi Shajakhan wrote:
>> should we check  if (work_pending(&sc->hw_reset_work)) like we do in
>> ath_beacon_tasklet in all the other work routine that access hardware
>> registers in case the hw_reset_work is not cancelled(possible in
>> ath_set_channel)
>
> Probably, but this needs to be done in a clean manner.

ok.

>
>> don't know, i put a printk to see the routine seems to get executed for
>> every 200ms(HZ/5). scan work in mac80211 seems to use HZ
>> ieee80211_queue_delayed_work(&local->hw,&local->scan_work, next_delay);
>
> HZ can be configured to a user-defined value, so we need to make sure
> that the timing for the PLL work is what we want.

ok, then we will change it.

>
> Sujith


-- 
thanks,
shafi

  reply	other threads:[~2012-05-31  5:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30 16:10 [ath9k-devel] [RFC] ath9k: Fix softlockup in AR9485 Mohammed Shafi Shajakhan
2012-05-30 16:10 ` Mohammed Shafi Shajakhan
2012-05-30 18:48 ` [ath9k-devel] " Adrian Chadd
2012-05-30 18:48   ` Adrian Chadd
2012-05-31  4:49   ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-05-31  4:49     ` Mohammed Shafi Shajakhan
2012-05-31  2:44 ` [ath9k-devel] " Sujith Manoharan
2012-05-31  2:44   ` Sujith Manoharan
2012-05-31  5:34   ` Mohammed Shafi Shajakhan
2012-05-31  5:34     ` Mohammed Shafi Shajakhan
2012-05-31  5:41     ` Sujith Manoharan
2012-05-31  5:41       ` Sujith Manoharan
2012-05-31  5:52       ` Mohammed Shafi Shajakhan [this message]
2012-05-31  5:52         ` Mohammed Shafi Shajakhan
2012-06-08 12:16         ` Sujith Manoharan
2012-06-08 12:16           ` Sujith Manoharan
2012-06-11  5:03           ` Mohammed Shafi Shajakhan
2012-06-11  5:03             ` Mohammed Shafi Shajakhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC70737.1070708@qca.qualcomm.com \
    --to=mohammed@qca.qualcomm.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.