From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Giancarlo Asnaghi <giancarlo.asnaghi@st.com>,
Russell King <linux@arm.linux.org.uk>,
Linus Walleij <linus.walleij@stericsson.com>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
Alessandro Rubini <rubini@gnudd.com>,
linux-kernel@vger.kernel.org,
Wolfram Sang <w.sang@pengutronix.de>,
Jean Delvare <khali@linux-fr.org>,
linux-i2c@vger.kernel.org, STEricsson_nomadik_linux@list.st.com,
linux-arm-kernel@lists.infradead.org,
Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH RFC 1/3] i2c-nomadik: move header from <plat/i2c.h> to <linux/i2c-nomadik.h>
Date: Thu, 31 May 2012 09:37:15 +0100 [thread overview]
Message-ID: <4FC72DBB.6030601@codethink.co.uk> (raw)
In-Reply-To: <CACRpkdY_bg5s_eKot8Ywbmb+SmixsJOSJW_jWjjenedjJng4Jg@mail.gmail.com>
On 31/05/12 02:47, Linus Walleij wrote:
> On Thu, May 31, 2012 at 1:45 AM, Alessandro Rubini<rubini@gnudd.com> wrote:
>
>> The header and driver were only used by arm/mach-nomadik and
>> arm/mach-u8500. The STA2X11 I/O Hub exports on PCIe a number of
>> devices, including i2c-nomadik. This patch allows compilation of
>> the driver under x86.
>>
>> Signed-off-by: Alessandro Rubini<rubini@gnudd.com>
>> Acked-by: Giancarlo Asnaghi<giancarlo.asnaghi@st.com>
>
> The new place to put pure platform data headers is:
> include/linux/platform_data/i2c-nomadik.h so please use this.
Aha, didn't see your reply before making mine.
> Pls use git format-patch -M so we get a nice movement patch
> without all the -/+ lines. (No big deal though.)
Agreed, useful for when actually submitting.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
WARNING: multiple messages have this Message-ID (diff)
From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 1/3] i2c-nomadik: move header from <plat/i2c.h> to <linux/i2c-nomadik.h>
Date: Thu, 31 May 2012 09:37:15 +0100 [thread overview]
Message-ID: <4FC72DBB.6030601@codethink.co.uk> (raw)
In-Reply-To: <CACRpkdY_bg5s_eKot8Ywbmb+SmixsJOSJW_jWjjenedjJng4Jg@mail.gmail.com>
On 31/05/12 02:47, Linus Walleij wrote:
> On Thu, May 31, 2012 at 1:45 AM, Alessandro Rubini<rubini@gnudd.com> wrote:
>
>> The header and driver were only used by arm/mach-nomadik and
>> arm/mach-u8500. The STA2X11 I/O Hub exports on PCIe a number of
>> devices, including i2c-nomadik. This patch allows compilation of
>> the driver under x86.
>>
>> Signed-off-by: Alessandro Rubini<rubini@gnudd.com>
>> Acked-by: Giancarlo Asnaghi<giancarlo.asnaghi@st.com>
>
> The new place to put pure platform data headers is:
> include/linux/platform_data/i2c-nomadik.h so please use this.
Aha, didn't see your reply before making mine.
> Pls use git format-patch -M so we get a nice movement patch
> without all the -/+ lines. (No big deal though.)
Agreed, useful for when actually submitting.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alessandro Rubini <rubini@gnudd.com>,
Giancarlo Asnaghi <giancarlo.asnaghi@st.com>,
Russell King <linux@arm.linux.org.uk>,
Linus Walleij <linus.walleij@stericsson.com>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
linux-kernel@vger.kernel.org,
Wolfram Sang <w.sang@pengutronix.de>,
STEricsson_nomadik_linux@list.st.com, linux-i2c@vger.kernel.org,
Jean Delvare <khali@linux-fr.org>,
linux-arm-kernel@lists.infradead.org,
Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH RFC 1/3] i2c-nomadik: move header from <plat/i2c.h> to <linux/i2c-nomadik.h>
Date: Thu, 31 May 2012 09:37:15 +0100 [thread overview]
Message-ID: <4FC72DBB.6030601@codethink.co.uk> (raw)
In-Reply-To: <CACRpkdY_bg5s_eKot8Ywbmb+SmixsJOSJW_jWjjenedjJng4Jg@mail.gmail.com>
On 31/05/12 02:47, Linus Walleij wrote:
> On Thu, May 31, 2012 at 1:45 AM, Alessandro Rubini<rubini@gnudd.com> wrote:
>
>> The header and driver were only used by arm/mach-nomadik and
>> arm/mach-u8500. The STA2X11 I/O Hub exports on PCIe a number of
>> devices, including i2c-nomadik. This patch allows compilation of
>> the driver under x86.
>>
>> Signed-off-by: Alessandro Rubini<rubini@gnudd.com>
>> Acked-by: Giancarlo Asnaghi<giancarlo.asnaghi@st.com>
>
> The new place to put pure platform data headers is:
> include/linux/platform_data/i2c-nomadik.h so please use this.
Aha, didn't see your reply before making mine.
> Pls use git format-patch -M so we get a nice movement patch
> without all the -/+ lines. (No big deal though.)
Agreed, useful for when actually submitting.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2012-05-31 8:37 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 17:45 [PATCH RFC 0/3] i2c-nomadik changes Alessandro Rubini
2012-05-30 17:45 ` Alessandro Rubini
2012-05-30 17:45 ` Alessandro Rubini
2012-05-30 17:45 ` [PATCH RFC 1/3] i2c-nomadik: move header from <plat/i2c.h> to <linux/i2c-nomadik.h> Alessandro Rubini
2012-05-30 17:45 ` Alessandro Rubini
2012-05-30 17:45 ` Alessandro Rubini
[not found] ` <ca47a47e0a4db31545549ed978e1dc7b3aad4377.1338398567.git.rubini-kaDoWcXyVrEAvxtiuMwx3w@public.gmane.org>
2012-05-31 1:47 ` Linus Walleij
2012-05-31 1:47 ` Linus Walleij
2012-05-31 1:47 ` Linus Walleij
2012-05-31 8:37 ` Ben Dooks [this message]
2012-05-31 8:37 ` Ben Dooks
2012-05-31 8:37 ` Ben Dooks
2012-05-31 8:32 ` Ben Dooks
2012-05-31 8:32 ` Ben Dooks
2012-05-31 8:32 ` Ben Dooks
2012-05-30 17:46 ` [PATCH RFC 3/3] i2c-nomadik: depend on ARM_AMBA, not PLAT_NOMADIK Alessandro Rubini
2012-05-30 17:46 ` Alessandro Rubini
[not found] ` <cover.1338398567.git.rubini-kaDoWcXyVrEAvxtiuMwx3w@public.gmane.org>
2012-05-30 17:45 ` [PATCH RFC 2/3] i2c-nomadik: turn the platform driver to an amba driver Alessandro Rubini
2012-05-30 17:45 ` Alessandro Rubini
2012-05-30 17:45 ` Alessandro Rubini
[not found] ` <349645b61d0b28f6e84f7ae1f2c8c28e12a11d92.1338398567.git.rubini-kaDoWcXyVrEAvxtiuMwx3w@public.gmane.org>
2012-05-31 1:51 ` Linus Walleij
2012-05-31 1:51 ` Linus Walleij
2012-05-31 1:51 ` Linus Walleij
2012-05-31 8:37 ` Ben Dooks
2012-05-31 8:37 ` Ben Dooks
2012-05-31 8:37 ` Ben Dooks
2012-05-31 10:16 ` Linus Walleij
2012-05-31 10:16 ` Linus Walleij
2012-05-31 10:16 ` Linus Walleij
[not found] ` <CACRpkdZpjn0RBGY+CqqSW3ip0MSQUJSaqN0GD=a4THnPHNM-jg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-31 18:02 ` Alessandro Rubini
2012-05-31 18:02 ` Alessandro Rubini
2012-05-31 18:02 ` Alessandro Rubini
[not found] ` <20120531180204.GA28779-eyGpkxvC2QLRELXczCotyA@public.gmane.org>
2012-06-01 1:53 ` Linus Walleij
2012-06-01 1:53 ` Linus Walleij
2012-06-01 1:53 ` Linus Walleij
2012-06-01 2:24 ` Lee Jones
2012-06-01 2:24 ` Lee Jones
2012-06-01 2:24 ` Lee Jones
2012-05-31 1:55 ` [PATCH RFC 0/3] i2c-nomadik changes Linus Walleij
2012-05-31 1:55 ` Linus Walleij
2012-05-31 1:55 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC72DBB.6030601@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=alan@linux.intel.com \
--cc=giancarlo.asnaghi@st.com \
--cc=khali@linux-fr.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rubini@gnudd.com \
--cc=srinidhi.kasagar@stericsson.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.