From: Junxiao Bi <junxiao.bi@oracle.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: ocfs2-devel@oss.oracle.com, linux-aio@kvack.org,
mfasheh@suse.com, jlbec@evilplan.org, bcrl@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
joe.jin@oracle.com
Subject: [Ocfs2-devel] [PATCH 2/2] ocfs2: clear unaligned io flag when dio fails
Date: Fri, 01 Jun 2012 09:44:25 +0800 [thread overview]
Message-ID: <4FC81E79.1080003@oracle.com> (raw)
In-Reply-To: <x49fwagcuii.fsf@segfault.boston.devel.redhat.com>
On 05/31/2012 10:09 PM, Jeff Moyer wrote:
> Junxiao Bi <junxiao.bi@oracle.com> writes:
>
>> The unaligned io flag is set in the kiocb when an unaligned
>> dio is issued, it should be cleared even when the dio fails,
>> or it may affect the following io which are using the same
>> kiocb.
> What code is re-using kiocbs, much less re-using them without
> re-initializing them?
See my comment in another thread. aio_write seems called two times with
the same kiocb.
>
> -Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Junxiao Bi <junxiao.bi@oracle.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: ocfs2-devel@oss.oracle.com, linux-aio@kvack.org,
mfasheh@suse.com, jlbec@evilplan.org, bcrl@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
joe.jin@oracle.com
Subject: Re: [PATCH 2/2] ocfs2: clear unaligned io flag when dio fails
Date: Fri, 01 Jun 2012 09:44:25 +0800 [thread overview]
Message-ID: <4FC81E79.1080003@oracle.com> (raw)
In-Reply-To: <x49fwagcuii.fsf@segfault.boston.devel.redhat.com>
On 05/31/2012 10:09 PM, Jeff Moyer wrote:
> Junxiao Bi <junxiao.bi@oracle.com> writes:
>
>> The unaligned io flag is set in the kiocb when an unaligned
>> dio is issued, it should be cleared even when the dio fails,
>> or it may affect the following io which are using the same
>> kiocb.
> What code is re-using kiocbs, much less re-using them without
> re-initializing them?
See my comment in another thread. aio_write seems called two times with
the same kiocb.
>
> -Jeff
next prev parent reply other threads:[~2012-06-01 1:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 4:12 [Ocfs2-devel] [PATCH 1/2] aio: make kiocb->private NUll in init_sync_kiocb() Junxiao Bi
2012-05-31 4:12 ` Junxiao Bi
2012-05-31 4:12 ` [Ocfs2-devel] [PATCH 2/2] ocfs2: clear unaligned io flag when dio fails Junxiao Bi
2012-05-31 4:12 ` Junxiao Bi
2012-05-31 4:36 ` Joe Jin
2012-05-31 14:09 ` [Ocfs2-devel] " Jeff Moyer
2012-05-31 14:09 ` Jeff Moyer
2012-06-01 1:44 ` Junxiao Bi [this message]
2012-06-01 1:44 ` Junxiao Bi
2012-05-31 4:36 ` [PATCH 1/2] aio: make kiocb->private NUll in init_sync_kiocb() Joe Jin
2012-05-31 14:08 ` [Ocfs2-devel] " Jeff Moyer
2012-05-31 14:08 ` Jeff Moyer
2012-06-01 1:41 ` [Ocfs2-devel] " Junxiao Bi
2012-06-01 1:41 ` Junxiao Bi
2012-06-01 20:55 ` [Ocfs2-devel] " Jeff Moyer
2012-06-01 20:55 ` Jeff Moyer
2012-06-02 2:59 ` [Ocfs2-devel] " Junxiao Bi
2012-06-02 2:59 ` Junxiao Bi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC81E79.1080003@oracle.com \
--to=junxiao.bi@oracle.com \
--cc=bcrl@kvack.org \
--cc=jlbec@evilplan.org \
--cc=jmoyer@redhat.com \
--cc=joe.jin@oracle.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.