From: Arend van Spriel <arend@broadcom.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: linville@tuxdriver.com, zajec5@gmail.com,
b43-dev@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: [PATCH] bcma: make some functions static
Date: Fri, 1 Jun 2012 09:58:37 +0200 [thread overview]
Message-ID: <4FC8762D.8090807@broadcom.com> (raw)
In-Reply-To: <1338496859-16436-1-git-send-email-hauke@hauke-m.de>
On 05/31/2012 10:40 PM, Hauke Mehrtens wrote:
> The functions and structs are not used in an other file and the
> prototypes are in no header file, just make them static so the compiler
> is able to optimize them better.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> diff --git a/drivers/bcma/host_pci.c b/drivers/bcma/host_pci.c
> index 6c05cf4..f7fbae7 100644
> --- a/drivers/bcma/host_pci.c
> +++ b/drivers/bcma/host_pci.c
> @@ -77,8 +77,8 @@ static void bcma_host_pci_write32(struct bcma_device *core, u16 offset,
> }
>
> #ifdef CONFIG_BCMA_BLOCKIO
> -void bcma_host_pci_block_read(struct bcma_device *core, void *buffer,
> - size_t count, u16 offset, u8 reg_width)
> +static void bcma_host_pci_block_read(struct bcma_device *core, void *buffer,
> + size_t count, u16 offset, u8 reg_width)
align this with struct keyword above.
> {
> void __iomem *addr = core->bus->mmio + offset;
> if (core->bus->mapped_core != core)
> @@ -100,8 +100,9 @@ void bcma_host_pci_block_read(struct bcma_device *core, void *buffer,
> }
> }
>
> -void bcma_host_pci_block_write(struct bcma_device *core, const void *buffer,
> - size_t count, u16 offset, u8 reg_width)
> +static void bcma_host_pci_block_write(struct bcma_device *core,
> + const void *buffer, size_t count,
> + u16 offset, u8 reg_width)
same here. checkpatch also spews warnings about DOS line endings.
Gr. AvS
WARNING: multiple messages have this Message-ID (diff)
From: "Arend van Spriel" <arend@broadcom.com>
To: "Hauke Mehrtens" <hauke@hauke-m.de>
Cc: linville@tuxdriver.com, zajec5@gmail.com,
b43-dev@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] bcma: make some functions static
Date: Fri, 1 Jun 2012 09:58:37 +0200 [thread overview]
Message-ID: <4FC8762D.8090807@broadcom.com> (raw)
In-Reply-To: <1338496859-16436-1-git-send-email-hauke@hauke-m.de>
On 05/31/2012 10:40 PM, Hauke Mehrtens wrote:
> The functions and structs are not used in an other file and the
> prototypes are in no header file, just make them static so the compiler
> is able to optimize them better.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> diff --git a/drivers/bcma/host_pci.c b/drivers/bcma/host_pci.c
> index 6c05cf4..f7fbae7 100644
> --- a/drivers/bcma/host_pci.c
> +++ b/drivers/bcma/host_pci.c
> @@ -77,8 +77,8 @@ static void bcma_host_pci_write32(struct bcma_device *core, u16 offset,
> }
>
> #ifdef CONFIG_BCMA_BLOCKIO
> -void bcma_host_pci_block_read(struct bcma_device *core, void *buffer,
> - size_t count, u16 offset, u8 reg_width)
> +static void bcma_host_pci_block_read(struct bcma_device *core, void *buffer,
> + size_t count, u16 offset, u8 reg_width)
align this with struct keyword above.
> {
> void __iomem *addr = core->bus->mmio + offset;
> if (core->bus->mapped_core != core)
> @@ -100,8 +100,9 @@ void bcma_host_pci_block_read(struct bcma_device *core, void *buffer,
> }
> }
>
> -void bcma_host_pci_block_write(struct bcma_device *core, const void *buffer,
> - size_t count, u16 offset, u8 reg_width)
> +static void bcma_host_pci_block_write(struct bcma_device *core,
> + const void *buffer, size_t count,
> + u16 offset, u8 reg_width)
same here. checkpatch also spews warnings about DOS line endings.
Gr. AvS
next prev parent reply other threads:[~2012-06-01 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 20:40 [PATCH] bcma: make some functions static Hauke Mehrtens
2012-06-01 7:58 ` Arend van Spriel [this message]
2012-06-01 7:58 ` Arend van Spriel
2012-06-01 20:19 ` Hauke Mehrtens
2012-06-01 20:19 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC8762D.8090807@broadcom.com \
--to=arend@broadcom.com \
--cc=b43-dev@lists.infradead.org \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.