From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: tglx@linutronix.de, peterz@infradead.org,
paulmck@linux.vnet.ibm.com, rusty@rustcorp.com.au,
mingo@kernel.org, akpm@linux-foundation.org,
vatsa@linux.vnet.ibm.com, rjw@sisk.pl,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
nikunj@linux.vnet.ibm.com, Ralf Baechle <ralf@linux-mips.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Mike Frysinger <vapier@gentoo.org>,
David Howells <dhowells@redhat.com>, Arun Sharma <asharma@fb.com>,
linux-mips@linux-mips.org
Subject: Re: [PATCH 10/27] mips, smpboot: Use generic SMP booting infrastructure
Date: Sun, 03 Jun 2012 17:18:16 +0530 [thread overview]
Message-ID: <4FCB4F00.8080202@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120603082507.GA16829@zhy>
On 06/03/2012 01:55 PM, Yong Zhang wrote:
> On Fri, Jun 01, 2012 at 02:42:32PM +0530, Srivatsa S. Bhat wrote:
>> Convert mips to use the generic framework to boot secondary CPUs.
>>
>> Notes:
>> 1. The boot processor was setting the secondary cpu in cpu_online_mask!
>> Instead, leave it up to the secondary cpu (... and it will be done by the
>> generic code now).
>>
>> 2. Make the boot cpu wait for the secondary cpu to be set in cpu_online_mask
>> before returning.
>
> We don't need to wait for both cpu_callin_map (The code above yours)
> any more.
Yes, I noticed that while writing the patch. But then, I thought of cleaning
up the hundreds of callin/callout/commenced maps in various architectures and
bringing them out into core code in a later series, and clean this up at that time..
I didn't want to do too many invasive changes all at one-shot.
But I guess for this particular case of mips, I can get rid of the wait for
cpu_callin_map in this patchset itself. I'll update this patch with that change.
Thanks!
>
>>
>> 3. Don't enable interrupts in cmp_smp_finish() and vsmp_smp_finish().
>> Do it much later, in generic code.
>
> Hmmm... the bad thing is that some board enable irq more early than
> ->smp_finish(), I have sent patches for that (by moving irq enable
> to smp_finish() and delaying smp_finish()).
> Please check patch#0001~patch#0004 in
> http://marc.info/?l=linux-mips&m=133758022710973&w=2
>
>>
>> 4. In synchronise_count_slave(), use local_save_flags() instead of
>> local_irq_save() because irqs are still disabled.
>
> We can just remove local_irq_save()/local_irq_restore() like:
> http://marc.info/?l=linux-mips&m=133758046211043&w=2
>
So what is the status of those patches? Has anyone picked them up?
I could rebase this patch on top of yours, or better yet, if your
patches haven't been picked up yet, I could include them in this
patchset itself to avoid too many dependencies on external patches.
What do you say?
Regards,
Srivatsa S. Bhat
next prev parent reply other threads:[~2012-06-03 11:49 UTC|newest]
Thread overview: 195+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 9:10 [PATCH 00/27] Generic framework for SMP booting/CPU hotplug related code Srivatsa S. Bhat
2012-06-01 9:10 ` [PATCH 01/27] smpboot: Provide a generic method to boot secondary processors Srivatsa S. Bhat
2012-06-01 9:10 ` Srivatsa S. Bhat
2012-06-01 9:10 ` Srivatsa S. Bhat
2012-06-01 12:09 ` Srivatsa S. Bhat
2012-06-03 8:51 ` Yong Zhang
2012-06-03 11:22 ` Srivatsa S. Bhat
2012-06-04 2:18 ` Yong Zhang
2012-06-03 8:53 ` Yong Zhang
2012-06-03 11:33 ` Srivatsa S. Bhat
2012-06-03 11:39 ` Russell King - ARM Linux
2012-06-03 12:05 ` Srivatsa S. Bhat
2012-06-01 16:51 ` Sam Ravnborg
2012-06-01 22:29 ` Srivatsa S. Bhat
2012-06-04 10:32 ` Thomas Gleixner
2012-06-04 13:07 ` Srivatsa S. Bhat
2012-06-04 13:18 ` Thomas Gleixner
2012-06-04 16:53 ` Srivatsa S. Bhat
2012-06-05 5:11 ` Yong Zhang
2012-06-05 6:07 ` Srivatsa S. Bhat
2012-06-01 16:53 ` Sam Ravnborg
2012-06-01 22:41 ` Srivatsa S. Bhat
2012-06-02 15:16 ` Sam Ravnborg
2012-06-02 15:34 ` Srivatsa S. Bhat
2012-06-01 9:10 ` [PATCH 02/27] smpboot: Add provisions for arch-specific locking around cpu_online_mask Srivatsa S. Bhat
2012-06-01 9:10 ` Srivatsa S. Bhat
2012-06-01 9:10 ` Srivatsa S. Bhat
2012-06-01 12:12 ` Srivatsa S. Bhat
2012-06-01 9:10 ` [PATCH 03/27] smpboot: Define and use cpu_state per-cpu variable in generic code Srivatsa S. Bhat
2012-06-01 9:10 ` Srivatsa S. Bhat
2012-06-01 9:10 ` Srivatsa S. Bhat
2012-06-01 9:10 ` Srivatsa S. Bhat
2012-06-01 12:19 ` Srivatsa S. Bhat
2012-06-01 12:25 ` Russell King - ARM Linux
2012-06-01 12:55 ` Srivatsa S. Bhat
2012-06-01 16:59 ` David Daney
2012-06-01 16:59 ` David Daney
2012-06-01 16:59 ` David Daney
2012-06-01 16:59 ` David Daney
2012-06-01 9:11 ` [PATCH 04/27] smpboot, x86, xen: Determine smp booting implementations at run-time Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 9:11 ` [PATCH 05/27] xen, cpu hotplug: Don't call cpu_bringup() in xen_play_dead() Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 12:59 ` [Xen-devel] " Jan Beulich
2012-06-01 12:59 ` Jan Beulich
2012-06-01 15:13 ` Srivatsa S. Bhat
2012-06-01 15:36 ` Jan Beulich
2012-06-01 15:36 ` Jan Beulich
2012-06-02 18:06 ` Srivatsa S. Bhat
2012-06-02 18:06 ` Srivatsa S. Bhat
2012-06-05 16:49 ` Konrad Rzeszutek Wilk
2012-06-05 16:49 ` Konrad Rzeszutek Wilk
2012-06-05 17:36 ` Srivatsa S. Bhat
2012-06-05 17:36 ` Srivatsa S. Bhat
2012-06-05 17:40 ` Thomas Gleixner
2012-06-05 17:40 ` Thomas Gleixner
2012-06-05 17:48 ` Srivatsa S. Bhat
2012-06-05 17:48 ` Srivatsa S. Bhat
2012-06-01 15:36 ` Jan Beulich
2012-06-01 15:13 ` Srivatsa S. Bhat
2012-06-01 12:59 ` Jan Beulich
2012-06-01 9:11 ` [PATCH 06/27] xen, smpboot: Use generic SMP booting infrastructure Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 9:11 ` [PATCH 07/27] x86, " Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-04 14:29 ` Thomas Gleixner
2012-06-04 14:29 ` Thomas Gleixner
2012-06-04 17:00 ` Srivatsa S. Bhat
2012-06-01 9:12 ` [PATCH 08/27] m32r: Fix horrible logic in smp_prepare_cpus() Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` [PATCH 09/27] m32r, smpboot: Use generic SMP booting infrastructure Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` [PATCH 10/27] mips, " Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-03 8:25 ` Yong Zhang
2012-06-03 11:48 ` Srivatsa S. Bhat [this message]
2012-06-04 2:17 ` Yong Zhang
2012-06-01 9:12 ` [PATCH 11/27] sh, " Srivatsa S. Bhat
2012-06-01 9:24 ` Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` [PATCH 12/27] tile, " Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 18:07 ` Chris Metcalf
2012-06-01 18:07 ` Chris Metcalf
2012-06-01 9:13 ` [PATCH 13/27] hexagon, " Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:13 ` [PATCH 14/27] ia64: Move holding of vector_lock to __setup_vector_irq() Srivatsa S. Bhat
2012-06-01 9:25 ` Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:13 ` [PATCH 15/27] ia64, smpboot: Use generic SMP booting infrastructure Srivatsa S. Bhat
2012-06-01 9:25 ` Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:13 ` [PATCH 16/27] mn10300: Fix horrible logic in smp_prepare_cpus() Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:14 ` [PATCH 17/27] mn10300, smpboot: Use generic SMP booting infrastructure Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-03 8:33 ` Yong Zhang
2012-06-03 11:50 ` Srivatsa S. Bhat
2012-06-01 9:14 ` [PATCH 18/27] powerpc, " Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-02 6:14 ` Paul Mackerras
2012-06-02 6:14 ` Paul Mackerras
2012-06-01 9:14 ` [PATCH 19/27] blackfin, " Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-01 9:14 ` [PATCH 20/27] sparc64, " Srivatsa S. Bhat
2012-06-01 9:26 ` Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-01 17:55 ` David Miller
2012-06-01 17:55 ` David Miller
2012-06-01 22:44 ` [UPDATED PATCH " Srivatsa S. Bhat
2012-06-01 22:56 ` Srivatsa S. Bhat
2012-06-01 22:52 ` David Miller
2012-06-01 22:52 ` David Miller
2012-06-01 9:15 ` [PATCH 21/27] sparc32, " Srivatsa S. Bhat
2012-06-01 9:27 ` Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 17:56 ` David Miller
2012-06-01 17:56 ` David Miller
2012-06-01 18:54 ` Sam Ravnborg
2012-06-01 18:54 ` Sam Ravnborg
2012-06-01 22:47 ` [UPDATED PATCH " Srivatsa S. Bhat
2012-06-01 22:59 ` Srivatsa S. Bhat
2012-06-01 22:53 ` David Miller
2012-06-01 22:53 ` David Miller
2012-06-01 23:17 ` Srivatsa S. Bhat
2012-06-01 23:29 ` Srivatsa S. Bhat
2012-06-02 6:52 ` Sam Ravnborg
2012-06-02 6:52 ` Sam Ravnborg
2012-06-02 7:44 ` Sam Ravnborg
2012-06-02 7:44 ` Sam Ravnborg
2012-06-02 8:01 ` Srivatsa S. Bhat
2012-06-02 8:13 ` Srivatsa S. Bhat
2012-06-02 8:14 ` Srivatsa S. Bhat
2012-06-02 8:26 ` Srivatsa S. Bhat
2012-06-02 15:13 ` Sam Ravnborg
2012-06-02 15:13 ` Sam Ravnborg
2012-06-02 15:58 ` Srivatsa S. Bhat
2012-06-02 16:10 ` Srivatsa S. Bhat
2012-06-02 16:23 ` Sam Ravnborg
2012-06-02 16:23 ` Sam Ravnborg
2012-06-02 16:34 ` Srivatsa S. Bhat
2012-06-02 16:46 ` Srivatsa S. Bhat
2012-06-03 21:17 ` [PATCH] sparc32: refactor smp boot Sam Ravnborg
2012-06-03 21:17 ` Sam Ravnborg
2012-06-03 21:17 ` Sam Ravnborg
2012-06-03 21:17 ` Sam Ravnborg
2012-06-04 1:04 ` David Miller
2012-06-04 1:04 ` David Miller
2012-06-04 6:48 ` Srivatsa S. Bhat
2012-06-04 6:53 ` Srivatsa S. Bhat
2012-06-01 9:15 ` [PATCH 22/27] um, smpboot: Use generic SMP booting infrastructure Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 9:15 ` [PATCH 23/27] cris, " Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-03 8:41 ` Yong Zhang
2012-06-03 11:52 ` Srivatsa S. Bhat
2012-06-01 9:15 ` [PATCH 24/27] parisc, " Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 9:16 ` [PATCH 25/27] s390, " Srivatsa S. Bhat
2012-06-01 9:16 ` Srivatsa S. Bhat
2012-06-01 9:16 ` Srivatsa S. Bhat
2012-06-01 10:45 ` Heiko Carstens
2012-06-01 9:16 ` [PATCH 26/27] arm, " Srivatsa S. Bhat
2012-06-01 9:16 ` Srivatsa S. Bhat
2012-06-01 9:16 ` Srivatsa S. Bhat
2012-06-01 9:16 ` Srivatsa S. Bhat
2012-06-01 11:04 ` Russell King - ARM Linux
2012-06-01 11:04 ` Russell King - ARM Linux
2012-06-01 9:16 ` [PATCH 27/27] alpha, " Srivatsa S. Bhat
2012-06-01 9:16 ` Srivatsa S. Bhat
2012-06-01 9:16 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCB4F00.8080202@linux.vnet.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=asharma@fb.com \
--cc=dhowells@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@kernel.org \
--cc=nikunj@linux.vnet.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=rjw@sisk.pl \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
--cc=vatsa@linux.vnet.ibm.com \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.