From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: David Miller <davem@davemloft.net>,
tglx@linutronix.de, peterz@infradead.org,
paulmck@linux.vnet.ibm.com, rusty@rustcorp.com.au,
mingo@kernel.org, yong.zhang0@gmail.com,
akpm@linux-foundation.org, vatsa@linux.vnet.ibm.com, rjw@sisk.pl,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
nikunj@linux.vnet.ibm.com, vapier@gentoo.org, konrad@gaisler.com,
tkhai@yandex.ru, sparclinux@vger.kernel.org
Subject: Re: [UPDATED PATCH 21/27] sparc32, smpboot: Use generic SMP booting infrastructure
Date: Sat, 02 Jun 2012 22:04:45 +0530 [thread overview]
Message-ID: <4FCA40A5.3060409@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120602162340.GA27530@merkur.ravnborg.org>
On 06/02/2012 09:53 PM, Sam Ravnborg wrote:
>>
>> As I mentioned in my other mail, I am thinking of changing them to
>> arch_cpu_pre_starting(), arch_cpu_pre_online() and arch_cpu_post_online().
>> Let me know what you think of those names.
> Much better than "__" - so if none of the guys that excel in core
> code objects go for that.
>
Ok..
>> Would you kindly add a changelog and your sign-off to this patch?
> Will do in next revision.
>
Great!
> ...
>
> Thanks for the throughfull review.
> I will address all points - including passing the pointer down,
> as I assume you have some future plans with that pointer.
>
>>
>> I still didn't get how this solves the original problem of
>> not having sparc_cpu_model set to sparc_leon. You mentioned
>> that by the time we reach leon_smp_cpu_startup, that variable
>> is not set. Even inside leon_smp_cpu_startup, I don't immediately
>> see where it is set. Am I missing something?
>
> After looking more closely at the code it is my understanding
> that a leon CPU when started will actually jump to the reset
> vector and start from there.
> So the secondary CPU's will run long time after
> sparc_cpu_model is set so we can safely use it.
>
> The sun based cpu will in comparsion jump to
> an address supplied to a prom call - so they do not
> jump to the reset vector.
> But they also have sparc_cpu_model set so no problem there
> either.
>
Ok..
> All this are my deductions from reading the code - but this
> is not an area I have looked at otherwise..
>
> I may not find time today to cook up a new version of
> the patch - but then you will have it tomorrow.
>
Sure! Once again, thanks a lot for your time and efforts :-)
Regards,
Srivatsa S. Bhat
WARNING: multiple messages have this Message-ID (diff)
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: David Miller <davem@davemloft.net>,
tglx@linutronix.de, peterz@infradead.org,
paulmck@linux.vnet.ibm.com, rusty@rustcorp.com.au,
mingo@kernel.org, yong.zhang0@gmail.com,
akpm@linux-foundation.org, vatsa@linux.vnet.ibm.com, rjw@sisk.pl,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
nikunj@linux.vnet.ibm.com, vapier@gentoo.org, konrad@gaisler.com,
tkhai@yandex.ru, sparclinux@vger.kernel.org
Subject: Re: [UPDATED PATCH 21/27] sparc32, smpboot: Use generic SMP booting infrastructure
Date: Sat, 02 Jun 2012 16:46:45 +0000 [thread overview]
Message-ID: <4FCA40A5.3060409@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120602162340.GA27530@merkur.ravnborg.org>
On 06/02/2012 09:53 PM, Sam Ravnborg wrote:
>>
>> As I mentioned in my other mail, I am thinking of changing them to
>> arch_cpu_pre_starting(), arch_cpu_pre_online() and arch_cpu_post_online().
>> Let me know what you think of those names.
> Much better than "__" - so if none of the guys that excel in core
> code objects go for that.
>
Ok..
>> Would you kindly add a changelog and your sign-off to this patch?
> Will do in next revision.
>
Great!
> ...
>
> Thanks for the throughfull review.
> I will address all points - including passing the pointer down,
> as I assume you have some future plans with that pointer.
>
>>
>> I still didn't get how this solves the original problem of
>> not having sparc_cpu_model set to sparc_leon. You mentioned
>> that by the time we reach leon_smp_cpu_startup, that variable
>> is not set. Even inside leon_smp_cpu_startup, I don't immediately
>> see where it is set. Am I missing something?
>
> After looking more closely at the code it is my understanding
> that a leon CPU when started will actually jump to the reset
> vector and start from there.
> So the secondary CPU's will run long time after
> sparc_cpu_model is set so we can safely use it.
>
> The sun based cpu will in comparsion jump to
> an address supplied to a prom call - so they do not
> jump to the reset vector.
> But they also have sparc_cpu_model set so no problem there
> either.
>
Ok..
> All this are my deductions from reading the code - but this
> is not an area I have looked at otherwise..
>
> I may not find time today to cook up a new version of
> the patch - but then you will have it tomorrow.
>
Sure! Once again, thanks a lot for your time and efforts :-)
Regards,
Srivatsa S. Bhat
next prev parent reply other threads:[~2012-06-02 16:35 UTC|newest]
Thread overview: 195+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 9:10 [PATCH 00/27] Generic framework for SMP booting/CPU hotplug related code Srivatsa S. Bhat
2012-06-01 9:10 ` [PATCH 01/27] smpboot: Provide a generic method to boot secondary processors Srivatsa S. Bhat
2012-06-01 9:10 ` Srivatsa S. Bhat
2012-06-01 9:10 ` Srivatsa S. Bhat
2012-06-01 12:09 ` Srivatsa S. Bhat
2012-06-03 8:51 ` Yong Zhang
2012-06-03 11:22 ` Srivatsa S. Bhat
2012-06-04 2:18 ` Yong Zhang
2012-06-03 8:53 ` Yong Zhang
2012-06-03 11:33 ` Srivatsa S. Bhat
2012-06-03 11:39 ` Russell King - ARM Linux
2012-06-03 12:05 ` Srivatsa S. Bhat
2012-06-01 16:51 ` Sam Ravnborg
2012-06-01 22:29 ` Srivatsa S. Bhat
2012-06-04 10:32 ` Thomas Gleixner
2012-06-04 13:07 ` Srivatsa S. Bhat
2012-06-04 13:18 ` Thomas Gleixner
2012-06-04 16:53 ` Srivatsa S. Bhat
2012-06-05 5:11 ` Yong Zhang
2012-06-05 6:07 ` Srivatsa S. Bhat
2012-06-01 16:53 ` Sam Ravnborg
2012-06-01 22:41 ` Srivatsa S. Bhat
2012-06-02 15:16 ` Sam Ravnborg
2012-06-02 15:34 ` Srivatsa S. Bhat
2012-06-01 9:10 ` [PATCH 02/27] smpboot: Add provisions for arch-specific locking around cpu_online_mask Srivatsa S. Bhat
2012-06-01 9:10 ` Srivatsa S. Bhat
2012-06-01 9:10 ` Srivatsa S. Bhat
2012-06-01 12:12 ` Srivatsa S. Bhat
2012-06-01 9:10 ` [PATCH 03/27] smpboot: Define and use cpu_state per-cpu variable in generic code Srivatsa S. Bhat
2012-06-01 9:10 ` Srivatsa S. Bhat
2012-06-01 9:10 ` Srivatsa S. Bhat
2012-06-01 9:10 ` Srivatsa S. Bhat
2012-06-01 12:19 ` Srivatsa S. Bhat
2012-06-01 12:25 ` Russell King - ARM Linux
2012-06-01 12:55 ` Srivatsa S. Bhat
2012-06-01 16:59 ` David Daney
2012-06-01 16:59 ` David Daney
2012-06-01 16:59 ` David Daney
2012-06-01 16:59 ` David Daney
2012-06-01 9:11 ` [PATCH 04/27] smpboot, x86, xen: Determine smp booting implementations at run-time Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 9:11 ` [PATCH 05/27] xen, cpu hotplug: Don't call cpu_bringup() in xen_play_dead() Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 12:59 ` [Xen-devel] " Jan Beulich
2012-06-01 12:59 ` Jan Beulich
2012-06-01 15:13 ` Srivatsa S. Bhat
2012-06-01 15:36 ` Jan Beulich
2012-06-01 15:36 ` Jan Beulich
2012-06-01 15:36 ` Jan Beulich
2012-06-02 18:06 ` Srivatsa S. Bhat
2012-06-02 18:06 ` Srivatsa S. Bhat
2012-06-05 16:49 ` Konrad Rzeszutek Wilk
2012-06-05 16:49 ` Konrad Rzeszutek Wilk
2012-06-05 17:36 ` Srivatsa S. Bhat
2012-06-05 17:36 ` Srivatsa S. Bhat
2012-06-05 17:40 ` Thomas Gleixner
2012-06-05 17:40 ` Thomas Gleixner
2012-06-05 17:48 ` Srivatsa S. Bhat
2012-06-05 17:48 ` Srivatsa S. Bhat
2012-06-01 15:13 ` Srivatsa S. Bhat
2012-06-01 12:59 ` Jan Beulich
2012-06-01 9:11 ` [PATCH 06/27] xen, smpboot: Use generic SMP booting infrastructure Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 9:11 ` [PATCH 07/27] x86, " Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-01 9:11 ` Srivatsa S. Bhat
2012-06-04 14:29 ` Thomas Gleixner
2012-06-04 14:29 ` Thomas Gleixner
2012-06-04 17:00 ` Srivatsa S. Bhat
2012-06-01 9:12 ` [PATCH 08/27] m32r: Fix horrible logic in smp_prepare_cpus() Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` [PATCH 09/27] m32r, smpboot: Use generic SMP booting infrastructure Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` [PATCH 10/27] mips, " Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-03 8:25 ` Yong Zhang
2012-06-03 11:48 ` Srivatsa S. Bhat
2012-06-04 2:17 ` Yong Zhang
2012-06-01 9:12 ` [PATCH 11/27] sh, " Srivatsa S. Bhat
2012-06-01 9:24 ` Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` [PATCH 12/27] tile, " Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 9:12 ` Srivatsa S. Bhat
2012-06-01 18:07 ` Chris Metcalf
2012-06-01 18:07 ` Chris Metcalf
2012-06-01 9:13 ` [PATCH 13/27] hexagon, " Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:13 ` [PATCH 14/27] ia64: Move holding of vector_lock to __setup_vector_irq() Srivatsa S. Bhat
2012-06-01 9:25 ` Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:13 ` [PATCH 15/27] ia64, smpboot: Use generic SMP booting infrastructure Srivatsa S. Bhat
2012-06-01 9:25 ` Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:13 ` [PATCH 16/27] mn10300: Fix horrible logic in smp_prepare_cpus() Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:13 ` Srivatsa S. Bhat
2012-06-01 9:14 ` [PATCH 17/27] mn10300, smpboot: Use generic SMP booting infrastructure Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-03 8:33 ` Yong Zhang
2012-06-03 11:50 ` Srivatsa S. Bhat
2012-06-01 9:14 ` [PATCH 18/27] powerpc, " Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-02 6:14 ` Paul Mackerras
2012-06-02 6:14 ` Paul Mackerras
2012-06-01 9:14 ` [PATCH 19/27] blackfin, " Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-01 9:14 ` [PATCH 20/27] sparc64, " Srivatsa S. Bhat
2012-06-01 9:26 ` Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-01 9:14 ` Srivatsa S. Bhat
2012-06-01 17:55 ` David Miller
2012-06-01 17:55 ` David Miller
2012-06-01 22:44 ` [UPDATED PATCH " Srivatsa S. Bhat
2012-06-01 22:56 ` Srivatsa S. Bhat
2012-06-01 22:52 ` David Miller
2012-06-01 22:52 ` David Miller
2012-06-01 9:15 ` [PATCH 21/27] sparc32, " Srivatsa S. Bhat
2012-06-01 9:27 ` Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 17:56 ` David Miller
2012-06-01 17:56 ` David Miller
2012-06-01 18:54 ` Sam Ravnborg
2012-06-01 18:54 ` Sam Ravnborg
2012-06-01 22:47 ` [UPDATED PATCH " Srivatsa S. Bhat
2012-06-01 22:59 ` Srivatsa S. Bhat
2012-06-01 22:53 ` David Miller
2012-06-01 22:53 ` David Miller
2012-06-01 23:17 ` Srivatsa S. Bhat
2012-06-01 23:29 ` Srivatsa S. Bhat
2012-06-02 6:52 ` Sam Ravnborg
2012-06-02 6:52 ` Sam Ravnborg
2012-06-02 7:44 ` Sam Ravnborg
2012-06-02 7:44 ` Sam Ravnborg
2012-06-02 8:01 ` Srivatsa S. Bhat
2012-06-02 8:13 ` Srivatsa S. Bhat
2012-06-02 8:14 ` Srivatsa S. Bhat
2012-06-02 8:26 ` Srivatsa S. Bhat
2012-06-02 15:13 ` Sam Ravnborg
2012-06-02 15:13 ` Sam Ravnborg
2012-06-02 15:58 ` Srivatsa S. Bhat
2012-06-02 16:10 ` Srivatsa S. Bhat
2012-06-02 16:23 ` Sam Ravnborg
2012-06-02 16:23 ` Sam Ravnborg
2012-06-02 16:34 ` Srivatsa S. Bhat [this message]
2012-06-02 16:46 ` Srivatsa S. Bhat
2012-06-03 21:17 ` [PATCH] sparc32: refactor smp boot Sam Ravnborg
2012-06-03 21:17 ` Sam Ravnborg
2012-06-03 21:17 ` Sam Ravnborg
2012-06-03 21:17 ` Sam Ravnborg
2012-06-04 1:04 ` David Miller
2012-06-04 1:04 ` David Miller
2012-06-04 6:48 ` Srivatsa S. Bhat
2012-06-04 6:53 ` Srivatsa S. Bhat
2012-06-01 9:15 ` [PATCH 22/27] um, smpboot: Use generic SMP booting infrastructure Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 9:15 ` [PATCH 23/27] cris, " Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-03 8:41 ` Yong Zhang
2012-06-03 11:52 ` Srivatsa S. Bhat
2012-06-01 9:15 ` [PATCH 24/27] parisc, " Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 9:15 ` Srivatsa S. Bhat
2012-06-01 9:16 ` [PATCH 25/27] s390, " Srivatsa S. Bhat
2012-06-01 9:16 ` Srivatsa S. Bhat
2012-06-01 9:16 ` Srivatsa S. Bhat
2012-06-01 10:45 ` Heiko Carstens
2012-06-01 9:16 ` [PATCH 26/27] arm, " Srivatsa S. Bhat
2012-06-01 9:16 ` Srivatsa S. Bhat
2012-06-01 9:16 ` Srivatsa S. Bhat
2012-06-01 9:16 ` Srivatsa S. Bhat
2012-06-01 11:04 ` Russell King - ARM Linux
2012-06-01 11:04 ` Russell King - ARM Linux
2012-06-01 9:16 ` [PATCH 27/27] alpha, " Srivatsa S. Bhat
2012-06-01 9:16 ` Srivatsa S. Bhat
2012-06-01 9:16 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCA40A5.3060409@linux.vnet.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=konrad@gaisler.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nikunj@linux.vnet.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rjw@sisk.pl \
--cc=rusty@rustcorp.com.au \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tkhai@yandex.ru \
--cc=vapier@gentoo.org \
--cc=vatsa@linux.vnet.ibm.com \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.