Re: [PATCH] rename MEM_CGROUP_STAT_SWAPOUT as MEM_CGROUP_STAT_NR_SWAP

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Kamezawa Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
To: Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	mhocko-AlSwsSmVLrQ@public.gmane.org,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Subject: Re: [PATCH] rename MEM_CGROUP_STAT_SWAPOUT as MEM_CGROUP_STAT_NR_SWAP
Date: Mon, 04 Jun 2012 09:24:00 +0900	[thread overview]
Message-ID: <4FCC0020.5080801@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1206011047430.9814-fupSdm12i1nKWymIFiNcPA@public.gmane.org>

(2012/06/02 2:54), Hugh Dickins wrote:
> On Fri, 1 Jun 2012, Johannes Weiner wrote:
>> On Fri, Jun 01, 2012 at 07:39:00PM +0900, Kamezawa Hiroyuki wrote:
>>> MEM_CGROUP_STAT_SWAPOUT represents the usage of swap rather than
>>> the number of swap-out events. Rename it to be MEM_CGROUP_STAT_NR_SWAP.
>>>
>>> Signed-off-by: KAMEZAWA Hiroyuki<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
>>
>> Wouldn't MEM_CGROUP_STAT_SWAP be better?  It's equally descriptive but
>> matches the string.  And we also don't have NR_ for cache, rss, mapped
>> file etc.
>
> That's just what I thought too.
>
> You can attach Acked-by: Hugh Dickins<hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> to MEM_CGROUP_STAT_SWAP and MEM_CGROUP_CHARGE_TYPE_ANON.
>
> Oh, and to a patch deleting MEM_CGROUP_CHARGE_TYPE_FORCE!
>
Sure, I'll prepare v2.

Thanks,
-Kame

WARNING: multiple messages have this Message-ID (diff)

From: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Hugh Dickins <hughd@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	linux-mm@kvack.org, cgroups@vger.kernel.org, mhocko@suse.cz,
	akpm@linux-foundation.org
Subject: Re: [PATCH] rename MEM_CGROUP_STAT_SWAPOUT as MEM_CGROUP_STAT_NR_SWAP
Date: Mon, 04 Jun 2012 09:24:00 +0900	[thread overview]
Message-ID: <4FCC0020.5080801@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1206011047430.9814@eggly.anvils>

(2012/06/02 2:54), Hugh Dickins wrote:
> On Fri, 1 Jun 2012, Johannes Weiner wrote:
>> On Fri, Jun 01, 2012 at 07:39:00PM +0900, Kamezawa Hiroyuki wrote:
>>> MEM_CGROUP_STAT_SWAPOUT represents the usage of swap rather than
>>> the number of swap-out events. Rename it to be MEM_CGROUP_STAT_NR_SWAP.
>>>
>>> Signed-off-by: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com>
>>
>> Wouldn't MEM_CGROUP_STAT_SWAP be better?  It's equally descriptive but
>> matches the string.  And we also don't have NR_ for cache, rss, mapped
>> file etc.
>
> That's just what I thought too.
>
> You can attach Acked-by: Hugh Dickins<hughd@google.com>
> to MEM_CGROUP_STAT_SWAP and MEM_CGROUP_CHARGE_TYPE_ANON.
>
> Oh, and to a patch deleting MEM_CGROUP_CHARGE_TYPE_FORCE!
>
Sure, I'll prepare v2.

Thanks,
-Kame


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

next prev parent reply	other threads:[~2012-06-04  0:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-01 10:39 [PATCH] rename MEM_CGROUP_STAT_SWAPOUT as MEM_CGROUP_STAT_NR_SWAP Kamezawa Hiroyuki
     [not found] ` <4FC89BC4.9030604-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-06-01 11:11   ` Michal Hocko
2012-06-01 11:11     ` Michal Hocko
2012-06-01 16:53   ` Johannes Weiner
2012-06-01 16:53     ` Johannes Weiner
     [not found]     ` <20120601165320.GA1761-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2012-06-01 17:54       ` Hugh Dickins
2012-06-01 17:54         ` Hugh Dickins
     [not found]         ` <alpine.LSU.2.00.1206011047430.9814-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2012-06-04  0:24           ` Kamezawa Hiroyuki [this message]
2012-06-04  0:24             ` Kamezawa Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FCC0020.5080801@jp.fujitsu.com \
    --to=kamezawa.hiroyu-+cum20s59erqfuhtdcdx3a@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.