From: Vladimir Davydov <vdavydov@parallels.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>,
Arjan van de Ven <arjan@linux.intel.com>,
Len Brown <lenb@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpuidle: menu: use nr_running instead of cpuload for calculating perf mult
Date: Mon, 4 Jun 2012 14:50:20 +0400 [thread overview]
Message-ID: <4FCC92EC.2000808@parallels.com> (raw)
In-Reply-To: <1338805967.28282.12.camel@twins>
On 06/04/2012 02:32 PM, Peter Zijlstra wrote:
> On Mon, 2012-06-04 at 14:24 +0400, Vladimir Davydov wrote:
>> rq->cpuload strongly depends on cgroup hierarchy. For example, if hundreds of
>> tasks are running inside cpu:/test cgroup, the sum of cpuload over all cpus
>> won't exceed 1024 (by default). That makes the cpuidle menu governor take wrong
>> decisions, which can negatively affect overall performance.
>>
>> To cope this, use nr_running last seen in __update_cpu_load() instead of
>> cpuload for calculating performance multiplier.
> What is cpuidle trying to do?
Basing on cpuload, it selects idle state. The less the load, the lowest
the state.
next prev parent reply other threads:[~2012-06-04 10:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 10:24 [PATCH] cpuidle: menu: use nr_running instead of cpuload for calculating perf mult Vladimir Davydov
2012-06-04 10:32 ` Peter Zijlstra
2012-06-04 10:50 ` Vladimir Davydov [this message]
2012-06-04 13:13 ` Arjan van de Ven
2012-06-04 13:45 ` Peter Zijlstra
2012-06-04 13:48 ` Arjan van de Ven
2012-06-04 15:08 ` Peter Zijlstra
2012-06-04 15:14 ` Arjan van de Ven
2012-06-04 15:26 ` Peter Zijlstra
2012-06-04 15:39 ` Arjan van de Ven
2012-06-04 16:33 ` Peter Zijlstra
2012-06-04 16:53 ` Arjan van de Ven
2012-06-04 17:08 ` Vladimir Davydov
2012-06-04 17:17 ` Peter Zijlstra
2012-06-04 17:16 ` Peter Zijlstra
2012-06-04 17:25 ` Arjan van de Ven
2012-06-04 20:31 ` Peter Zijlstra
2012-06-04 20:45 ` Arjan van de Ven
2012-06-04 21:14 ` Peter Zijlstra
2012-06-04 20:40 ` Peter Zijlstra
2012-06-05 3:48 ` Mike Galbraith
2012-06-04 13:15 ` Arjan van de Ven
2012-06-04 13:19 ` Vladimir Davydov
2012-11-27 19:02 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCC92EC.2000808@parallels.com \
--to=vdavydov@parallels.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.