From: Don Dutile <ddutile-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: chrisw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
suresh.b.siddha-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
mingo-X9Un+BFzKDI@public.gmane.org,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org
Subject: Re: [PATCH 1/2] iommu: dmar: replace printks with appropriate pr_*()
Date: Mon, 04 Jun 2012 18:28:09 -0400 [thread overview]
Message-ID: <4FCD3679.60706@redhat.com> (raw)
In-Reply-To: <1338848137.18442.2.camel@joe2Laptop>
On 06/04/2012 06:15 PM, Joe Perches wrote:
> On Mon, 2012-06-04 at 17:29 -0400, Donald Dutile wrote:
>> Replace printk(KERN_* with pr_*() functions.
>
> Please add
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> before any include and remove the embedded PREFIX
> from each printk
>
>> diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
>
> []
>
>> break;
>> }
>> pdev = pci_get_slot(bus, PCI_DEVFN(path->dev, path->fn));
>> if (!pdev) {
>> - printk(KERN_WARNING PREFIX
>> - "Device scope device [%04x:%02x:%02x.%02x] not found\n",
>> + pr_warn(PREFIX "Device scope device"
>> + "[%04x:%02x:%02x.%02x] not found\n",
>> segment, bus->number, path->dev, path->fn);
>
> Please don't split any format string. You removed
> a space between the scope device and an open bracket.
> It's OK for format strings to exceed 80 chars.
>
>
Joe,
Thanks for the feeback. I'll incorporate the changes once
others have a chance to review & feedback as well.
- Don
WARNING: multiple messages have this Message-ID (diff)
From: Don Dutile <ddutile@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: dwmw2@infradead.org, iommu@lists.linux-foundation.org,
mingo@elte.hu, linux-kernel@vger.kernel.org, chrisw@redhat.com,
suresh.b.siddha@intel.com
Subject: Re: [PATCH 1/2] iommu: dmar: replace printks with appropriate pr_*()
Date: Mon, 04 Jun 2012 18:28:09 -0400 [thread overview]
Message-ID: <4FCD3679.60706@redhat.com> (raw)
In-Reply-To: <1338848137.18442.2.camel@joe2Laptop>
On 06/04/2012 06:15 PM, Joe Perches wrote:
> On Mon, 2012-06-04 at 17:29 -0400, Donald Dutile wrote:
>> Replace printk(KERN_* with pr_*() functions.
>
> Please add
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> before any include and remove the embedded PREFIX
> from each printk
>
>> diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
>
> []
>
>> break;
>> }
>> pdev = pci_get_slot(bus, PCI_DEVFN(path->dev, path->fn));
>> if (!pdev) {
>> - printk(KERN_WARNING PREFIX
>> - "Device scope device [%04x:%02x:%02x.%02x] not found\n",
>> + pr_warn(PREFIX "Device scope device"
>> + "[%04x:%02x:%02x.%02x] not found\n",
>> segment, bus->number, path->dev, path->fn);
>
> Please don't split any format string. You removed
> a space between the scope device and an open bracket.
> It's OK for format strings to exceed 80 chars.
>
>
Joe,
Thanks for the feeback. I'll incorporate the changes once
others have a chance to review & feedback as well.
- Don
next prev parent reply other threads:[~2012-06-04 22:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 21:29 [PATCH 0/2]intel-iommu: reserve IOMMU register space Donald Dutile
2012-06-04 21:29 ` Donald Dutile
[not found] ` <1338845342-12464-1-git-send-email-ddutile-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-06-04 21:29 ` [PATCH 1/2] iommu: dmar: replace printks with appropriate pr_*() Donald Dutile
2012-06-04 21:29 ` Donald Dutile
[not found] ` <1338845342-12464-2-git-send-email-ddutile-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-06-04 22:15 ` Joe Perches
2012-06-04 22:15 ` Joe Perches
2012-06-04 22:28 ` Don Dutile [this message]
2012-06-04 22:28 ` Don Dutile
2012-06-08 14:55 ` [tip:core/iommu] iommu/dmar: Replace printks with appropriate pr_* () tip-bot for Donald Dutile
2012-06-04 21:29 ` [PATCH 2/2] iommu: dmar -- reserve mmio space used by IOMMU Donald Dutile
2012-06-04 21:29 ` Donald Dutile
[not found] ` <1338845342-12464-3-git-send-email-ddutile-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-06-04 22:37 ` David Woodhouse
2012-06-04 22:37 ` David Woodhouse
[not found] ` <1338849430.10884.288.camel-Fexsq3y4057IgHVZqg5X0TlWvGAXklZc@public.gmane.org>
2012-06-04 23:09 ` Don Dutile
2012-06-04 23:09 ` Don Dutile
[not found] ` <4FCD401D.9000304-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-06-04 23:23 ` David Woodhouse
2012-06-04 23:23 ` David Woodhouse
[not found] ` <1338852196.26785.10.camel-Fexsq3y4057IgHVZqg5X0TlWvGAXklZc@public.gmane.org>
2012-06-04 23:52 ` Don Dutile
2012-06-04 23:52 ` Don Dutile
2012-06-06 8:16 ` Ingo Molnar
2012-06-06 8:16 ` Ingo Molnar
[not found] ` <20120606081600.GB5991-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-06-06 8:26 ` David Woodhouse
2012-06-06 8:26 ` David Woodhouse
[not found] ` <1338971183.26785.33.camel-Fexsq3y4057IgHVZqg5X0TlWvGAXklZc@public.gmane.org>
2012-06-06 8:29 ` Ingo Molnar
2012-06-06 8:29 ` Ingo Molnar
[not found] ` <20120606082900.GF5991-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-06-06 8:45 ` David Woodhouse
2012-06-06 8:45 ` David Woodhouse
[not found] ` <1338972329.26785.34.camel-Fexsq3y4057IgHVZqg5X0TlWvGAXklZc@public.gmane.org>
2012-06-06 23:56 ` Chris Wright
2012-06-06 23:56 ` Chris Wright
2012-06-06 23:58 ` Chris Wright
2012-06-06 23:58 ` Chris Wright
2012-06-08 14:56 ` [tip:core/iommu] iommu/dmar: Reserve mmio space used by the IOMMU, if the BIOS forgets to tip-bot for Donald Dutile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCD3679.60706@redhat.com \
--to=ddutile-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=chrisw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-X9Un+BFzKDI@public.gmane.org \
--cc=suresh.b.siddha-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.