Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options

[Anthony Liguori <aliguori@us.ibm.com>]

On 06/06/2012 11:31 AM, Benjamin Herrenschmidt wrote:
> On Wed, 2012-06-06 at 10:52 +0800, li zhang wrote:
>> Hi Anthony,
>>
>>
>> Any comment on this?
>
> Allright, this is all quite confusing...
>
> He's what I think should happen:
>
> When no option is passed -at-all-, we should have vga std and usb ohci +
> usb mouse + usb ps2.
>
> When -nodefault is passed, we should have none of the above.

-nodefault is a pretty ugly hack.  I don't think there's any good reason to 
involve -nodefault into this discussion.

>
> -vga should only affect vga (a shortcut for -device
> pick_your_vga_poison)

Ack.

>
> -usb should be essentially useless by default unless -nodefault is
> passed in which case it is necessary to enable usb support, and -device
> (or equivalent) to manually add the keyboard and mouse (libvirt).

If you want pseries to always have usb, just make it there by default and yeah, 
-usb would be useless.  If you want the option to not have usb, introduce a 
machine option I guess.

I think it's over thinking it though.  There's little harm in having a usb 
controller present all the time.

Regards,

Anthony Liguori

>
> That's the best I can think of ... however it might be a bit tricky
> seeing how qemu does things in vl.c at the moment, we might want to
> introduce a default_usb variable which is used to set usb_enabled.
>
> BTW. The mac models should essentially behave the same, at least the
> 64-bit one (32-bit supports CUDA for keyboard/mouse so USB isn't
> strictly necessary).
>
> Cheers,
> Ben.
>>
>> Thanks.
>>
>> On Tue, Jun 5, 2012 at 5:48 PM, li zhang<zhlcindy@gmail.com>  wrote:
>>          Hi all,
>>
>>          For pseries, when creating VMs with "-vga std",
>>          it requires usb mouse and usb kbd devices to be added.
>>
>>          But with default options, vga is enabled and usb is disabled.
>>          User may use default options as the following commands:
>>
>>          $qemu -M pseries
>>
>>          If vga is enabled, usb mouse and usb kbd is disabled,
>>          the mouse and kbd can't be used. So it's very hard for
>>          users to use.
>>
>>          I think it's necessary to enable usb with default options.
>>
>>          Any idea about that?
>>          Your comments  are very appreciated. :)
>>
>>          Thanks.
>>           -Li
>>
>>
>>
>>
>> --
>>
>>
>> Best Regards
>> -Li
>>
>>
>
>