All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Benjamin Herrenschmidt <benh@au1.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	li zhang <zhlcindy@gmail.com>,
	qemu-devel@nongnu.org, zhlcindy@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [qemu-devel][RFC] Enable usb with default options
Date: Thu, 07 Jun 2012 11:50:41 +0200	[thread overview]
Message-ID: <4FD07971.1020205@redhat.com> (raw)
In-Reply-To: <1339060579.24838.19.camel@pasglop>

Hi,

On 06/07/2012 11:16 AM, Benjamin Herrenschmidt wrote:
> On Thu, 2012-06-07 at 10:52 +0200, Hans de Goede wrote:
>>> At least that would improve the situation in the long run...
>>>
>>> Side note: It might be able to add an option at least to OHCI and EHCI
>>> to relax a bit the correctness of the emulation and dramatically reduce
>>> the number of exits.
>>>
>>> One way to do that is to simply reduce the timer by a factor of 10 or
>>> 100 (and increment frame numbers in bulk). This could be reasonably
>>> safely done when SOF interrupts aren't enabled, especially when only HID
>>> devices are on the bus. We could alternatively schedule additional
>>> arbitrary frames in between whenever a HID event is actually present.
>>>
>>
>> We (me and Gerd Hoffmann) have investigated that, and experimented with it.
>> It will work for simply devices, but isochronous devices break. The real
>> solution at least for x86 vms is to get the XHCI emulation finished, as
>> the XHCI controller has a much nicer hw interface from an emulation pov,
>> and it can handle usb 1-3 devices.
>
> I absolutely agree, but it will take some time for xhci to trickle
> (especially since most powerpc distros today don't have it guest side,
> we only recently endian-fixed the driver).
>
> In the meantime, this approach you experimented with would be very
> useful for us  in the common case where there is no isochronous device.
> It shouldn't be too hard for the emulator to switch back to "normal"
> frames if an ISO EP is present, no ?

That should be possible yes. Note though that although slowing down the
timer will only break isoc. stuff, it will for example also slow down
usb mass storage devices.

> That would solve the 99% case of just keyboard and mouse on all those
> machines.
>
> Do you have some patches around from those earlier experiments that we
> could try to revive, at least for OHCI ?

No, I only did this for EHCI, which may still have an option to enable
this today. Gerd may have done this for UHCI too, Gerd ?

Regards,

Hans

  reply	other threads:[~2012-06-07  9:50 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-05  9:48 [Qemu-devel] [qemu-devel][RFC] Enable usb with default options li zhang
2012-06-06  2:52 ` li zhang
2012-06-06  3:31   ` Benjamin Herrenschmidt
2012-06-06  5:42     ` Anthony Liguori
2012-06-06  6:03       ` li zhang
2012-06-06 21:13       ` Benjamin Herrenschmidt
2012-06-07  1:15         ` Anthony Liguori
2012-06-07  3:00           ` Benjamin Herrenschmidt
2012-06-07  3:03             ` Anthony Liguori
2012-06-07  4:52             ` li zhang
2012-06-07  4:39           ` li zhang
2012-06-07  4:43             ` Anthony Liguori
2012-06-07  4:53               ` li zhang
2012-06-07  8:07           ` Markus Armbruster
2012-06-07  9:19             ` Anthony Liguori
2012-06-07 10:05               ` Markus Armbruster
2012-06-07 11:51                 ` Anthony Liguori
2012-06-12  8:06                   ` Markus Armbruster
2012-06-07  8:32         ` Hans de Goede
2012-06-07  8:40           ` Benjamin Herrenschmidt
2012-06-07  8:49             ` Paolo Bonzini
2012-06-07  8:52             ` Hans de Goede
2012-06-07  9:05               ` Gerd Hoffmann
2012-06-07  9:17                 ` Benjamin Herrenschmidt
2012-06-07  9:29                   ` Li Zhang
2012-06-07  9:16               ` Benjamin Herrenschmidt
2012-06-07  9:50                 ` Hans de Goede [this message]
2012-06-07 11:19                   ` Benjamin Herrenschmidt
2012-06-07 11:35                   ` Gerd Hoffmann
2012-06-07  8:54             ` Gerd Hoffmann
2012-06-06 22:14     ` Andreas Färber
  -- strict thread matches above, loose matches on Subject: below --
2012-06-05  7:19 Li Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD07971.1020205@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=benh@au1.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhlcindy@gmail.com \
    --cc=zhlcindy@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.