From: Roland Stigge <stigge@antcom.de>
To: dedekind1@gmail.com
Cc: srinivas.bakki@nxp.com, lars@metafoo.de, linux@arm.linux.org.uk,
linux-doc@vger.kernel.org, leiwen@marvell.com,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, kevin.wells@nxp.com,
b32955@freescale.com, linux-mtd@lists.infradead.org,
hechtb@googlemail.com, dwmw2@infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5] MTD: LPC32xx SLC NAND driver
Date: Wed, 06 Jun 2012 11:01:44 +0200 [thread overview]
Message-ID: <4FCF1C78.5000309@antcom.de> (raw)
In-Reply-To: <1338972168.6875.7.camel@sauron.fi.intel.com>
On 06/06/2012 10:42 AM, Artem Bityutskiy wrote:
> On Mon, 2012-06-04 at 21:25 +0200, Roland Stigge wrote:
>> +config MTD_NAND_SLC_LPC32XX + bool "NXP LPC32xx SLC Controller"
>
> Why bool and not tristate here? Why you force this to be
> compiled-in and make it impossible to be a kernel module like other
> drivers are?
Right - the solution for both issues you mention (compiling as module
and linker error) is replacing above "bool" with "tristate".
Will post an updated patch.
Thanks,
Roland
WARNING: multiple messages have this Message-ID (diff)
From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] MTD: LPC32xx SLC NAND driver
Date: Wed, 06 Jun 2012 11:01:44 +0200 [thread overview]
Message-ID: <4FCF1C78.5000309@antcom.de> (raw)
In-Reply-To: <1338972168.6875.7.camel@sauron.fi.intel.com>
On 06/06/2012 10:42 AM, Artem Bityutskiy wrote:
> On Mon, 2012-06-04 at 21:25 +0200, Roland Stigge wrote:
>> +config MTD_NAND_SLC_LPC32XX + bool "NXP LPC32xx SLC Controller"
>
> Why bool and not tristate here? Why you force this to be
> compiled-in and make it impossible to be a kernel module like other
> drivers are?
Right - the solution for both issues you mention (compiling as module
and linker error) is replacing above "bool" with "tristate".
Will post an updated patch.
Thanks,
Roland
WARNING: multiple messages have this Message-ID (diff)
From: Roland Stigge <stigge@antcom.de>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
dwmw2@infradead.org, kevin.wells@nxp.com, srinivas.bakki@nxp.com,
linux-arm-kernel@lists.infradead.org, hechtb@googlemail.com,
lars@metafoo.de, b32955@freescale.com, leiwen@marvell.com,
linux@arm.linux.org.uk
Subject: Re: [PATCH v5] MTD: LPC32xx SLC NAND driver
Date: Wed, 06 Jun 2012 11:01:44 +0200 [thread overview]
Message-ID: <4FCF1C78.5000309@antcom.de> (raw)
In-Reply-To: <1338972168.6875.7.camel@sauron.fi.intel.com>
On 06/06/2012 10:42 AM, Artem Bityutskiy wrote:
> On Mon, 2012-06-04 at 21:25 +0200, Roland Stigge wrote:
>> +config MTD_NAND_SLC_LPC32XX + bool "NXP LPC32xx SLC Controller"
>
> Why bool and not tristate here? Why you force this to be
> compiled-in and make it impossible to be a kernel module like other
> drivers are?
Right - the solution for both issues you mention (compiling as module
and linker error) is replacing above "bool" with "tristate".
Will post an updated patch.
Thanks,
Roland
next prev parent reply other threads:[~2012-06-06 9:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 19:25 [PATCH v5] MTD: LPC32xx SLC NAND driver Roland Stigge
2012-06-04 19:25 ` Roland Stigge
2012-06-04 19:25 ` [PATCH v4] MTD: LPC32xx MLC " Roland Stigge
2012-06-04 19:25 ` Roland Stigge
2012-06-04 19:25 ` Roland Stigge
2012-06-06 8:42 ` [PATCH v5] MTD: LPC32xx SLC " Artem Bityutskiy
2012-06-06 8:42 ` Artem Bityutskiy
2012-06-06 8:42 ` Artem Bityutskiy
2012-06-06 9:01 ` Roland Stigge [this message]
2012-06-06 9:01 ` Roland Stigge
2012-06-06 9:01 ` Roland Stigge
2012-06-06 8:48 ` Artem Bityutskiy
2012-06-06 8:48 ` Artem Bityutskiy
2012-06-06 8:48 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCF1C78.5000309@antcom.de \
--to=stigge@antcom.de \
--cc=b32955@freescale.com \
--cc=dedekind1@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwmw2@infradead.org \
--cc=hechtb@googlemail.com \
--cc=kevin.wells@nxp.com \
--cc=lars@metafoo.de \
--cc=leiwen@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=srinivas.bakki@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.