From: Alex Elder <elder@dreamhost.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Yehuda Sadeh <yehuda@hq.newdream.net>,
Sage Weil <sage@newdream.net>,
ceph-devel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] rbd: endian bug in rbd_req_cb()
Date: Wed, 06 Jun 2012 08:55:12 -0500 [thread overview]
Message-ID: <4FCF6140.10604@dreamhost.com> (raw)
In-Reply-To: <20120504173954.GA18827@elgon.mountain>
On 05/04/2012 12:39 PM, Dan Carpenter wrote:
> Sparse complains about this because:
> drivers/block/rbd.c:996:20: warning: cast to restricted __le32
> drivers/block/rbd.c:996:20: warning: cast from restricted __le16
>
> These are set in osd_req_encode_op() and they are le16.
I had made a note to myself to fix this as well--and have a whole
series of patches in my queue related to improving consistency with
sizes and signedness.
Thank you for sending this, it looks good and I'm about to commit it.
Reviewed-by: Alex Elder <elder@inktank.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index c1f7701..64d3d6f 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -993,7 +993,7 @@ static void rbd_req_cb(struct ceph_osd_request *req, struct ceph_msg *msg)
> op = (void *)(replyhead + 1);
> rc = le32_to_cpu(replyhead->result);
> bytes = le64_to_cpu(op->extent.length);
> - read_op = (le32_to_cpu(op->op) == CEPH_OSD_OP_READ);
> + read_op = (le16_to_cpu(op->op) == CEPH_OSD_OP_READ);
>
> dout("rbd_req_cb bytes=%lld readop=%d rc=%d\n", bytes, read_op, rc);
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Alex Elder <elder@dreamhost.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Yehuda Sadeh <yehuda@hq.newdream.net>,
Sage Weil <sage@newdream.net>,
ceph-devel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] rbd: endian bug in rbd_req_cb()
Date: Wed, 06 Jun 2012 13:55:12 +0000 [thread overview]
Message-ID: <4FCF6140.10604@dreamhost.com> (raw)
In-Reply-To: <20120504173954.GA18827@elgon.mountain>
On 05/04/2012 12:39 PM, Dan Carpenter wrote:
> Sparse complains about this because:
> drivers/block/rbd.c:996:20: warning: cast to restricted __le32
> drivers/block/rbd.c:996:20: warning: cast from restricted __le16
>
> These are set in osd_req_encode_op() and they are le16.
I had made a note to myself to fix this as well--and have a whole
series of patches in my queue related to improving consistency with
sizes and signedness.
Thank you for sending this, it looks good and I'm about to commit it.
Reviewed-by: Alex Elder <elder@inktank.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index c1f7701..64d3d6f 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -993,7 +993,7 @@ static void rbd_req_cb(struct ceph_osd_request *req, struct ceph_msg *msg)
> op = (void *)(replyhead + 1);
> rc = le32_to_cpu(replyhead->result);
> bytes = le64_to_cpu(op->extent.length);
> - read_op = (le32_to_cpu(op->op) = CEPH_OSD_OP_READ);
> + read_op = (le16_to_cpu(op->op) = CEPH_OSD_OP_READ);
>
> dout("rbd_req_cb bytes=%lld readop=%d rc=%d\n", bytes, read_op, rc);
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-06-06 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 17:39 [patch] rbd: endian bug in rbd_req_cb() Dan Carpenter
2012-05-04 17:39 ` Dan Carpenter
2012-06-06 13:55 ` Alex Elder [this message]
2012-06-06 13:55 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCF6140.10604@dreamhost.com \
--to=elder@dreamhost.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=elder@inktank.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=sage@newdream.net \
--cc=yehuda@hq.newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.