All of lore.kernel.org
 help / color / mirror / Atom feed
* [uml-devel] [PATCH] Fix readonly ubd
@ 2012-06-07  0:57 Martin Pärtel
  2012-06-07  8:11 ` richard -rw- weinberger
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Pärtel @ 2012-06-07  0:57 UTC (permalink / raw)
  To: user-mode-linux-devel

[-- Attachment #1: Type: text/plain, Size: 101 bytes --]

Hi,

ubd_file_size() was recently patched so that it fails if an image is 
readonly. Patch attached.

[-- Attachment #2: readonly-ubd-fix.patch --]
[-- Type: text/x-diff, Size: 325 bytes --]

--- a/arch/um/drivers/ubd_kern.c	2012-06-01 10:18:44.000000000 +0300
+++ b/arch/um/drivers/ubd_kern.c	2012-06-07 03:41:44.790899305 +0300
@@ -514,7 +514,7 @@
 		goto out;
 	}
 
-	fd = os_open_file(ubd_dev->file, global_openflags, 0);
+	fd = os_open_file(ubd_dev->file, of_read(OPENFLAGS()), 0);
 	if (fd < 0)
 		return fd;
 

[-- Attachment #3: Type: text/plain, Size: 395 bytes --]

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

[-- Attachment #4: Type: text/plain, Size: 194 bytes --]

_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [uml-devel] [PATCH] Fix readonly ubd
  2012-06-07  0:57 [uml-devel] [PATCH] Fix readonly ubd Martin Pärtel
@ 2012-06-07  8:11 ` richard -rw- weinberger
  0 siblings, 0 replies; 2+ messages in thread
From: richard -rw- weinberger @ 2012-06-07  8:11 UTC (permalink / raw)
  To: Martin Pärtel; +Cc: user-mode-linux-devel

On Thu, Jun 7, 2012 at 2:57 AM, Martin Pärtel <martin.partel@gmail.com> wrote:
> Hi,
>
> ubd_file_size() was recently patched so that it fails if an image is
> readonly. Patch attached.

Thanks for the patch.
Can you please follow Documentation/SubmittingPatches?

Your patch needs at least a description and a Signed-off-By.

-- 
Thanks,
//richard

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-07  8:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-07  0:57 [uml-devel] [PATCH] Fix readonly ubd Martin Pärtel
2012-06-07  8:11 ` richard -rw- weinberger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.