From: walter harms <wharms@bfs.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mattia Dongili <malattia@linux.it>,
Matthew Garrett <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] sony-laptop: fix a couple signedness bugs
Date: Thu, 07 Jun 2012 09:47:30 +0000 [thread overview]
Message-ID: <4FD078B2.3060909@bfs.de> (raw)
In-Reply-To: <20120607082221.GA7582@elgon.mountain>
Am 07.06.2012 10:22, schrieb Dan Carpenter:
> These need to be signed to handle negative error codes.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
> index 210d4ae..0a2f026 100644
> --- a/drivers/platform/x86/sony-laptop.c
> +++ b/drivers/platform/x86/sony-laptop.c
> @@ -2113,7 +2113,7 @@ static ssize_t sony_nc_thermal_mode_show(struct device *dev,
> struct device_attribute *attr, char *buffer)
> {
> ssize_t count = 0;
> - unsigned int mode = sony_nc_thermal_mode_get();
> + int mode = sony_nc_thermal_mode_get();
>
> if (mode < 0)
> return mode;
> @@ -2480,7 +2480,7 @@ static void sony_nc_backlight_ng_read_limits(int handle,
> props->maxlvl = 0xff;
>
> offset = sony_find_snc_handle(handle);
sony_find_snc_handle() should return an int, did something change ?
> - if (offset < 0)
> + if ((int)offset < 0)
> return;
>
> /* try to read the boundaries from ACPI tables, if we fail the above
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mattia Dongili <malattia@linux.it>,
Matthew Garrett <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] sony-laptop: fix a couple signedness bugs
Date: Thu, 07 Jun 2012 11:47:30 +0200 [thread overview]
Message-ID: <4FD078B2.3060909@bfs.de> (raw)
In-Reply-To: <20120607082221.GA7582@elgon.mountain>
Am 07.06.2012 10:22, schrieb Dan Carpenter:
> These need to be signed to handle negative error codes.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
> index 210d4ae..0a2f026 100644
> --- a/drivers/platform/x86/sony-laptop.c
> +++ b/drivers/platform/x86/sony-laptop.c
> @@ -2113,7 +2113,7 @@ static ssize_t sony_nc_thermal_mode_show(struct device *dev,
> struct device_attribute *attr, char *buffer)
> {
> ssize_t count = 0;
> - unsigned int mode = sony_nc_thermal_mode_get();
> + int mode = sony_nc_thermal_mode_get();
>
> if (mode < 0)
> return mode;
> @@ -2480,7 +2480,7 @@ static void sony_nc_backlight_ng_read_limits(int handle,
> props->maxlvl = 0xff;
>
> offset = sony_find_snc_handle(handle);
sony_find_snc_handle() should return an int, did something change ?
> - if (offset < 0)
> + if ((int)offset < 0)
> return;
>
> /* try to read the boundaries from ACPI tables, if we fail the above
next prev parent reply other threads:[~2012-06-07 9:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 8:22 [patch] sony-laptop: fix a couple signedness bugs Dan Carpenter
2012-06-07 8:22 ` Dan Carpenter
2012-06-07 9:47 ` walter harms [this message]
2012-06-07 9:47 ` walter harms
2012-06-07 9:59 ` Dan Carpenter
2012-06-07 9:59 ` Dan Carpenter
2012-06-07 10:17 ` walter harms
2012-06-07 10:17 ` walter harms
2012-06-07 21:42 ` Mattia Dongili
2012-06-07 21:42 ` Mattia Dongili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD078B2.3060909@bfs.de \
--to=wharms@bfs.de \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=malattia@linux.it \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.