All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nitin Gupta <ngupta@vflare.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Seth Jennings <sjenning@linux.vnet.ibm.com>,
	Jerome Marchand <jmarchan@redhat.com>
Subject: Re: [PATCH] zram: fix random data read
Date: Fri, 08 Jun 2012 00:23:30 -0700	[thread overview]
Message-ID: <4FD1A872.7070906@vflare.org> (raw)
In-Reply-To: <1339137567-29656-2-git-send-email-minchan@kernel.org>

On 06/07/2012 11:39 PM, Minchan Kim wrote:

> fd1a30de makes a bug that it uses (struct page *) as zsmalloc's handle
> although it's a uncompressed page so that it can access random page,
> return random data or even crashed by get_first_page in zs_map_object.
> 
> Cc: Nitin Gupta <ngupta@vflare.org>
> Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>
> Cc: Jerome Marchand <jmarchan@redhat.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
> ---
>  drivers/staging/zram/zram_drv.c |   15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 


Great catch! The problem goes away after your next patch for using
zsmalloc for all the cases, still this fix can never hurt.

Acked-by: Nitin Gupta <ngupta@vflare.org>


Thanks,
Nitin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Nitin Gupta <ngupta@vflare.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Seth Jennings <sjenning@linux.vnet.ibm.com>,
	Jerome Marchand <jmarchan@redhat.com>
Subject: Re: [PATCH] zram: fix random data read
Date: Fri, 08 Jun 2012 00:23:30 -0700	[thread overview]
Message-ID: <4FD1A872.7070906@vflare.org> (raw)
In-Reply-To: <1339137567-29656-2-git-send-email-minchan@kernel.org>

On 06/07/2012 11:39 PM, Minchan Kim wrote:

> fd1a30de makes a bug that it uses (struct page *) as zsmalloc's handle
> although it's a uncompressed page so that it can access random page,
> return random data or even crashed by get_first_page in zs_map_object.
> 
> Cc: Nitin Gupta <ngupta@vflare.org>
> Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>
> Cc: Jerome Marchand <jmarchan@redhat.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
> ---
>  drivers/staging/zram/zram_drv.c |   15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 


Great catch! The problem goes away after your next patch for using
zsmalloc for all the cases, still this fix can never hurt.

Acked-by: Nitin Gupta <ngupta@vflare.org>


Thanks,
Nitin

  reply	other threads:[~2012-06-08  7:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08  6:39 [PATCH v3] zsmalloc: zsmalloc: use unsigned long instead of void * Minchan Kim
2012-06-08  6:39 ` Minchan Kim
2012-06-08  6:39 ` [PATCH] zram: fix random data read Minchan Kim
2012-06-08  6:39   ` Minchan Kim
2012-06-08  7:23   ` Nitin Gupta [this message]
2012-06-08  7:23     ` Nitin Gupta
2012-06-08  6:39 ` [PATCH] zram: remove special handle of uncompressed page Minchan Kim
2012-06-08  6:39   ` Minchan Kim
2012-06-08  7:29   ` Nitin Gupta
2012-06-08  7:29     ` Nitin Gupta
2012-06-08  7:13 ` [PATCH v3] zsmalloc: zsmalloc: use unsigned long instead of void * Nitin Gupta
2012-06-08  7:13   ` Nitin Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD1A872.7070906@vflare.org \
    --to=ngupta@vflare.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jmarchan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.