From: Michael Hennerich <michael.hennerich@analog.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch -next] iio: frequency: ad9523: unlock on error in ad9523_reg_access()
Date: Fri, 08 Jun 2012 07:23:31 +0000 [thread overview]
Message-ID: <4FD1A873.4070406@analog.com> (raw)
In-Reply-To: <20120608065403.GB26673@elgon.mountain>
On 06/08/2012 08:54 AM, Dan Carpenter wrote:
> There was a return path which got missed accidentally.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
>
> diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
> index 7272924..832e6ab 100644
> --- a/drivers/iio/frequency/ad9523.c
> +++ b/drivers/iio/frequency/ad9523.c
> @@ -731,10 +731,12 @@ static int ad9523_reg_access(struct iio_dev *indio_dev,
> } else {
> ret = ad9523_read(indio_dev, reg | AD9523_R1B);
> if (ret< 0)
> - return ret;
> + goto out_unlock;
> *readval = ret;
> ret = 0;
> }
> +
> +out_unlock:
> mutex_unlock(&indio_dev->mlock);
>
> return ret;
>
--
Greetings,
Michael
--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif
WARNING: multiple messages have this Message-ID (diff)
From: Michael Hennerich <michael.hennerich@analog.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch -next] iio: frequency: ad9523: unlock on error in ad9523_reg_access()
Date: Fri, 8 Jun 2012 09:23:31 +0200 [thread overview]
Message-ID: <4FD1A873.4070406@analog.com> (raw)
In-Reply-To: <20120608065403.GB26673@elgon.mountain>
On 06/08/2012 08:54 AM, Dan Carpenter wrote:
> There was a return path which got missed accidentally.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
>
> diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
> index 7272924..832e6ab 100644
> --- a/drivers/iio/frequency/ad9523.c
> +++ b/drivers/iio/frequency/ad9523.c
> @@ -731,10 +731,12 @@ static int ad9523_reg_access(struct iio_dev *indio_dev,
> } else {
> ret = ad9523_read(indio_dev, reg | AD9523_R1B);
> if (ret< 0)
> - return ret;
> + goto out_unlock;
> *readval = ret;
> ret = 0;
> }
> +
> +out_unlock:
> mutex_unlock(&indio_dev->mlock);
>
> return ret;
>
--
Greetings,
Michael
--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif
next prev parent reply other threads:[~2012-06-08 7:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 6:54 [patch -next] iio: frequency: ad9523: unlock on error in ad9523_reg_access() Dan Carpenter
2012-06-08 6:54 ` Dan Carpenter
2012-06-08 7:23 ` Michael Hennerich [this message]
2012-06-08 7:23 ` Michael Hennerich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD1A873.4070406@analog.com \
--to=michael.hennerich@analog.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@cam.ac.uk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.