Re: [PATCH 2/9] iio:adc:at91: Use new triggered buffer setup helper

[Lars-Peter Clausen <lars@metafoo.de>]

On 06/07/2012 10:02 PM, Jonathan Cameron wrote:
> On 06/06/2012 12:55 PM, Lars-Peter Clausen wrote:
>> Use the new triggered buffer setup helper function to allocate and register
>> buffer and pollfunc.
>>
> Other than dropping IIO_TRIGGER select this is fine.
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Acked-by: Jonathan Cameron <jic23@kernel.org>
>> ---
>>  drivers/iio/adc/Kconfig    |    2 +-
>>  drivers/iio/adc/at91_adc.c |   49 +++-----------------------------------------
>>  2 files changed, 4 insertions(+), 47 deletions(-)
>>
>> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
>> index 9a0df81..bbd2291 100644
>> --- a/drivers/iio/adc/Kconfig
>> +++ b/drivers/iio/adc/Kconfig
>> @@ -7,7 +7,7 @@ config AT91_ADC
>>  	tristate "Atmel AT91 ADC"
>>  	depends on ARCH_AT91
>>  	select IIO_BUFFER
>> -	select IIO_KFIFO_BUF
>> +	select IIO_TRIGGERED_BUFFER
>>  	select IIO_TRIGGER
> given IIO_TRIGGERED_BUFFER selects IIO_TRIGGER, drop that as well.

The reasoning for keeping it was, that the driver registers it's own trigger
and as such has a direct dependency on the trigger code. Whereas the kfifo
dependency is now implicit. But I can remove the 'select IIO_TRIGGER' if you
prefer it.

Thanks,
- Lars