From: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
To: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Frederic Weisbecker
<fweisbeck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org,
kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org,
Pekka Enberg <penberg-bbCR+/B0CizivPeTLB3BmA@public.gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Suleiman Souhlal
<suleiman-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 2/4] Add a __GFP_SLABMEMCG flag
Date: Sat, 9 Jun 2012 12:19:44 +0400 [thread overview]
Message-ID: <4FD30720.6040908@parallels.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1206081430380.4213-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org>
On 06/08/2012 11:31 PM, Christoph Lameter wrote:
> Please make this conditional on CONFIG_MEMCG or so. The bit can be useful
> in particular on 32 bit architectures.
Looking at how __GFP_NOTRACK works - which is also ifdef'd, the bit it
uses is skipped if that is not defined, which I believe is a sane thing
to do.
Given that, I don't see the point of conditionally defining the memcg
bit, It basically means that the only way we can reuse the bit saved is
by making a future feature fundamentally incompatible with memcg.
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
Tejun Heo <tj@kernel.org>,
Frederic Weisbecker <fweisbeck@gmail.com>,
devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com,
Pekka Enberg <penberg@cs.helsinki.fi>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Suleiman Souhlal <suleiman@google.com>
Subject: Re: [PATCH 2/4] Add a __GFP_SLABMEMCG flag
Date: Sat, 9 Jun 2012 12:19:44 +0400 [thread overview]
Message-ID: <4FD30720.6040908@parallels.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1206081430380.4213@router.home>
On 06/08/2012 11:31 PM, Christoph Lameter wrote:
> Please make this conditional on CONFIG_MEMCG or so. The bit can be useful
> in particular on 32 bit architectures.
Looking at how __GFP_NOTRACK works - which is also ifdef'd, the bit it
uses is skipped if that is not defined, which I believe is a sane thing
to do.
Given that, I don't see the point of conditionally defining the memcg
bit, It basically means that the only way we can reuse the bit saved is
by making a future feature fundamentally incompatible with memcg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-09 8:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 9:43 [PATCH 0/4] kmem memcg proposed core changes Glauber Costa
[not found] ` <1339148601-20096-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-08 9:43 ` [PATCH 1/4] memcg: kmem controller dispatch infrastructure Glauber Costa
2012-06-08 9:43 ` Glauber Costa
2012-06-08 9:43 ` [PATCH 2/4] Add a __GFP_SLABMEMCG flag Glauber Costa
2012-06-08 9:43 ` Glauber Costa
[not found] ` <1339148601-20096-3-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-08 19:31 ` Christoph Lameter
2012-06-08 19:31 ` Christoph Lameter
[not found] ` <alpine.DEB.2.00.1206081430380.4213-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org>
2012-06-09 0:56 ` James Bottomley
2012-06-09 0:56 ` James Bottomley
[not found] ` <1339203416.6893.10.camel-sFMDBYUN5F8GjUHQrlYNx2Wm91YjaHnnhRte9Li2A+AAvxtiuMwx3w@public.gmane.org>
2012-06-09 8:24 ` Glauber Costa
2012-06-09 8:24 ` Glauber Costa
2012-06-11 14:24 ` Christoph Lameter
2012-06-11 14:24 ` Christoph Lameter
[not found] ` <alpine.DEB.2.00.1206110905220.31180-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org>
2012-06-12 14:36 ` James Bottomley
2012-06-12 14:36 ` James Bottomley
2012-06-09 8:19 ` Glauber Costa [this message]
2012-06-09 8:19 ` Glauber Costa
2012-06-08 9:43 ` [PATCH 3/4] don't do __ClearPageSlab before freeing slab page Glauber Costa
2012-06-08 9:43 ` Glauber Costa
2012-06-08 9:43 ` [PATCH 4/4] mm: Allocate kernel pages to the right memcg Glauber Costa
2012-06-08 9:43 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD30720.6040908@parallels.com \
--to=glommer-bzqdu9zft3wakbo8gow8eq@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \
--cc=devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
--cc=fweisbeck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=penberg-bbCR+/B0CizivPeTLB3BmA@public.gmane.org \
--cc=suleiman-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.