From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
AnilKumar Ch <anilkumar@ti.com>,
"David S. Miller" <davem@davemloft.net>,
Jiri Kosina <jkosina@suse.cz>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] can: c_can: precedence error in c_can_chip_config()
Date: Sun, 10 Jun 2012 17:52:50 +0000 [thread overview]
Message-ID: <4FD4DEF2.6070802@pengutronix.de> (raw)
In-Reply-To: <20120609155150.GA6488@elgon.mountain>
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
On 06/09/2012 05:56 PM, Dan Carpenter wrote:
> (CAN_CTRLMODE_LISTENONLY & CAN_CTRLMODE_LOOPBACK) is (0x02 & 0x01) which
> is zero so the condition is never true. The intent here was to test
> that both flags were set.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This is a static checker fix. I'm not super familiar with the c_can
> code.
Good catch. Applied to can-next.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
AnilKumar Ch <anilkumar@ti.com>,
"David S. Miller" <davem@davemloft.net>,
Jiri Kosina <jkosina@suse.cz>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] can: c_can: precedence error in c_can_chip_config()
Date: Sun, 10 Jun 2012 19:52:50 +0200 [thread overview]
Message-ID: <4FD4DEF2.6070802@pengutronix.de> (raw)
In-Reply-To: <20120609155150.GA6488@elgon.mountain>
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
On 06/09/2012 05:56 PM, Dan Carpenter wrote:
> (CAN_CTRLMODE_LISTENONLY & CAN_CTRLMODE_LOOPBACK) is (0x02 & 0x01) which
> is zero so the condition is never true. The intent here was to test
> that both flags were set.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This is a static checker fix. I'm not super familiar with the c_can
> code.
Good catch. Applied to can-next.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-06-10 17:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 15:56 [patch] can: c_can: precedence error in c_can_chip_config() Dan Carpenter
2012-06-09 15:56 ` Dan Carpenter
2012-06-10 17:52 ` Marc Kleine-Budde [this message]
2012-06-10 17:52 ` Marc Kleine-Budde
2012-06-11 17:42 ` Oliver Hartkopp
2012-06-11 17:42 ` Oliver Hartkopp
2012-06-11 17:51 ` Marc Kleine-Budde
2012-06-11 17:51 ` Marc Kleine-Budde
2012-06-12 9:37 ` Marc Kleine-Budde
2012-06-12 9:37 ` Marc Kleine-Budde
2012-06-12 11:01 ` Oliver Hartkopp
2012-06-12 11:01 ` Oliver Hartkopp
-- strict thread matches above, loose matches on Subject: below --
2012-06-15 10:20 pull-request: can: 2012-06-15 Marc Kleine-Budde
2012-06-15 10:20 ` [PATCH] can: c_can: precedence error in c_can_chip_config() Marc Kleine-Budde
2012-06-15 22:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD4DEF2.6070802@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=anilkumar@ti.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=jkosina@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.