* class exec test
@ 2012-06-11 5:03 Sage Weil
2012-06-11 6:50 ` Josh Durgin
0 siblings, 1 reply; 3+ messages in thread
From: Sage Weil @ 2012-06-11 5:03 UTC (permalink / raw)
To: josh.durgin; +Cc: ceph-devel
Hey-
The librados api tests were calling a dummy "test_exec" method in cls_rbd
that apparently got removed. We probably want to replace the test with
*something*, though... maybe a "version" or similar command that just
returns the version of the class? Or an OSD built-in dummy class with
no-op methods?
sage
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: class exec test
2012-06-11 5:03 class exec test Sage Weil
@ 2012-06-11 6:50 ` Josh Durgin
2012-06-11 16:54 ` Sage Weil
0 siblings, 1 reply; 3+ messages in thread
From: Josh Durgin @ 2012-06-11 6:50 UTC (permalink / raw)
To: Sage Weil; +Cc: ceph-devel
On 06/10/2012 10:03 PM, Sage Weil wrote:
> Hey-
>
> The librados api tests were calling a dummy "test_exec" method in cls_rbd
> that apparently got removed. We probably want to replace the test with
> *something*, though... maybe a "version" or similar command that just
> returns the version of the class? Or an OSD built-in dummy class with
> no-op methods?
I replaced this with a get_all_features method in the wip-rados-test
branch. With this, the rbd tool can report the features that can be used
to create a new image.
Josh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: class exec test
2012-06-11 6:50 ` Josh Durgin
@ 2012-06-11 16:54 ` Sage Weil
0 siblings, 0 replies; 3+ messages in thread
From: Sage Weil @ 2012-06-11 16:54 UTC (permalink / raw)
To: Josh Durgin; +Cc: Sage Weil, ceph-devel
On Sun, 10 Jun 2012, Josh Durgin wrote:
> On 06/10/2012 10:03 PM, Sage Weil wrote:
> > Hey-
> >
> > The librados api tests were calling a dummy "test_exec" method in cls_rbd
> > that apparently got removed. We probably want to replace the test with
> > *something*, though... maybe a "version" or similar command that just
> > returns the version of the class? Or an OSD built-in dummy class with
> > no-op methods?
>
> I replaced this with a get_all_features method in the wip-rados-test
> branch. With this, the rbd tool can report the features that can be used
> to create a new image.
Looks good, pushed to master.
s
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-11 16:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-11 5:03 class exec test Sage Weil
2012-06-11 6:50 ` Josh Durgin
2012-06-11 16:54 ` Sage Weil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.