From: "Andreas Färber" <andreas.faerber@web.de>
To: qemu-devel@nongnu.org
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-stable@nongnu.org, anthony@codemonkey.ws
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH for-1.1] libqtest: Fix socket_accept() to pass address_len
Date: Mon, 11 Jun 2012 14:22:31 +0200 [thread overview]
Message-ID: <4FD5E307.7030301@web.de> (raw)
In-Reply-To: <1338159200-7502-1-git-send-email-andreas.faerber@web.de>
Am 28.05.2012 00:53, schrieb Andreas Färber:
> accept() expects address_len to point to the length of the sockaddr on
> input. Initialize it accordingly.
>
> Resolves an assertion due to EFAULT on illumos.
>
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Ping? Verifiable by looking at the Linux man page.
/-F
> ---
> tests/libqtest.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/tests/libqtest.c b/tests/libqtest.c
> index 6d333ef..1d73fd1 100644
> --- a/tests/libqtest.c
> +++ b/tests/libqtest.c
> @@ -74,6 +74,7 @@ static int socket_accept(int sock)
> socklen_t addrlen;
> int ret;
>
> + addrlen = sizeof(addr);
> do {
> ret = accept(sock, (struct sockaddr *)&addr, &addrlen);
> } while (ret == -1 && errno == EINTR);
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <andreas.faerber@web.de>
To: qemu-devel@nongnu.org
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-stable@nongnu.org, anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [PATCH for-1.1] libqtest: Fix socket_accept() to pass address_len
Date: Mon, 11 Jun 2012 14:22:31 +0200 [thread overview]
Message-ID: <4FD5E307.7030301@web.de> (raw)
In-Reply-To: <1338159200-7502-1-git-send-email-andreas.faerber@web.de>
Am 28.05.2012 00:53, schrieb Andreas Färber:
> accept() expects address_len to point to the length of the sockaddr on
> input. Initialize it accordingly.
>
> Resolves an assertion due to EFAULT on illumos.
>
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Ping? Verifiable by looking at the Linux man page.
/-F
> ---
> tests/libqtest.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/tests/libqtest.c b/tests/libqtest.c
> index 6d333ef..1d73fd1 100644
> --- a/tests/libqtest.c
> +++ b/tests/libqtest.c
> @@ -74,6 +74,7 @@ static int socket_accept(int sock)
> socklen_t addrlen;
> int ret;
>
> + addrlen = sizeof(addr);
> do {
> ret = accept(sock, (struct sockaddr *)&addr, &addrlen);
> } while (ret == -1 && errno == EINTR);
next prev parent reply other threads:[~2012-06-11 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 22:53 [Qemu-devel] [PATCH for-1.1] libqtest: Fix socket_accept() to pass address_len Andreas Färber
2012-06-11 12:22 ` Andreas Färber [this message]
2012-06-11 12:22 ` Andreas Färber
2012-06-12 9:52 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD5E307.7030301@web.de \
--to=andreas.faerber@web.de \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.