All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jon-hunter@ti.com>
To: Afzal Mohammed <afzal@ti.com>
Cc: tony@atomide.com, paul@pwsan.com, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: OMAP2+: nand: unify init functions
Date: Mon, 11 Jun 2012 10:43:45 -0500	[thread overview]
Message-ID: <4FD61231.6020605@ti.com> (raw)
In-Reply-To: <95b5dece2f0b06ba1242f5af4c14fe1696950101.1339419244.git.afzal@ti.com>

Hi Afzal,

On 06/11/2012 09:01 AM, Afzal Mohammed wrote:
> Helper function for updating nand platform data has been
> added the capability to take timing structure arguement.
> Usage of omap_nand_flash_init() has been replaced by modifed
> one, omap_nand_flash_init was doing things similar to
> board_nand_init except that NAND CS# were being acquired
> based on bootloader setting. As CS# is hardwired for a given
> board, acquiring gpmc CS# has been removed, and updated with
> the value on board.
> 
> NAND CS# used in beagle board was found to be CS0.
> Thomas Weber <thomas.weber.linux@googlemail.com> reported
> that value of devkit8000 to be CS0. Overo board was found
> to be using CS0 based on u-boot, while google grep says
> omap3touchbook too has CS0.

[1] also confirms the omap3-touchbook uses CS0.

> Signed-off-by: Afzal Mohammed <afzal@ti.com>

Which boards have been tested with this change?

Otherwise, looks good.

Reviewed-by: Jon Hunter <jon-hunter@ti.com>

Cheers
Jon

[1] http://www.alwaysinnovating.com/wiki/index.php/Booting

WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: OMAP2+: nand: unify init functions
Date: Mon, 11 Jun 2012 10:43:45 -0500	[thread overview]
Message-ID: <4FD61231.6020605@ti.com> (raw)
In-Reply-To: <95b5dece2f0b06ba1242f5af4c14fe1696950101.1339419244.git.afzal@ti.com>

Hi Afzal,

On 06/11/2012 09:01 AM, Afzal Mohammed wrote:
> Helper function for updating nand platform data has been
> added the capability to take timing structure arguement.
> Usage of omap_nand_flash_init() has been replaced by modifed
> one, omap_nand_flash_init was doing things similar to
> board_nand_init except that NAND CS# were being acquired
> based on bootloader setting. As CS# is hardwired for a given
> board, acquiring gpmc CS# has been removed, and updated with
> the value on board.
> 
> NAND CS# used in beagle board was found to be CS0.
> Thomas Weber <thomas.weber.linux@googlemail.com> reported
> that value of devkit8000 to be CS0. Overo board was found
> to be using CS0 based on u-boot, while google grep says
> omap3touchbook too has CS0.

[1] also confirms the omap3-touchbook uses CS0.

> Signed-off-by: Afzal Mohammed <afzal@ti.com>

Which boards have been tested with this change?

Otherwise, looks good.

Reviewed-by: Jon Hunter <jon-hunter@ti.com>

Cheers
Jon

[1] http://www.alwaysinnovating.com/wiki/index.php/Booting

  reply	other threads:[~2012-06-11 15:43 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-11 14:01 [PATCH 0/3] Prepare for GPMC driver conversion Afzal Mohammed
2012-06-11 14:01 ` Afzal Mohammed
2012-06-11 14:01 ` [PATCH 1/3] ARM: OMAP2+: nand: unify init functions Afzal Mohammed
2012-06-11 14:01   ` Afzal Mohammed
2012-06-11 15:43   ` Jon Hunter [this message]
2012-06-11 15:43     ` Jon Hunter
2012-06-12  5:50     ` Mohammed, Afzal
2012-06-12  5:50       ` Mohammed, Afzal
2012-06-11 14:01 ` [PATCH 2/3] ARM: OMAP2+: onenand: cleanup for gpmc driver conversion Afzal Mohammed
2012-06-11 14:01   ` Afzal Mohammed
2012-06-11 18:36   ` Jon Hunter
2012-06-11 18:36     ` Jon Hunter
2012-06-12  6:16     ` Mohammed, Afzal
2012-06-12  6:16       ` Mohammed, Afzal
2012-06-12 17:30       ` Jon Hunter
2012-06-12 17:30         ` Jon Hunter
2012-06-13  5:03         ` Mohammed, Afzal
2012-06-13  5:03           ` Mohammed, Afzal
2012-06-13 16:38           ` Jon Hunter
2012-06-13 16:38             ` Jon Hunter
2012-06-14  5:40             ` Mohammed, Afzal
2012-06-14  5:40               ` Mohammed, Afzal
2012-06-14 17:53               ` Jon Hunter
2012-06-14 17:53                 ` Jon Hunter
2012-06-15  6:52                 ` Mohammed, Afzal
2012-06-15  6:52                   ` Mohammed, Afzal
2012-06-11 14:02 ` [PATCH 3/3] ARM: OMAP2+: gpmc: handle additional timings Afzal Mohammed
2012-06-11 14:02   ` Afzal Mohammed
2012-06-11 18:49   ` Jon Hunter
2012-06-11 18:49     ` Jon Hunter
2012-06-12  6:37     ` Mohammed, Afzal
2012-06-12  6:37       ` Mohammed, Afzal
2012-06-12 17:36       ` Jon Hunter
2012-06-12 17:36         ` Jon Hunter
2012-06-13  4:56         ` Mohammed, Afzal
2012-06-13  4:56           ` Mohammed, Afzal
2012-06-13 11:32           ` Tony Lindgren
2012-06-13 11:32             ` Tony Lindgren
2012-06-13 11:54             ` Tony Lindgren
2012-06-13 11:54               ` Tony Lindgren
2012-06-13 11:58               ` Mohammed, Afzal
2012-06-13 11:58                 ` Mohammed, Afzal
2012-06-14 10:10                 ` Mohammed, Afzal
2012-06-14 10:10                   ` Mohammed, Afzal
2012-06-14 10:19                   ` Tony Lindgren
2012-06-14 10:19                     ` Tony Lindgren
2012-06-14 10:39                     ` Mohammed, Afzal
2012-06-14 10:39                       ` Mohammed, Afzal
2012-06-14 11:49                       ` Tony Lindgren
2012-06-14 11:49                         ` Tony Lindgren
2012-06-14 11:59                         ` Mohammed, Afzal
2012-06-14 11:59                           ` Mohammed, Afzal
2012-06-14 12:09                         ` Mohammed, Afzal
2012-06-14 12:09                           ` Mohammed, Afzal
2012-06-14 12:21                           ` Mohammed, Afzal
2012-06-14 12:21                             ` Mohammed, Afzal
2012-06-14 12:30                             ` Tony Lindgren
2012-06-14 12:30                               ` Tony Lindgren
2012-06-14 11:52                       ` Tony Lindgren
2012-06-14 11:52                         ` Tony Lindgren
2012-06-14 11:56                         ` Mohammed, Afzal
2012-06-14 11:56                           ` Mohammed, Afzal
2012-06-14 12:29                           ` Tony Lindgren
2012-06-14 12:29                             ` Tony Lindgren
2012-06-14 12:53                             ` Mohammed, Afzal
2012-06-14 12:53                               ` Mohammed, Afzal
2012-06-14 16:53                               ` Tony Lindgren
2012-06-14 16:53                                 ` Tony Lindgren
2012-06-15  5:42                                 ` Mohammed, Afzal
2012-06-15  5:42                                   ` Mohammed, Afzal
2012-06-15  6:16                                   ` Mohammed, Afzal
2012-06-15  6:16                                     ` Mohammed, Afzal
2012-06-15 10:45                                     ` Tony Lindgren
2012-06-15 10:45                                       ` Tony Lindgren
2012-06-15 10:49                                       ` Mohammed, Afzal
2012-06-15 10:49                                         ` Mohammed, Afzal
2012-06-13 12:34             ` Mohammed, Afzal
2012-06-13 12:34               ` Mohammed, Afzal
2012-06-13 12:42               ` Tony Lindgren
2012-06-13 12:42                 ` Tony Lindgren
2012-06-13 14:04                 ` Mohammed, Afzal
2012-06-13 14:04                   ` Mohammed, Afzal
2012-06-14  6:32                   ` Tony Lindgren
2012-06-14  6:32                     ` Tony Lindgren
2012-06-14  9:29   ` Tony Lindgren
2012-06-14  9:29     ` Tony Lindgren
2012-06-14  9:41     ` Mohammed, Afzal
2012-06-14  9:41       ` Mohammed, Afzal
2012-06-14 11:23       ` Tony Lindgren
2012-06-14 11:23         ` Tony Lindgren
2012-06-12 10:27 ` [PATCH 0/3] Prepare for GPMC driver conversion Mohammed, Afzal
2012-06-12 10:27   ` Mohammed, Afzal
2012-06-13 11:33   ` Tony Lindgren
2012-06-13 11:33     ` Tony Lindgren
2012-06-13 12:40     ` Mohammed, Afzal
2012-06-13 12:40       ` Mohammed, Afzal
2012-06-13 16:46       ` Jon Hunter
2012-06-13 16:46         ` Jon Hunter
2012-06-14  5:58         ` Mohammed, Afzal
2012-06-14  5:58           ` Mohammed, Afzal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD61231.6020605@ti.com \
    --to=jon-hunter@ti.com \
    --cc=afzal@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.