From: Karol Lewandowski <k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Kyungmin Park
<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] i2c-s3c2410: Fix pointer type passed to of_match_node()
Date: Tue, 12 Jun 2012 12:38:16 +0200 [thread overview]
Message-ID: <4FD71C18.9090209@samsung.com> (raw)
In-Reply-To: <20120611182925.GJ3887-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On 11.06.2012 20:29, Wolfram Sang wrote:
> On Wed, May 30, 2012 at 11:43:05AM +0200, Karol Lewandowski wrote:
>> This commit fixes warning introduced in 27452498a ("i2c-s3c2410: Rework
>> device type handling"):
>>
>> drivers/i2c/busses/i2c-s3c2410.c: In function 's3c24xx_get_device_quirks':
>> drivers/i2c/busses/i2c-s3c2410.c:125: warning: passing argument 1 of 'of_match_node' from incompatible pointer type
>> include/linux/of.h:245: note: expected 'const struct of_device_id *' but argument is of type 'const struct of_device_id (*)[4]'
>>
>> Signed-off-by: Karol Lewandowski <k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> Signed-off-by: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>
> Ah, now I understand why my build-test didn't spot the warning.
> What config can I use to test CONFIG_OF with s3c?
Currently no config for samsung hardware has OF enabled by default.
However, you could use exynos4_defconfig plus following (that's what
I use):
--- a/arch/arm/configs/exynos4_defconfig
+++ b/arch/arm/configs/exynos4_defconfig
@@ -14,6 +14,7 @@ CONFIG_MACH_ORIGEN=y
CONFIG_MACH_SMDK4412=y
CONFIG_NO_HZ=y
CONFIG_HIGH_RES_TIMERS=y
+CONFIG_MACH_EXYNOS4_DT=y
CONFIG_SMP=y
CONFIG_NR_CPUS=2
CONFIG_PREEMPT=y
@@ -37,6 +38,7 @@ CONFIG_SERIAL_SAMSUNG=y
CONFIG_SERIAL_SAMSUNG_CONSOLE=y
CONFIG_HW_RANDOM=y
CONFIG_I2C=y
+CONFIG_I2C_S3C2410=y
# CONFIG_HWMON is not set
# CONFIG_MFD_SUPPORT is not set
# CONFIG_HID_SUPPORT is not set
Regards,
--
Karol Lewandowski | Samsung Poland R&D Center | Linux/Platform
WARNING: multiple messages have this Message-ID (diff)
From: Karol Lewandowski <k.lewandowsk@samsung.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: m.szyprowski@samsung.com, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] i2c-s3c2410: Fix pointer type passed to of_match_node()
Date: Tue, 12 Jun 2012 12:38:16 +0200 [thread overview]
Message-ID: <4FD71C18.9090209@samsung.com> (raw)
In-Reply-To: <20120611182925.GJ3887@pengutronix.de>
On 11.06.2012 20:29, Wolfram Sang wrote:
> On Wed, May 30, 2012 at 11:43:05AM +0200, Karol Lewandowski wrote:
>> This commit fixes warning introduced in 27452498a ("i2c-s3c2410: Rework
>> device type handling"):
>>
>> drivers/i2c/busses/i2c-s3c2410.c: In function 's3c24xx_get_device_quirks':
>> drivers/i2c/busses/i2c-s3c2410.c:125: warning: passing argument 1 of 'of_match_node' from incompatible pointer type
>> include/linux/of.h:245: note: expected 'const struct of_device_id *' but argument is of type 'const struct of_device_id (*)[4]'
>>
>> Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> Ah, now I understand why my build-test didn't spot the warning.
> What config can I use to test CONFIG_OF with s3c?
Currently no config for samsung hardware has OF enabled by default.
However, you could use exynos4_defconfig plus following (that's what
I use):
--- a/arch/arm/configs/exynos4_defconfig
+++ b/arch/arm/configs/exynos4_defconfig
@@ -14,6 +14,7 @@ CONFIG_MACH_ORIGEN=y
CONFIG_MACH_SMDK4412=y
CONFIG_NO_HZ=y
CONFIG_HIGH_RES_TIMERS=y
+CONFIG_MACH_EXYNOS4_DT=y
CONFIG_SMP=y
CONFIG_NR_CPUS=2
CONFIG_PREEMPT=y
@@ -37,6 +38,7 @@ CONFIG_SERIAL_SAMSUNG=y
CONFIG_SERIAL_SAMSUNG_CONSOLE=y
CONFIG_HW_RANDOM=y
CONFIG_I2C=y
+CONFIG_I2C_S3C2410=y
# CONFIG_HWMON is not set
# CONFIG_MFD_SUPPORT is not set
# CONFIG_HID_SUPPORT is not set
Regards,
--
Karol Lewandowski | Samsung Poland R&D Center | Linux/Platform
next prev parent reply other threads:[~2012-06-12 10:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 9:43 [PATCH] i2c-s3c2410: Fix pointer type passed to of_match_node() Karol Lewandowski
2012-05-30 9:43 ` Karol Lewandowski
[not found] ` <1338370985-6950-1-git-send-email-k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-06-11 18:29 ` Wolfram Sang
2012-06-11 18:29 ` Wolfram Sang
[not found] ` <20120611182925.GJ3887-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-06-12 10:38 ` Karol Lewandowski [this message]
2012-06-12 10:38 ` Karol Lewandowski
2012-07-13 8:32 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD71C18.9090209@samsung.com \
--to=k.lewandowsk-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
--cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.