From: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
To: Kent Yoder <shpedoikal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "Zhang,
Xiaoyan" <xiaoyan.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
"debora-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org"
<debora-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
"srajiv-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org"
<srajiv-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
"m.selhorst-iBygD9l97zzQT0dZR+AlfA@public.gmane.org"
<m.selhorst-iBygD9l97zzQT0dZR+AlfA@public.gmane.org>,
"linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"james.l.morris-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org"
<james.l.morris-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
"linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Cihula,
Joseph" <joseph.cihula-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Wei, Gang" <gang.wei-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 1/2] driver: add PPI support in tpm driver
Date: Tue, 12 Jun 2012 12:00:38 -0700 [thread overview]
Message-ID: <4FD791D6.5050503@zytor.com> (raw)
In-Reply-To: <CAM0nabHV6CepQyXeVZiv2XT9WHPgMy=prdK-8fNgyrCZ4v6dSg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 06/12/2012 11:57 AM, Kent Yoder wrote:
>
> This code looks clean - my only suggestion would be to add an #ifdef
> CONFIG_ACPI around it so it compiles out on ppc.
>
Better yet, any way to separate it out in a separate source file?
-hpa
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Kent Yoder <shpedoikal@gmail.com>
Cc: "Zhang, Xiaoyan" <xiaoyan.zhang@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
"debora@linux.vnet.ibm.com" <debora@linux.vnet.ibm.com>,
"srajiv@linux.vnet.ibm.com" <srajiv@linux.vnet.ibm.com>,
"m.selhorst@sirrix.com" <m.selhorst@sirrix.com>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"james.l.morris@oracle.com" <james.l.morris@oracle.com>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"Cihula, Joseph" <joseph.cihula@intel.com>,
"Wei, Gang" <gang.wei@intel.com>
Subject: Re: [PATCH 1/2] driver: add PPI support in tpm driver
Date: Tue, 12 Jun 2012 12:00:38 -0700 [thread overview]
Message-ID: <4FD791D6.5050503@zytor.com> (raw)
In-Reply-To: <CAM0nabHV6CepQyXeVZiv2XT9WHPgMy=prdK-8fNgyrCZ4v6dSg@mail.gmail.com>
On 06/12/2012 11:57 AM, Kent Yoder wrote:
>
> This code looks clean - my only suggestion would be to add an #ifdef
> CONFIG_ACPI around it so it compiles out on ppc.
>
Better yet, any way to separate it out in a separate source file?
-hpa
next prev parent reply other threads:[~2012-06-12 19:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 3:34 [PATCH 1/2] driver: add PPI support in tpm driver Zhang, Xiaoyan
2012-05-23 3:34 ` Zhang, Xiaoyan
2012-06-12 18:57 ` Kent Yoder
[not found] ` <CAM0nabHV6CepQyXeVZiv2XT9WHPgMy=prdK-8fNgyrCZ4v6dSg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-12 19:00 ` H. Peter Anvin [this message]
2012-06-12 19:00 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD791D6.5050503@zytor.com \
--to=hpa-ymnouzjc4hwavxtiumwx3w@public.gmane.org \
--cc=debora-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=gang.wei-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=james.l.morris-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=joseph.cihula-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m.selhorst-iBygD9l97zzQT0dZR+AlfA@public.gmane.org \
--cc=shpedoikal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=srajiv-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=xiaoyan.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.