[U-Boot] [PATCH] omap4: Use a smaller M,N couple for IVA DPLL

[U-Boot] [PATCH] omap4: Use a smaller M,N couple for IVA DPLL

[Sebastien Jan]

Signed-off-by: Sebastien Jan <s-jan@ti.com>
---
 arch/arm/cpu/armv7/omap4/clocks.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/cpu/armv7/omap4/clocks.c b/arch/arm/cpu/armv7/omap4/clocks.c
index c568951..1d92e66 100644
--- a/arch/arm/cpu/armv7/omap4/clocks.c
+++ b/arch/arm/cpu/armv7/omap4/clocks.c
@@ -146,7 +146,7 @@ static const struct dpll_params iva_dpll_params_1862mhz[NUM_SYS_CLKS] = {
 	{727, 14, -1, -1, 4, 7, -1, -1},	/* 19.2 MHz */
 	{931, 25, -1, -1, 4, 7, -1, -1},	/* 26 MHz   */
 	{931, 26, -1, -1, 4, 7, -1, -1},	/* 27 MHz   */
-	{412, 16, -1, -1, 4, 7, -1, -1}		/* 38.4 MHz */
+	{291, 11, -1, -1, 4, 7, -1, -1}		/* 38.4 MHz */
 };
 
 /* ABE M & N values with sys_clk as source */
-- 
1.7.9.5

[U-Boot] [PATCH] omap4: Use a smaller M,N couple for IVA DPLL

[Tom Rini]

On Tue, Jun 12, 2012 at 12:34 AM, Sebastien Jan <s-jan@ti.com> wrote:
> Signed-off-by: Sebastien Jan <s-jan@ti.com>

Please explain what / why you are changing things here (based on docs,
testing, ?).  Thanks!

-- 
Tom

[U-Boot] [PATCH] omap4: Use a smaller M,N couple for IVA DPLL

[Jan, Sebastien]

Hi Tom,

On Tue, Jun 12, 2012 at 7:41 PM, Tom Rini <trini@ti.com> wrote:

> On Tue, Jun 12, 2012 at 12:34 AM, Sebastien Jan <s-jan@ti.com> wrote:
> > Signed-off-by: Sebastien Jan <s-jan@ti.com>
>
> Please explain what / why you are changing things here (based on docs,
> testing, ?).  Thanks!
>

Sure, sorry for missing that. The reduced M,N couple in this patch
corresponds to the advised value from our HW team. It tested with it, and
it also provides peripheral clocks closer to the advised values.

Regards,
Seb

[U-Boot] [PATCH] omap4: Use a smaller M,N couple for IVA DPLL

[Tom Rini]

On 06/13/2012 12:30 AM, Jan, Sebastien wrote:
> Hi Tom,
> 
> On Tue, Jun 12, 2012 at 7:41 PM, Tom Rini <trini@ti.com
> <mailto:trini@ti.com>> wrote:
> 
>     On Tue, Jun 12, 2012 at 12:34 AM, Sebastien Jan <s-jan@ti.com
>     <mailto:s-jan@ti.com>> wrote:
>     > Signed-off-by: Sebastien Jan <s-jan at ti.com <mailto:s-jan@ti.com>>
> 
>     Please explain what / why you are changing things here (based on docs,
>     testing, ?).  Thanks!
> 
> 
> Sure, sorry for missing that. The reduced M,N couple in this patch
> corresponds to the advised value from our HW team. It tested with it,
> and it also provides peripheral clocks closer to the advised values.

Thanks.  Can you please submit a v2 with that explanation in the commit
message?

-- 
Tom

[U-Boot] [PATCH] omap4: Use a smaller M,N couple for IVA DPLL

[Jan, Sebastien]

On Wed, Jun 13, 2012 at 5:03 PM, Tom Rini <trini@ti.com> wrote:

> On 06/13/2012 12:30 AM, Jan, Sebastien wrote:
> > Hi Tom,
> >
> > On Tue, Jun 12, 2012 at 7:41 PM, Tom Rini <trini@ti.com
> > <mailto:trini@ti.com>> wrote:
> >
> >     On Tue, Jun 12, 2012 at 12:34 AM, Sebastien Jan <s-jan@ti.com
> >     <mailto:s-jan@ti.com>> wrote:
> >     > Signed-off-by: Sebastien Jan <s-jan at ti.com <mailto:s-jan@ti.com>>
> >
> >     Please explain what / why you are changing things here (based on
> docs,
> >     testing, ?).  Thanks!
> >
> >
> > Sure, sorry for missing that. The reduced M,N couple in this patch
> > corresponds to the advised value from our HW team. It tested with it,
> > and it also provides peripheral clocks closer to the advised values.
>
> Thanks.  Can you please submit a v2 with that explanation in the commit
> message?
>

Yes, will do