* [U-Boot] mx53loco build fails with CONFIG_VIDEO disabled
@ 2012-06-13 17:00 Vikram Narayanan
2012-06-13 17:12 ` Fabio Estevam
2012-06-13 17:20 ` Stefano Babic
0 siblings, 2 replies; 6+ messages in thread
From: Vikram Narayanan @ 2012-06-13 17:00 UTC (permalink / raw)
To: u-boot
Hello,
mx53loco build fails when CONFIG_VIDEO and its friends disabled.
I can send a patch fixing this.
I _really_ don't like ifdef -ing a lot of stuff. Instead I'd feel to
have a separate file in the directory which does this LCD init and FB
init call, and let the makefile handle the conditional compilation.
@Fabio:
As you've pushed this stuff, I'd like to have your opinions on splitting
this into a separate file.
Regards,
Vikram
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] mx53loco build fails with CONFIG_VIDEO disabled
2012-06-13 17:00 [U-Boot] mx53loco build fails with CONFIG_VIDEO disabled Vikram Narayanan
@ 2012-06-13 17:12 ` Fabio Estevam
2012-06-13 17:20 ` Stefano Babic
1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2012-06-13 17:12 UTC (permalink / raw)
To: u-boot
On Wed, Jun 13, 2012 at 2:00 PM, Vikram Narayanan <vikram186@gmail.com> wrote:
> Hello,
>
> mx53loco build fails when CONFIG_VIDEO and its friends disabled.
> I can send a patch fixing this.
>
> I _really_ don't like ifdef -ing a lot of stuff. Instead I'd feel to have a
> separate file in the directory which does this LCD init and FB init call,
> and let the makefile handle the conditional compilation.
>
> @Fabio:
> As you've pushed this stuff, I'd like to have your opinions on splitting
> this into a separate file.
I don't have a strong opinion on this: either ifdef or a new file is
fine with me.
Thanks,
Fabio Estevam
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] mx53loco build fails with CONFIG_VIDEO disabled
2012-06-13 17:00 [U-Boot] mx53loco build fails with CONFIG_VIDEO disabled Vikram Narayanan
2012-06-13 17:12 ` Fabio Estevam
@ 2012-06-13 17:20 ` Stefano Babic
2012-06-13 17:53 ` Vikram Narayanan
2012-06-13 17:56 ` Fabio Estevam
1 sibling, 2 replies; 6+ messages in thread
From: Stefano Babic @ 2012-06-13 17:20 UTC (permalink / raw)
To: u-boot
On 13/06/2012 19:00, Vikram Narayanan wrote:
> Hello,
>
> mx53loco build fails when CONFIG_VIDEO and its friends disabled.
> I can send a patch fixing this.
>
But CONFIG_VIDEO is *not* set in mx53loco.h mainline. Do you mean you
are testing Fabio's patches ?
Fabio, can you give me an overview about your IPU patches ? I have seen
several patches during my vacation, but it is not clear to me the
status. In patchwork, most of them (but not all) are assigned to
Anatolji. Can you help me to sync myself with the current status ?
> I _really_ don't like ifdef -ing a lot of stuff.
Nobody likes it ;-)
> Instead I'd feel to
> have a separate file in the directory which does this LCD init and FB
> init call, and let the makefile handle the conditional compilation.
A way we use in the past to have different compilation of the same board
with different features is to use a separate entry into boards.cfg, for
example see imx31_phycore, or also magnesium and imx27lite, or...
Anyway, when patches for IPU flow into mainline, is there a good reason
to not enable CONFIG_VIDEO for mx53loco ?
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] mx53loco build fails with CONFIG_VIDEO disabled
2012-06-13 17:20 ` Stefano Babic
@ 2012-06-13 17:53 ` Vikram Narayanan
2012-06-13 17:59 ` Fabio Estevam
2012-06-13 17:56 ` Fabio Estevam
1 sibling, 1 reply; 6+ messages in thread
From: Vikram Narayanan @ 2012-06-13 17:53 UTC (permalink / raw)
To: u-boot
On 6/13/2012 10:50 PM, Stefano Babic wrote:
> On 13/06/2012 19:00, Vikram Narayanan wrote:
>> Hello,
>>
>> mx53loco build fails when CONFIG_VIDEO and its friends disabled.
>> I can send a patch fixing this.
>>
>
> But CONFIG_VIDEO is *not* set in mx53loco.h mainline. Do you mean you
> are testing Fabio's patches ?
With this (fedab338f3459315cb69627fcf46032ec8df1753) it is already in
the master.
> Fabio, can you give me an overview about your IPU patches ? I have seen
> several patches during my vacation, but it is not clear to me the
> status. In patchwork, most of them (but not all) are assigned to
> Anatolji. Can you help me to sync myself with the current status ?
>
>> I _really_ don't like ifdef -ing a lot of stuff.
>
> Nobody likes it ;-)
>
>> Instead I'd feel to
>> have a separate file in the directory which does this LCD init and FB
>> init call, and let the makefile handle the conditional compilation.
>
> A way we use in the past to have different compilation of the same board
> with different features is to use a separate entry into boards.cfg, for
> example see imx31_phycore, or also magnesium and imx27lite, or...
>
> Anyway, when patches for IPU flow into mainline, is there a good reason
> to not enable CONFIG_VIDEO for mx53loco ?
Though this would be helpful for headless boards, I'm not the right guy.
Fabio can give a better picture here.
Regards,
Vikram
> Best regards,
> Stefano
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] mx53loco build fails with CONFIG_VIDEO disabled
2012-06-13 17:20 ` Stefano Babic
2012-06-13 17:53 ` Vikram Narayanan
@ 2012-06-13 17:56 ` Fabio Estevam
1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2012-06-13 17:56 UTC (permalink / raw)
To: u-boot
On Wed, Jun 13, 2012 at 2:20 PM, Stefano Babic <sbabic@denx.de> wrote:
> On 13/06/2012 19:00, Vikram Narayanan wrote:
>> Hello,
>>
>> mx53loco build fails when CONFIG_VIDEO and its friends disabled.
>> I can send a patch fixing this.
>>
>
> But CONFIG_VIDEO is *not* set in mx53loco.h mainline. Do you mean you
> are testing Fabio's patches ?
>
> Fabio, can you give me an overview about your IPU patches ? I have seen
> several patches during my vacation, but it is not clear to me the
> status. In patchwork, most of them (but not all) are assigned to
> Anatolji. Can you help me to sync myself with the current status ?
Sure, mx51evk and mx53loco patches were already accepted by Anatolij
and are in mainline.
I have also submitted a patch series for adding framebuffer for
mx6qsabrelite. These were not applied yet and I need to rework at
least the last one of the series.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] mx53loco build fails with CONFIG_VIDEO disabled
2012-06-13 17:53 ` Vikram Narayanan
@ 2012-06-13 17:59 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2012-06-13 17:59 UTC (permalink / raw)
To: u-boot
On Wed, Jun 13, 2012 at 2:53 PM, Vikram Narayanan <vikram186@gmail.com> wrote:
>> Anyway, when patches for IPU flow into mainline, is there a good reason
>> to not enable CONFIG_VIDEO for mx53loco ?
>
>
> Though this would be helpful for headless boards, I'm not the right guy.
> Fabio can give a better picture here.
I like the idea of keeping CONFIG_VIDEO enabled by default for
mx53loco as it is currently.
Other boards like vision2, mx51evk do the same thing.
It is also a good idea to be able to deselect CONFIG_VIDEO and not
break the build and Vikram intends to submit a patch for fixing this.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-06-13 17:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-13 17:00 [U-Boot] mx53loco build fails with CONFIG_VIDEO disabled Vikram Narayanan
2012-06-13 17:12 ` Fabio Estevam
2012-06-13 17:20 ` Stefano Babic
2012-06-13 17:53 ` Vikram Narayanan
2012-06-13 17:59 ` Fabio Estevam
2012-06-13 17:56 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.