From: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrea Arcangeli <aarcange@redhat.com>,
Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@suse.cz>,
Wanpeng Li <liwp.linux@gmail.com>
Subject: Re: [PATCH v2 1/2][BUGFIX] mm: do not use page_count without a page pin
Date: Thu, 14 Jun 2012 11:20:30 +0900 [thread overview]
Message-ID: <4FD94A6E.3050906@jp.fujitsu.com> (raw)
In-Reply-To: <1339636334-9238-1-git-send-email-minchan@kernel.org>
(2012/06/14 10:12), Minchan Kim wrote:
> d179e84ba fixed the problem[1] in vmscan.c but same problem is here.
> Let's fix it.
>
> [1] http://comments.gmane.org/gmane.linux.kernel.mm/65844
>
> I copy and paste d179e84ba's contents for description.
>
> "It is unsafe to run page_count during the physical pfn scan because
> compound_head could trip on a dangling pointer when reading
> page->first_page if the compound page is being freed by another CPU."
>
> * changelog from v1
> - Add comment about skip tail page of THP - Andrea
> - fix typo - Wanpeng Li
> - based on next-20120613
>
> Cc: Andrea Arcangeli<aarcange@redhat.com>
> Cc: Mel Gorman<mgorman@suse.de>
> Cc: Michal Hocko<mhocko@suse.cz>
> Cc: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Wanpeng Li<liwp.linux@gmail.com>
> Signed-off-by: Minchan Kim<minchan@kernel.org>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrea Arcangeli <aarcange@redhat.com>,
Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@suse.cz>,
Wanpeng Li <liwp.linux@gmail.com>
Subject: Re: [PATCH v2 1/2][BUGFIX] mm: do not use page_count without a page pin
Date: Thu, 14 Jun 2012 11:20:30 +0900 [thread overview]
Message-ID: <4FD94A6E.3050906@jp.fujitsu.com> (raw)
In-Reply-To: <1339636334-9238-1-git-send-email-minchan@kernel.org>
(2012/06/14 10:12), Minchan Kim wrote:
> d179e84ba fixed the problem[1] in vmscan.c but same problem is here.
> Let's fix it.
>
> [1] http://comments.gmane.org/gmane.linux.kernel.mm/65844
>
> I copy and paste d179e84ba's contents for description.
>
> "It is unsafe to run page_count during the physical pfn scan because
> compound_head could trip on a dangling pointer when reading
> page->first_page if the compound page is being freed by another CPU."
>
> * changelog from v1
> - Add comment about skip tail page of THP - Andrea
> - fix typo - Wanpeng Li
> - based on next-20120613
>
> Cc: Andrea Arcangeli<aarcange@redhat.com>
> Cc: Mel Gorman<mgorman@suse.de>
> Cc: Michal Hocko<mhocko@suse.cz>
> Cc: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Wanpeng Li<liwp.linux@gmail.com>
> Signed-off-by: Minchan Kim<minchan@kernel.org>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
next prev parent reply other threads:[~2012-06-14 2:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 1:12 [PATCH v2 1/2][BUGFIX] mm: do not use page_count without a page pin Minchan Kim
2012-06-14 1:12 ` Minchan Kim
2012-06-14 1:12 ` [PATCH v2 2/2] mm: clean up __count_immobile_pages Minchan Kim
2012-06-14 1:12 ` Minchan Kim
2012-06-14 1:15 ` Minchan Kim
2012-06-14 1:15 ` Minchan Kim
2012-06-14 1:14 ` [PATCH v2 1/2][BUGFIX] mm: do not use page_count without a page pin Minchan Kim
2012-06-14 1:14 ` Minchan Kim
2012-06-14 2:20 ` Kamezawa Hiroyuki [this message]
2012-06-14 2:20 ` Kamezawa Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD94A6E.3050906@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwp.linux@gmail.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.