[PATCH] drm/radeon: fix regression in dynpm due to multi-ring rework

[PATCH] drm/radeon: fix regression in dynpm due to multi-ring rework

[alexdeucher]

From: Alex Deucher <alexander.deucher@amd.com>

Not all asics have all rings, so make sure the ring is ready
before attempting to check it in the dynpm work handler.

Fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=43367

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/radeon/radeon_pm.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
index 79642cd..7ae6066 100644
--- a/drivers/gpu/drm/radeon/radeon_pm.c
+++ b/drivers/gpu/drm/radeon/radeon_pm.c
@@ -793,9 +793,13 @@ static void radeon_dynpm_idle_work_handler(struct work_struct *work)
 		int i;
 
 		for (i = 0; i < RADEON_NUM_RINGS; ++i) {
-			not_processed += radeon_fence_count_emitted(rdev, i);
-			if (not_processed >= 3)
-				break;
+			struct radeon_ring *ring = &rdev->ring[i];
+
+			if (ring->ready) {
+				not_processed += radeon_fence_count_emitted(rdev, i);
+				if (not_processed >= 3)
+					break;
+			}
 		}
 
 		if (not_processed >= 3) { /* should upclock */
-- 
1.7.7.5

Re: [PATCH] drm/radeon: fix regression in dynpm due to multi-ring rework

[Jerome Glisse]

On Thu, Jun 14, 2012 at 3:54 PM,  <alexdeucher@gmail.com> wrote:
> From: Alex Deucher <alexander.deucher@amd.com>
>
> Not all asics have all rings, so make sure the ring is ready
> before attempting to check it in the dynpm work handler.
>
> Fixes:
> https://bugzilla.kernel.org/show_bug.cgi?id=43367
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Jerome Glisse <jglisse@redhat.com>

> ---
>  drivers/gpu/drm/radeon/radeon_pm.c |   10 +++++++---
>  1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
> index 79642cd..7ae6066 100644
> --- a/drivers/gpu/drm/radeon/radeon_pm.c
> +++ b/drivers/gpu/drm/radeon/radeon_pm.c
> @@ -793,9 +793,13 @@ static void radeon_dynpm_idle_work_handler(struct work_struct *work)
>                int i;
>
>                for (i = 0; i < RADEON_NUM_RINGS; ++i) {
> -                       not_processed += radeon_fence_count_emitted(rdev, i);
> -                       if (not_processed >= 3)
> -                               break;
> +                       struct radeon_ring *ring = &rdev->ring[i];
> +
> +                       if (ring->ready) {
> +                               not_processed += radeon_fence_count_emitted(rdev, i);
> +                               if (not_processed >= 3)
> +                                       break;
> +                       }
>                }
>
>                if (not_processed >= 3) { /* should upclock */
> --
> 1.7.7.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/radeon: fix regression in dynpm due to multi-ring rework

[Christian König]

On 14.06.2012 21:54, alexdeucher@gmail.com wrote:
> From: Alex Deucher<alexander.deucher@amd.com>
>
> Not all asics have all rings, so make sure the ring is ready
> before attempting to check it in the dynpm work handler.
>
> Fixes:
> https://bugzilla.kernel.org/show_bug.cgi?id=43367
>
> Signed-off-by: Alex Deucher<alexander.deucher@amd.com>
Reviewed-by: Christian König<christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/radeon/radeon_pm.c |   10 +++++++---
>   1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
> index 79642cd..7ae6066 100644
> --- a/drivers/gpu/drm/radeon/radeon_pm.c
> +++ b/drivers/gpu/drm/radeon/radeon_pm.c
> @@ -793,9 +793,13 @@ static void radeon_dynpm_idle_work_handler(struct work_struct *work)
>   		int i;
>
>   		for (i = 0; i<  RADEON_NUM_RINGS; ++i) {
> -			not_processed += radeon_fence_count_emitted(rdev, i);
> -			if (not_processed>= 3)
> -				break;
> +			struct radeon_ring *ring =&rdev->ring[i];
> +
> +			if (ring->ready) {
> +				not_processed += radeon_fence_count_emitted(rdev, i);
> +				if (not_processed>= 3)
> +					break;
> +			}
>   		}
>
>   		if (not_processed>= 3) { /* should upclock */

Stripping of spaces in messages (was: [PATCH] drm/radeon: fix regression in dynpm due to multi-ring rework)

[Paul Menzel]

[-- Attachment #1.1: Type: text/plain, Size: 723 bytes --]

Dear Christian,


Am Donnerstag, den 14.06.2012, 22:17 +0200 schrieb Christian König:
> On 14.06.2012 21:54, alexdeucher@gmail.com wrote:
> > From: Alex Deucher<alexander.deucher@amd.com>
                      ^

> > Not all asics have all rings, so make sure the ring is ready
> > before attempting to check it in the dynpm work handler.
> >
> > Fixes:
> > https://bugzilla.kernel.org/show_bug.cgi?id=43367
> >
> > Signed-off-by: Alex Deucher<alexander.deucher@amd.com>
                              ^
> Reviewed-by: Christian König<christian.koenig@amd.com>
                             ^

do you have any idea why your mailer strips the spaces in front of the
»<«?

[…]


Thanks,

Paul

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Stripping of spaces in messages

[Christian König]

On 14.06.2012 22:35, Paul Menzel wrote:
> Dear Christian,
>
>
> Am Donnerstag, den 14.06.2012, 22:17 +0200 schrieb Christian König:
>> On 14.06.2012 21:54, alexdeucher@gmail.com wrote:
>>> From: Alex Deucher<alexander.deucher@amd.com>
>                        ^
>
>>> Not all asics have all rings, so make sure the ring is ready
>>> before attempting to check it in the dynpm work handler.
>>>
>>> Fixes:
>>> https://bugzilla.kernel.org/show_bug.cgi?id=43367
>>>
>>> Signed-off-by: Alex Deucher<alexander.deucher@amd.com>
>                                ^
>> Reviewed-by: Christian König<christian.koenig@amd.com>
>                               ^
>
> do you have any idea why your mailer strips the spaces in front of the
> »<«?
Noticed that effect for a couple of days now, but I have no idea what is 
causing this.

I'm using plain Thunderbird 12.0.1.

Regards,
Christian.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel