From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: liwp.linux@gmail.com
Cc: trivial@kernel.org, benh@kernel.crashing.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
bhelgaas@google.com, hannes@cmpxchg.org, mhocko@suse.cz,
bsingharora@gmail.com, kamezawa.hiroyu@jp.fujitsu.com,
tj@kernel.org, lizefan@huawei.com, cl@linux-foundation.org,
paul.gortmaker@windriver.com, jbarnes@virtuousgeek.org,
miltonm@bga.com, nacc@us.ibm.com, sfr@canb.auug.org.au,
a.p.zijlstra@chello.nl, jason.wessel@windriver.com,
jan.kiszka@siemens.com, dhowells@redhat.com,
srikar@linux.vnet.ibm.com, akpm@linux-foundation.org,
mel@csn.ul.ie, minchan@kernel.org, shangw@linux.vnet.ibm.com,
viro@zeniv.linux.org.uk, aarcange@redhat.com,
rientjes@google.com, kosaki.motohiro@jp.fujitsu.com,
lwoodman@redhat.com, hughd@google.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH 7/7] mm/memory.c : cleanup the coding style issue
Date: Fri, 15 Jun 2012 15:40:57 -0400 [thread overview]
Message-ID: <4FDB8FC9.2020909@jp.fujitsu.com> (raw)
In-Reply-To: <1339766449-7835-1-git-send-email-liwp.linux@gmail.com>
> diff --git a/mm/memory.c b/mm/memory.c
> index 1b7dc66..195d6e1 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -2447,7 +2447,8 @@ static inline int pte_unmap_same(struct mm_struct *mm, pmd_t *pmd,
> return same;
> }
>
> -static inline void cow_user_page(struct page *dst, struct page *src, unsigned long va, struct vm_area_struct *vma)
> +static inline void cow_user_page(struct page *dst, struct page *src,
> + unsigned long va, struct vm_area_struct *vma)
> {
> /*
> * If the source page was a PFN mapping, we don't have
Nowadays, many developers prefer to declare a function in one line. and we don't think
this is incorrect anymore. so, I think this is intentional.
WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: liwp.linux@gmail.com
Cc: cl@linux-foundation.org, srikar@linux.vnet.ibm.com,
linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org,
mhocko@suse.cz, paul.gortmaker@windriver.com, hpa@zytor.com,
lwoodman@redhat.com, aarcange@redhat.com, sfr@canb.auug.org.au,
shangw@linux.vnet.ibm.com, x86@kernel.org, hughd@google.com,
mingo@redhat.com, kosaki.motohiro@jp.fujitsu.com,
jan.kiszka@siemens.com, nacc@us.ibm.com, a.p.zijlstra@chello.nl,
mel@csn.ul.ie, jason.wessel@windriver.com,
viro@zeniv.linux.org.uk, bhelgaas@google.com,
cgroups@vger.kernel.org, tglx@linutronix.de,
kamezawa.hiroyu@jp.fujitsu.com, dhowells@redhat.com,
trivial@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, miltonm@bga.com,
minchan@kernel.org, lizefan@huawei.com, hannes@cmpxchg.org,
tj@kernel.org, rientjes@google.com, akpm@linux-foundation.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 7/7] mm/memory.c : cleanup the coding style issue
Date: Fri, 15 Jun 2012 15:40:57 -0400 [thread overview]
Message-ID: <4FDB8FC9.2020909@jp.fujitsu.com> (raw)
In-Reply-To: <1339766449-7835-1-git-send-email-liwp.linux@gmail.com>
> diff --git a/mm/memory.c b/mm/memory.c
> index 1b7dc66..195d6e1 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -2447,7 +2447,8 @@ static inline int pte_unmap_same(struct mm_struct *mm, pmd_t *pmd,
> return same;
> }
>
> -static inline void cow_user_page(struct page *dst, struct page *src, unsigned long va, struct vm_area_struct *vma)
> +static inline void cow_user_page(struct page *dst, struct page *src,
> + unsigned long va, struct vm_area_struct *vma)
> {
> /*
> * If the source page was a PFN mapping, we don't have
Nowadays, many developers prefer to declare a function in one line. and we don't think
this is incorrect anymore. so, I think this is intentional.
WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: liwp.linux@gmail.com
Cc: trivial@kernel.org, benh@kernel.crashing.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
bhelgaas@google.com, hannes@cmpxchg.org, mhocko@suse.cz,
bsingharora@gmail.com, kamezawa.hiroyu@jp.fujitsu.com,
tj@kernel.org, lizefan@huawei.com, cl@linux-foundation.org,
paul.gortmaker@windriver.com, jbarnes@virtuousgeek.org,
miltonm@bga.com, nacc@us.ibm.com, sfr@canb.auug.org.au,
a.p.zijlstra@chello.nl, jason.wessel@windriver.com,
jan.kiszka@siemens.com, dhowells@redhat.com,
srikar@linux.vnet.ibm.com, akpm@linux-foundation.org,
mel@csn.ul.ie, minchan@kernel.org, shangw@linux.vnet.ibm.com,
viro@zeniv.linux.org.uk, aarcange@redhat.com,
rientjes@google.com, kosaki.motohiro@jp.fujitsu.com,
lwoodman@redhat.com, hughd@google.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH 7/7] mm/memory.c : cleanup the coding style issue
Date: Fri, 15 Jun 2012 15:40:57 -0400 [thread overview]
Message-ID: <4FDB8FC9.2020909@jp.fujitsu.com> (raw)
In-Reply-To: <1339766449-7835-1-git-send-email-liwp.linux@gmail.com>
> diff --git a/mm/memory.c b/mm/memory.c
> index 1b7dc66..195d6e1 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -2447,7 +2447,8 @@ static inline int pte_unmap_same(struct mm_struct *mm, pmd_t *pmd,
> return same;
> }
>
> -static inline void cow_user_page(struct page *dst, struct page *src, unsigned long va, struct vm_area_struct *vma)
> +static inline void cow_user_page(struct page *dst, struct page *src,
> + unsigned long va, struct vm_area_struct *vma)
> {
> /*
> * If the source page was a PFN mapping, we don't have
Nowadays, many developers prefer to declare a function in one line. and we don't think
this is incorrect anymore. so, I think this is intentional.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-15 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 13:20 [PATCH 7/7] mm/memory.c : cleanup the coding style issue Wanpeng Li
2012-06-15 13:20 ` Wanpeng Li
2012-06-15 13:20 ` Wanpeng Li
2012-06-15 19:40 ` KOSAKI Motohiro [this message]
2012-06-15 19:40 ` KOSAKI Motohiro
2012-06-15 19:40 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDB8FC9.2020909@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=a.p.zijlstra@chello.nl \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=hughd@google.com \
--cc=jan.kiszka@siemens.com \
--cc=jason.wessel@windriver.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liwp.linux@gmail.com \
--cc=lizefan@huawei.com \
--cc=lwoodman@redhat.com \
--cc=mel@csn.ul.ie \
--cc=mhocko@suse.cz \
--cc=miltonm@bga.com \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=nacc@us.ibm.com \
--cc=paul.gortmaker@windriver.com \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=shangw@linux.vnet.ibm.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=trivial@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.