Re: [PATCH 1/6] canfd: add new data structures and constants

[Oliver Hartkopp <socketcan@hartkopp.net>]

On 18.06.2012 21:55, Marc Kleine-Budde wrote:

> On 06/18/2012 09:48 PM, Marc Kleine-Budde wrote:
>> If you want to be super clean you can first make a patch that changes
>> the existing __attribute__((aligned(8))) to __aligned(8), and then add
>> your canfd series. If not, just mention it in the patch description
>> (While being here change can_fd to __aligned(8)).
>>
>> Err..this is a userspace header, I just tested it, headers_install
>> doesn't remove it. And userspace fails to compile with this. For now
>> stick to __attribute__((aligned(8))).
> 
> BTW: and it fails to compile due to a __kernel_sa_family_t which isn't
> defined on my ubuntu with 2.6.32er headers


__kernel_sa_family_t is defined in include/linux/socket.h but with

#ifdef __KERNEL__

around it.

typedef __kernel_sa_family_t    sa_family_t;

What do you compile?

If you compile a kernel -> it is defined.
If you compile an application -> it is not needed.

Regards,
Oliver