From: Scott Wood <scottwood@freescale.com>
To: kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] KVM: PPC: bookehv64: Add support for std/ld emulation.
Date: Mon, 18 Jun 2012 20:48:40 +0000 [thread overview]
Message-ID: <4FDF9428.3070601@freescale.com> (raw)
On 06/18/2012 03:42 PM, Varun Sethi wrote:
> Add support for std/ld emulation.
>
> Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
> ---
> arch/powerpc/kvm/emulate.c | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c
> index f90e86d..a04543a 100644
> --- a/arch/powerpc/kvm/emulate.c
> +++ b/arch/powerpc/kvm/emulate.c
> @@ -59,11 +59,13 @@
> #define OP_31_XOP_STHBRX 918
>
> #define OP_LWZ 32
> +#define OP_LD 58
> #define OP_LWZU 33
> #define OP_LBZ 34
> #define OP_LBZU 35
> #define OP_STW 36
> #define OP_STWU 37
> +#define OP_STD 62
> #define OP_STB 38
> #define OP_STBU 39
> #define OP_LHZ 40
What about STDU, STDX, LWA, etc? If you're going to add some 64-bit
load/store instructions, but not others of the same classes as are
implemented for 32-bit, at least leave a comment pointing out what's
missing.
-Scott
next reply other threads:[~2012-06-18 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 20:48 Scott Wood [this message]
2012-06-18 20:52 ` [PATCH] KVM: PPC: bookehv64: Add support for std/ld emulation Varun Sethi
2012-06-18 20:54 ` Varun Sethi
2012-06-18 20:58 ` Sethi Varun-B16395
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDF9428.3070601@freescale.com \
--to=scottwood@freescale.com \
--cc=kvm-ppc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.