Re: [PATCH] KVM: PPC: bookehv64: Add support for std/ld emulation.

All of lore.kernel.org
 help / color / mirror / Atom feed

* Re: [PATCH] KVM: PPC: bookehv64: Add support for std/ld emulation.
@ 2012-06-18 20:48 Scott Wood
  2012-06-18 20:52 ` Varun Sethi
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Scott Wood @ 2012-06-18 20:48 UTC (permalink / raw)
  To: kvm-ppc

On 06/18/2012 03:42 PM, Varun Sethi wrote:
> Add support for std/ld emulation.
> 
> Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
> ---
>  arch/powerpc/kvm/emulate.c |   14 ++++++++++++++
>  1 files changed, 14 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c
> index f90e86d..a04543a 100644
> --- a/arch/powerpc/kvm/emulate.c
> +++ b/arch/powerpc/kvm/emulate.c
> @@ -59,11 +59,13 @@
>  #define OP_31_XOP_STHBRX    918
>  
>  #define OP_LWZ  32
> +#define OP_LD   58
>  #define OP_LWZU 33
>  #define OP_LBZ  34
>  #define OP_LBZU 35
>  #define OP_STW  36
>  #define OP_STWU 37
> +#define OP_STD  62
>  #define OP_STB  38
>  #define OP_STBU 39
>  #define OP_LHZ  40

What about STDU, STDX, LWA, etc?  If you're going to add some 64-bit
load/store instructions, but not others of the same classes as are
implemented for 32-bit, at least leave a comment pointing out what's
missing.

-Scott


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] KVM: PPC: bookehv64: Add support for std/ld emulation.
  2012-06-18 20:48 [PATCH] KVM: PPC: bookehv64: Add support for std/ld emulation Scott Wood
@ 2012-06-18 20:52 ` Varun Sethi
  2012-06-18 20:54 ` Varun Sethi
  2012-06-18 20:58 ` Sethi Varun-B16395
  2 siblings, 0 replies; 4+ messages in thread
From: Varun Sethi @ 2012-06-18 20:52 UTC (permalink / raw)
  To: kvm-ppc

Add support for std/ld emulation.

Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
---
 arch/powerpc/kvm/emulate.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c
index f90e86d..a04543a 100644
--- a/arch/powerpc/kvm/emulate.c
+++ b/arch/powerpc/kvm/emulate.c
@@ -59,11 +59,13 @@
 #define OP_31_XOP_STHBRX    918
 
 #define OP_LWZ  32
+#define OP_LD   58
 #define OP_LWZU 33
 #define OP_LBZ  34
 #define OP_LBZU 35
 #define OP_STW  36
 #define OP_STWU 37
+#define OP_STD  62
 #define OP_STB  38
 #define OP_STBU 39
 #define OP_LHZ  40
@@ -392,6 +394,11 @@ int kvmppc_emulate_instruction(struct kvm_run *run, struct kvm_vcpu *vcpu)
 		emulated = kvmppc_handle_load(run, vcpu, rt, 4, 1);
 		break;
 
+	case OP_LD:
+		rt = get_rt(inst);
+		emulated = kvmppc_handle_load(run, vcpu, rt, 8, 1);
+		break;
+
 	case OP_LWZU:
 		emulated = kvmppc_handle_load(run, vcpu, rt, 4, 1);
 		kvmppc_set_gpr(vcpu, ra, vcpu->arch.vaddr_accessed);
@@ -412,6 +419,13 @@ int kvmppc_emulate_instruction(struct kvm_run *run, struct kvm_vcpu *vcpu)
 		                               4, 1);
 		break;
 
+	case OP_STD:
+		rs = get_rs(inst);
+		emulated = kvmppc_handle_store(run, vcpu,
+					       kvmppc_get_gpr(vcpu, rs),
+		                               8, 1);
+		break;
+
 	case OP_STWU:
 		emulated = kvmppc_handle_store(run, vcpu,
 					       kvmppc_get_gpr(vcpu, rs),
-- 
1.7.4.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] KVM: PPC: bookehv64: Add support for std/ld emulation.
  2012-06-18 20:48 [PATCH] KVM: PPC: bookehv64: Add support for std/ld emulation Scott Wood
  2012-06-18 20:52 ` Varun Sethi
@ 2012-06-18 20:54 ` Varun Sethi
  2012-06-18 20:58 ` Sethi Varun-B16395
  2 siblings, 0 replies; 4+ messages in thread
From: Varun Sethi @ 2012-06-18 20:54 UTC (permalink / raw)
  To: kvm-ppc

Add support for std/ld emulation.

Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
---
 arch/powerpc/kvm/emulate.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c
index f90e86d..a04543a 100644
--- a/arch/powerpc/kvm/emulate.c
+++ b/arch/powerpc/kvm/emulate.c
@@ -59,11 +59,13 @@
 #define OP_31_XOP_STHBRX    918
 
 #define OP_LWZ  32
+#define OP_LD   58
 #define OP_LWZU 33
 #define OP_LBZ  34
 #define OP_LBZU 35
 #define OP_STW  36
 #define OP_STWU 37
+#define OP_STD  62
 #define OP_STB  38
 #define OP_STBU 39
 #define OP_LHZ  40
@@ -392,6 +394,11 @@ int kvmppc_emulate_instruction(struct kvm_run *run, struct kvm_vcpu *vcpu)
 		emulated = kvmppc_handle_load(run, vcpu, rt, 4, 1);
 		break;
 
+	case OP_LD:
+		rt = get_rt(inst);
+		emulated = kvmppc_handle_load(run, vcpu, rt, 8, 1);
+		break;
+
 	case OP_LWZU:
 		emulated = kvmppc_handle_load(run, vcpu, rt, 4, 1);
 		kvmppc_set_gpr(vcpu, ra, vcpu->arch.vaddr_accessed);
@@ -412,6 +419,13 @@ int kvmppc_emulate_instruction(struct kvm_run *run, struct kvm_vcpu *vcpu)
 		                               4, 1);
 		break;
 
+	case OP_STD:
+		rs = get_rs(inst);
+		emulated = kvmppc_handle_store(run, vcpu,
+					       kvmppc_get_gpr(vcpu, rs),
+		                               8, 1);
+		break;
+
 	case OP_STWU:
 		emulated = kvmppc_handle_store(run, vcpu,
 					       kvmppc_get_gpr(vcpu, rs),
-- 
1.7.4.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH] KVM: PPC: bookehv64: Add support for std/ld emulation.
  2012-06-18 20:48 [PATCH] KVM: PPC: bookehv64: Add support for std/ld emulation Scott Wood
  2012-06-18 20:52 ` Varun Sethi
  2012-06-18 20:54 ` Varun Sethi
@ 2012-06-18 20:58 ` Sethi Varun-B16395
  2 siblings, 0 replies; 4+ messages in thread
From: Sethi Varun-B16395 @ 2012-06-18 20:58 UTC (permalink / raw)
  To: kvm-ppc

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogVHVlc2RheSwgSnVuZSAxOSwgMjAxMiAyOjE5IEFNDQo+IFRvOiBTZXRoaSBW
YXJ1bi1CMTYzOTUNCj4gQ2M6IGt2bS1wcGNAdmdlci5rZXJuZWwub3JnDQo+IFN1YmplY3Q6IFJl
OiBbUEFUQ0hdIEtWTTogUFBDOiBib29rZWh2NjQ6IEFkZCBzdXBwb3J0IGZvciBzdGQvbGQNCj4g
ZW11bGF0aW9uLg0KPiANCj4gT24gMDYvMTgvMjAxMiAwMzo0MiBQTSwgVmFydW4gU2V0aGkgd3Jv
dGU6DQo+ID4gQWRkIHN1cHBvcnQgZm9yIHN0ZC9sZCBlbXVsYXRpb24uDQo+ID4NCj4gPiBTaWdu
ZWQtb2ZmLWJ5OiBWYXJ1biBTZXRoaSA8VmFydW4uU2V0aGlAZnJlZXNjYWxlLmNvbT4NCj4gPiAt
LS0NCj4gPiAgYXJjaC9wb3dlcnBjL2t2bS9lbXVsYXRlLmMgfCAgIDE0ICsrKysrKysrKysrKysr
DQo+ID4gIDEgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkN
Cj4gPg0KPiA+IGRpZmYgLS1naXQgYS9hcmNoL3Bvd2VycGMva3ZtL2VtdWxhdGUuYyBiL2FyY2gv
cG93ZXJwYy9rdm0vZW11bGF0ZS5jDQo+ID4gaW5kZXggZjkwZTg2ZC4uYTA0NTQzYSAxMDA2NDQN
Cj4gPiAtLS0gYS9hcmNoL3Bvd2VycGMva3ZtL2VtdWxhdGUuYw0KPiA+ICsrKyBiL2FyY2gvcG93
ZXJwYy9rdm0vZW11bGF0ZS5jDQo+ID4gQEAgLTU5LDExICs1OSwxMyBAQA0KPiA+ICAjZGVmaW5l
IE9QXzMxX1hPUF9TVEhCUlggICAgOTE4DQo+ID4NCj4gPiAgI2RlZmluZSBPUF9MV1ogIDMyDQo+
ID4gKyNkZWZpbmUgT1BfTEQgICA1OA0KPiA+ICAjZGVmaW5lIE9QX0xXWlUgMzMNCj4gPiAgI2Rl
ZmluZSBPUF9MQlogIDM0DQo+ID4gICNkZWZpbmUgT1BfTEJaVSAzNQ0KPiA+ICAjZGVmaW5lIE9Q
X1NUVyAgMzYNCj4gPiAgI2RlZmluZSBPUF9TVFdVIDM3DQo+ID4gKyNkZWZpbmUgT1BfU1REICA2
Mg0KPiA+ICAjZGVmaW5lIE9QX1NUQiAgMzgNCj4gPiAgI2RlZmluZSBPUF9TVEJVIDM5DQo+ID4g
ICNkZWZpbmUgT1BfTEhaICA0MA0KPiANCj4gV2hhdCBhYm91dCBTVERVLCBTVERYLCBMV0EsIGV0
Yz8gIElmIHlvdSdyZSBnb2luZyB0byBhZGQgc29tZSA2NC1iaXQNCj4gbG9hZC9zdG9yZSBpbnN0
cnVjdGlvbnMsIGJ1dCBub3Qgb3RoZXJzIG9mIHRoZSBzYW1lIGNsYXNzZXMgYXMgYXJlDQo+IGlt
cGxlbWVudGVkIGZvciAzMi1iaXQsIGF0IGxlYXN0IGxlYXZlIGEgY29tbWVudCBwb2ludGluZyBv
dXQgd2hhdCdzDQo+IG1pc3NpbmcuDQpUaGVyZSB3b3VsZCBiZSBhIHNlcGFyYXRlIHBhdGNoIGZv
ciBzdXBwb3J0aW5nIHRob3NlIGluc3RydWN0aW9ucy4gSSB3aWxsIGEgIlRCRCIgY29tbWVudCAN
CmluIHRoZSBjb2RlLg0KDQotVmFydW4NCg=


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-06-18 20:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-18 20:48 [PATCH] KVM: PPC: bookehv64: Add support for std/ld emulation Scott Wood
2012-06-18 20:52 ` Varun Sethi
2012-06-18 20:54 ` Varun Sethi
2012-06-18 20:58 ` Sethi Varun-B16395

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.