From: Rik van Riel <riel@redhat.com>
To: Borislav Petkov <bp@alien8.de>, Andi Kleen <andi@firstfloor.org>,
linux-mm@kvack.org, akpm@linux-foundation.org,
aarcange@redhat.com, peterz@infradead.org, minchan@gmail.com,
kosaki.motohiro@gmail.com, hnaz@cmpxchg.org, mel@csn.ul.ie,
linux-kernel@vger.kernel.org, Rik van Riel <riel@surriel.com>
Subject: Re: [PATCH -mm 3/6] Fix the x86-64 page colouring code to take pgoff into account and use that code as the basis for a generic page colouring code.
Date: Mon, 18 Jun 2012 18:03:09 -0400 [thread overview]
Message-ID: <4FDFA59D.5020200@redhat.com> (raw)
In-Reply-To: <20120618203720.GA4148@liondog.tnic>
On 06/18/2012 04:37 PM, Borislav Petkov wrote:
> and your patch has some new ifs in it:
>
> @@ -386,12 +398,16 @@ void validate_mm(struct mm_struct *mm)
> int bug = 0;
> int i = 0;
> struct vm_area_struct *tmp = mm->mmap;
> + unsigned long highest_address = 0;
> while (tmp) {
> if (tmp->free_gap != max_free_space(&tmp->vm_rb))
> printk("free space %lx, correct %lx\n", tmp->free_gap, max_free_space(&tmp->vm_rb)), bug = 1;
>
> ^^^^^^^^^^^^^^
>
> I think this if-statement is the problem. It is not present in mainline
> but this patch doesn't add it so some patch earlier than that adds it
> which is probably in your queue?
Argh! I see the problem now.
guilt-patchbomb sent everything from my second patch onwards,
not my first patch :(
Let me resend the series properly, I have 7 patches not 6.
I am having a bad email day...
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Borislav Petkov <bp@alien8.de>, Andi Kleen <andi@firstfloor.org>,
linux-mm@kvack.org, akpm@linux-foundation.org,
aarcange@redhat.com, peterz@infradead.org, minchan@gmail.com,
kosaki.motohiro@gmail.com, hnaz@cmpxchg.org, mel@csn.ul.ie,
linux-kernel@vger.kernel.org, Rik van Riel <riel@surriel.com>
Subject: Re: [PATCH -mm 3/6] Fix the x86-64 page colouring code to take pgoff into account and use that code as the basis for a generic page colouring code.
Date: Mon, 18 Jun 2012 18:03:09 -0400 [thread overview]
Message-ID: <4FDFA59D.5020200@redhat.com> (raw)
In-Reply-To: <20120618203720.GA4148@liondog.tnic>
On 06/18/2012 04:37 PM, Borislav Petkov wrote:
> and your patch has some new ifs in it:
>
> @@ -386,12 +398,16 @@ void validate_mm(struct mm_struct *mm)
> int bug = 0;
> int i = 0;
> struct vm_area_struct *tmp = mm->mmap;
> + unsigned long highest_address = 0;
> while (tmp) {
> if (tmp->free_gap != max_free_space(&tmp->vm_rb))
> printk("free space %lx, correct %lx\n", tmp->free_gap, max_free_space(&tmp->vm_rb)), bug = 1;
>
> ^^^^^^^^^^^^^^
>
> I think this if-statement is the problem. It is not present in mainline
> but this patch doesn't add it so some patch earlier than that adds it
> which is probably in your queue?
Argh! I see the problem now.
guilt-patchbomb sent everything from my second patch onwards,
not my first patch :(
Let me resend the series properly, I have 7 patches not 6.
I am having a bad email day...
--
All rights reversed
next prev parent reply other threads:[~2012-06-18 22:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 14:31 [PATCH -mm 0/6] mm: scalable and unified arch_get_unmapped_area Rik van Riel
2012-06-18 14:31 ` Rik van Riel
2012-06-18 14:31 ` [PATCH -mm 1/6] mm: get unmapped area from VMA tree Rik van Riel
2012-06-18 14:31 ` Rik van Riel
2012-06-18 14:31 ` [PATCH -mm 2/6] Allow each architecture to specify the address range that can be used for this allocation Rik van Riel
2012-06-18 14:31 ` Rik van Riel
2012-06-18 14:31 ` [PATCH -mm 3/6] Fix the x86-64 page colouring code to take pgoff into account and use that code as the basis for a generic page colouring code Rik van Riel
2012-06-18 14:31 ` Rik van Riel
2012-06-18 16:30 ` Andi Kleen
2012-06-18 16:30 ` Andi Kleen
2012-06-18 16:45 ` Rik van Riel
2012-06-18 16:45 ` Rik van Riel
2012-06-18 18:16 ` Borislav Petkov
2012-06-18 18:16 ` Borislav Petkov
2012-06-18 19:00 ` Rik van Riel
2012-06-18 19:00 ` Rik van Riel
2012-06-18 19:02 ` Rik van Riel
2012-06-18 19:02 ` Rik van Riel
2012-06-18 20:37 ` Borislav Petkov
2012-06-18 20:37 ` Borislav Petkov
2012-06-18 22:03 ` Rik van Riel [this message]
2012-06-18 22:03 ` Rik van Riel
2012-06-18 14:31 ` [PATCH -mm 4/6] mm: remove x86 arch_get_unmapped_area(_topdown) Rik van Riel
2012-06-18 14:31 ` Rik van Riel
2012-06-18 14:31 ` [PATCH -mm 5/6] remove MIPS arch_get_unmapped_area code Rik van Riel
2012-06-18 14:31 ` Rik van Riel
2012-06-18 14:31 ` [PATCH -mm 6/6] remove ARM arch_get_unmapped_area functions Rik van Riel
2012-06-18 14:31 ` Rik van Riel
[not found] <1340029247-6949-1-git-send-email-riel@surriel.com>
2012-06-18 14:20 ` [[PATCH -mm] 3/6] Fix the x86-64 page colouring code to take pgoff into account and use that code as the basis for a generic page colouring code Rik van Riel
2012-06-18 14:20 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDFA59D.5020200@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=bp@alien8.de \
--cc=hnaz@cmpxchg.org \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan@gmail.com \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.