From: Eric Blake <eblake@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Chegu Vinod <chegu_vinod@hp.com>, Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, kvm@vger.kernel.org, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Fixes related to processing of qemu's -numa option
Date: Mon, 18 Jun 2012 16:11:29 -0600 [thread overview]
Message-ID: <4FDFA791.9020909@redhat.com> (raw)
In-Reply-To: <4FDFA633.7090505@suse.de>
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
On 06/18/2012 04:05 PM, Andreas Färber wrote:
> Am 17.06.2012 22:12, schrieb Chegu Vinod:
>> diff --git a/vl.c b/vl.c
>> index 204d85b..1906412 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -28,6 +28,7 @@
>> #include <errno.h>
>> #include <sys/time.h>
>> #include <zlib.h>
>> +#include <sched.h>
>
> Did you check whether this and the macros you're using are available on
> POSIX and mingw32? vl.c is a pretty central file.
POSIX, yes. mingw32, no. Use of preprocessor conditionals is probably
in order.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Stefan Weil <sw@weilnetz.de>, Chegu Vinod <chegu_vinod@hp.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Fixes related to processing of qemu's -numa option
Date: Mon, 18 Jun 2012 16:11:29 -0600 [thread overview]
Message-ID: <4FDFA791.9020909@redhat.com> (raw)
In-Reply-To: <4FDFA633.7090505@suse.de>
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
On 06/18/2012 04:05 PM, Andreas Färber wrote:
> Am 17.06.2012 22:12, schrieb Chegu Vinod:
>> diff --git a/vl.c b/vl.c
>> index 204d85b..1906412 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -28,6 +28,7 @@
>> #include <errno.h>
>> #include <sys/time.h>
>> #include <zlib.h>
>> +#include <sched.h>
>
> Did you check whether this and the macros you're using are available on
> POSIX and mingw32? vl.c is a pretty central file.
POSIX, yes. mingw32, no. Use of preprocessor conditionals is probably
in order.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-06-18 22:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-17 20:12 [PATCH] Fixes related to processing of qemu's -numa option Chegu Vinod
2012-06-17 20:12 ` [Qemu-devel] " Chegu Vinod
2012-06-18 20:29 ` Eduardo Habkost
2012-06-18 20:29 ` [Qemu-devel] " Eduardo Habkost
2012-06-18 21:55 ` Chegu Vinod
2012-06-18 22:05 ` Andreas Färber
2012-06-18 22:05 ` [Qemu-devel] " Andreas Färber
2012-06-18 22:11 ` Eric Blake [this message]
2012-06-18 22:11 ` Eric Blake
2012-06-18 22:15 ` Chegu Vinod
2012-06-18 22:15 ` Chegu Vinod
[not found] ` <4FE0638F.9080200@hp.com>
[not found] ` <20120619203502.GB5073@otherpad.lan.raisama.net>
2012-06-19 20:51 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDFA791.9020909@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=chegu_vinod@hp.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.