From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] '.' causes wildcard expansion
Date: Tue, 19 Jun 2012 14:19:43 +0200 [thread overview]
Message-ID: <4FE06E5F.5050204@gmail.com> (raw)
In-Reply-To: <4FD91756.9080200@comcast.net>
[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]
On 14.06.2012 00:42, Robert Mabee wrote:
> Having second thoughts. Where I suggested taking out this call
>
>> - else if (isregexop (ch))
>> + else if (ch == '*') /* only wildcard currently implemented */
> I should have just taken the extraneous '.' out of isregexop. That would
> make it slightly simpler to add the remaining shell wildcards ('?' and '[')
> when desired.
>
> '[' already works, if there's also a * to trigger expansion, with the small
> bug that special chars within [] still get escaped or translated so the set
> may include an unexpected '.' or '\'.
>
I've fixed these problems AFAICT now. Can you confirm?
> Other regex chars also work, which probably should be counted as a
> bug. I assume the eventual goal is to behave just like a common shell.
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2012-06-19 12:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 6:56 [PATCH] '.' causes wildcard expansion Robert Mabee
2012-06-13 22:42 ` Robert Mabee
2012-06-18 11:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-06-19 12:19 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2012-06-20 8:04 ` Robert Mabee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE06E5F.5050204@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.