All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Mabee <rmabee@comcast.net>
To: grub-devel@gnu.org
Subject: Re: [PATCH] '.' causes wildcard expansion
Date: Wed, 13 Jun 2012 18:42:30 -0400	[thread overview]
Message-ID: <4FD91756.9080200@comcast.net> (raw)
In-Reply-To: <4FD59694.3080600@comcast.net>

Having second thoughts.  Where I suggested taking out this call

> -      else if (isregexop (ch))
> +      else if (ch == '*')    /* only wildcard currently implemented */
I should have just taken the extraneous '.' out of isregexop.  That would
make it slightly simpler to add the remaining shell wildcards ('?' and '[')
when desired.

'[' already works, if there's also a * to trigger expansion, with the small
bug that special chars within [] still get escaped or translated so the set
may include an unexpected '.' or '\'.

Other regex chars also work, which probably should be counted as a
bug.  I assume the eventual goal is to behave just like a common shell.



  reply	other threads:[~2012-06-13 22:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-11  6:56 [PATCH] '.' causes wildcard expansion Robert Mabee
2012-06-13 22:42 ` Robert Mabee [this message]
2012-06-18 11:03   ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-06-19 12:19   ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-06-20  8:04     ` Robert Mabee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD91756.9080200@comcast.net \
    --to=rmabee@comcast.net \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.