All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Kevin Hilman <khilman@ti.com>
Cc: linux-omap@vger.kernel.org,
	Jean Pihet <jean.pihet@newoldbits.com>,
	Tero Kristo <t-kristo@ti.com>, Paul Walmsley <paul@pwsan.com>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [PATCH/RFT 2/3] ARM: OMAP3: PM: call pre/post transition per powerdomain
Date: Tue, 19 Jun 2012 09:51:14 -0700	[thread overview]
Message-ID: <4FE0AE02.20506@ti.com> (raw)
In-Reply-To: <1335277420-29124-3-git-send-email-khilman@ti.com>

On 04/24/2012 07:23 AM, Kevin Hilman wrote:
> We only need to call the pre/post transtion methods when we know the
> power state is changing.  First, split up the pre/post transition
> calls to be per-powerdomain, and then make them conditional on whether
> the power domain is actually changing states.
>
> Signed-off-by: Kevin Hilman<khilman@ti.com>

This patch introduced a regression where the transition counts for NEON 
were no longer accurate because I forgot to call the notifiers for NEON 
when calling them for MPU.

The diff below will be folded into this patch before submitting for v3.6.

Kevin

diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 8bd7daf..6226d10 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -306,8 +306,10 @@ void omap_sram_idle(void)
  			omap3_enable_io_chain();
  	}

-	if (mpu_next_state < PWRDM_POWER_ON)
+	if (mpu_next_state < PWRDM_POWER_ON) {
  		pwrdm_pre_transition(mpu_pwrdm);
+		pwrdm_pre_transition(neon_pwrdm);
+	}

  	/* PER */
  	if (per_next_state < PWRDM_POWER_ON) {
@@ -391,8 +393,10 @@ void omap_sram_idle(void)
  			omap3_disable_io_chain();
  	}

-	if (mpu_next_state < PWRDM_POWER_ON)
+	if (mpu_next_state < PWRDM_POWER_ON) {
  		pwrdm_post_transition(mpu_pwrdm);
+		pwrdm_post_transition(neon_pwrdm);
+	}
  }

  static void omap3_pm_idle(void)

  reply	other threads:[~2012-06-19 16:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24 14:23 [PATCH/RFT 0/3] ARM: OMAP: PM: reduce overhead of pwrdm pre/post transitions Kevin Hilman
2012-04-24 14:23 ` [PATCH/RFT 1/3] ARM: OMAP2+: powerdomain: allow pre/post transtion to be per pwrdm Kevin Hilman
2012-04-24 14:31   ` Shilimkar, Santosh
2012-04-25  8:44   ` Shilimkar, Santosh
2012-04-26  3:31   ` Paul Walmsley
2012-04-26 13:35     ` Kevin Hilman
2012-04-24 14:23 ` [PATCH/RFT 2/3] ARM: OMAP3: PM: call pre/post transition per powerdomain Kevin Hilman
2012-06-19 16:51   ` Kevin Hilman [this message]
2012-04-24 14:23 ` [PATCH/RFT 3/3] ARM: OMAP3: PM: cleanup cam_pwrdm leftovers Kevin Hilman
2012-04-27  7:20   ` Tero Kristo
2012-04-27 20:18     ` Kevin Hilman
2012-04-28 14:47   ` Grazvydas Ignotas
2012-04-30 20:45     ` Kevin Hilman
2012-04-24 23:01 ` [PATCH/RFT 0/3] ARM: OMAP: PM: reduce overhead of pwrdm pre/post transitions Grazvydas Ignotas
2012-04-25 13:24 ` Shilimkar, Santosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE0AE02.20506@ti.com \
    --to=khilman@ti.com \
    --cc=jean.pihet@newoldbits.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.