From: Kevin Hilman <khilman@ti.com>
To: t-kristo@ti.com
Cc: linux-omap@vger.kernel.org,
Jean Pihet <jean.pihet@newoldbits.com>,
Paul Walmsley <paul@pwsan.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [PATCH/RFT 3/3] ARM: OMAP3: PM: cleanup cam_pwrdm leftovers
Date: Fri, 27 Apr 2012 13:18:23 -0700 [thread overview]
Message-ID: <8762cl53ow.fsf@ti.com> (raw)
In-Reply-To: <1335511214.2149.136.camel@sokoban> (Tero Kristo's message of "Fri, 27 Apr 2012 10:20:14 +0300")
Tero Kristo <t-kristo@ti.com> writes:
> Looks good to me, acked.
Thanks.
Kevin
>
> On Tue, 2012-04-24 at 07:23 -0700, Kevin Hilman wrote:
>> commit e7410cf7 (02fdb03e69699f26e1370d0e51593dbc8a4e5265) moved
>> mangement of cam_pwrdm to CPUidle but left some remnants behind,
>> namely the call to clkcm_allo_idle() for the clockdomains in the MPU
>> pwrdm. Remove these since they are not necessary and cause unwanted
>> latency in the idle path.
>>
>> Cc: Tero Kristo <Tero Kristo <t-kristo@ti.com>
>> Signed-off-by: Kevin Hilman <khilman@ti.com>
>> ---
>> arch/arm/mach-omap2/pm34xx.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
>> index 74a7f8c..66ff828 100644
>> --- a/arch/arm/mach-omap2/pm34xx.c
>> +++ b/arch/arm/mach-omap2/pm34xx.c
>> @@ -70,7 +70,6 @@ void (*omap3_do_wfi_sram)(void);
>>
>> static struct powerdomain *mpu_pwrdm, *neon_pwrdm;
>> static struct powerdomain *core_pwrdm, *per_pwrdm;
>> -static struct powerdomain *cam_pwrdm;
>>
>> static void omap3_enable_io_chain(void)
>> {
>> @@ -395,8 +394,6 @@ void omap_sram_idle(void)
>>
>> if (mpu_next_state < PWRDM_POWER_ON)
>> pwrdm_post_transition(mpu_pwrdm);
>> -
>> - clkdm_allow_idle(mpu_pwrdm->pwrdm_clkdms[0]);
>> }
>>
>> static void omap3_pm_idle(void)
>> @@ -759,7 +756,6 @@ static int __init omap3_pm_init(void)
>> neon_pwrdm = pwrdm_lookup("neon_pwrdm");
>> per_pwrdm = pwrdm_lookup("per_pwrdm");
>> core_pwrdm = pwrdm_lookup("core_pwrdm");
>> - cam_pwrdm = pwrdm_lookup("cam_pwrdm");
>>
>> neon_clkdm = clkdm_lookup("neon_clkdm");
>> mpu_clkdm = clkdm_lookup("mpu_clkdm");
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-04-27 20:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 14:23 [PATCH/RFT 0/3] ARM: OMAP: PM: reduce overhead of pwrdm pre/post transitions Kevin Hilman
2012-04-24 14:23 ` [PATCH/RFT 1/3] ARM: OMAP2+: powerdomain: allow pre/post transtion to be per pwrdm Kevin Hilman
2012-04-24 14:31 ` Shilimkar, Santosh
2012-04-25 8:44 ` Shilimkar, Santosh
2012-04-26 3:31 ` Paul Walmsley
2012-04-26 13:35 ` Kevin Hilman
2012-04-24 14:23 ` [PATCH/RFT 2/3] ARM: OMAP3: PM: call pre/post transition per powerdomain Kevin Hilman
2012-06-19 16:51 ` Kevin Hilman
2012-04-24 14:23 ` [PATCH/RFT 3/3] ARM: OMAP3: PM: cleanup cam_pwrdm leftovers Kevin Hilman
2012-04-27 7:20 ` Tero Kristo
2012-04-27 20:18 ` Kevin Hilman [this message]
2012-04-28 14:47 ` Grazvydas Ignotas
2012-04-30 20:45 ` Kevin Hilman
2012-04-24 23:01 ` [PATCH/RFT 0/3] ARM: OMAP: PM: reduce overhead of pwrdm pre/post transitions Grazvydas Ignotas
2012-04-25 13:24 ` Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762cl53ow.fsf@ti.com \
--to=khilman@ti.com \
--cc=jean.pihet@newoldbits.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=santosh.shilimkar@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.