From: Jiang Liu <jiang.liu@huawei.com>
To: David Rientjes <rientjes@google.com>
Cc: Minchan Kim <minchan@kernel.org>,
Keping Chen <chenkeping@huawei.com>, Mel Gorman <mgorman@suse.de>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>, Tony Luck <tony.luck@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Jiang Liu <liuj97@gmail.com>
Subject: Re: [PATCH] trivial, memory hotplug: add kswapd_is_running() for better readability
Date: Wed, 20 Jun 2012 17:01:15 +0800 [thread overview]
Message-ID: <4FE1915B.3040303@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1206161913370.797@chino.kir.corp.google.com>
> This isn't better, there's no functional change and you've just added a
> second conditional for no reason and an unnecessary kswapd_is_running()
> function.
>
> More concerning is that online_pages() doesn't check the return value of
> kswapd_run(). We should probably fail the memory hotplug operation that
> onlines a new node and doesn't have a kswapd running and cleanup after
> ourselves in online_pages() with some sane error handling.
Hi David,
Good points! Is it feasible to use schedule_delayed_work_on() to
retry kswapd_run() instead of ralling back the online operation in case
kswapd_run() failed to create the work thread?
Thank!
Gerry
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Jiang Liu <jiang.liu@huawei.com>
To: David Rientjes <rientjes@google.com>
Cc: Minchan Kim <minchan@kernel.org>,
Keping Chen <chenkeping@huawei.com>, Mel Gorman <mgorman@suse.de>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>, Tony Luck <tony.luck@intel.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
Jiang Liu <liuj97@gmail.com>
Subject: Re: [PATCH] trivial, memory hotplug: add kswapd_is_running() for better readability
Date: Wed, 20 Jun 2012 17:01:15 +0800 [thread overview]
Message-ID: <4FE1915B.3040303@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1206161913370.797@chino.kir.corp.google.com>
> This isn't better, there's no functional change and you've just added a
> second conditional for no reason and an unnecessary kswapd_is_running()
> function.
>
> More concerning is that online_pages() doesn't check the return value of
> kswapd_run(). We should probably fail the memory hotplug operation that
> onlines a new node and doesn't have a kswapd running and cleanup after
> ourselves in online_pages() with some sane error handling.
Hi David,
Good points! Is it feasible to use schedule_delayed_work_on() to
retry kswapd_run() instead of ralling back the online operation in case
kswapd_run() failed to create the work thread?
Thank!
Gerry
next prev parent reply other threads:[~2012-06-20 9:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 3:44 [PATCH] memory hotplug: fix invalid memory access caused by stale kswapd pointer Jiang Liu
2012-06-14 3:44 ` Jiang Liu
2012-06-14 4:02 ` Kamezawa Hiroyuki
2012-06-14 4:02 ` Kamezawa Hiroyuki
2012-06-14 5:31 ` Minchan Kim
2012-06-14 5:31 ` Minchan Kim
2012-06-14 6:24 ` Jiang Liu
2012-06-14 6:24 ` Jiang Liu
2012-06-14 8:49 ` [PATCH] trivial, memory hotplug: add kswapd_is_running() for better readability Jiang Liu
2012-06-14 8:49 ` Jiang Liu
2012-06-14 11:48 ` Kamezawa Hiroyuki
2012-06-14 11:48 ` Kamezawa Hiroyuki
2012-06-14 11:59 ` KOSAKI Motohiro
2012-06-14 11:59 ` KOSAKI Motohiro
2012-06-14 15:04 ` Minchan Kim
2012-06-14 15:04 ` Minchan Kim
2012-06-17 2:19 ` David Rientjes
2012-06-17 2:19 ` David Rientjes
2012-06-18 1:12 ` Minchan Kim
2012-06-18 1:12 ` Minchan Kim
2012-06-18 8:25 ` KOSAKI Motohiro
2012-06-18 8:25 ` KOSAKI Motohiro
2012-06-20 9:01 ` Jiang Liu [this message]
2012-06-20 9:01 ` Jiang Liu
2012-06-14 5:41 ` [PATCH] memory hotplug: fix invalid memory access caused by stale kswapd pointer KOSAKI Motohiro
2012-06-14 5:41 ` KOSAKI Motohiro
2012-06-15 14:28 ` Mel Gorman
2012-06-15 14:28 ` Mel Gorman
2012-06-17 2:20 ` David Rientjes
2012-06-17 2:20 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE1915B.3040303@huawei.com \
--to=jiang.liu@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=chenkeping@huawei.com \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=rientjes@google.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.