From: Ike Panhc <ike.pan@canonical.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Matthew Garrett <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ideapad: uninitialized data in ideapad_acpi_add()
Date: Wed, 20 Jun 2012 12:23:13 +0000 [thread overview]
Message-ID: <4FE1C0B1.9050901@canonical.com> (raw)
In-Reply-To: <20120612162850.GB11077@elgon.mountain>
Hi Dan,
# cat /sys/kernel/debug/ideapad/cfg
cfg: 0xFFFF8800007DE140
^^^^^^^^ the uninitialized bit
I see your point, perhaps unsigned int will be better then int?
On 06/13/2012 12:28 AM, Dan Carpenter wrote:
> We only initialize the high bits of "cfg". It probably doesn't cause
> a problem given that this is platform specific code and doesn't have to
> worry about endianness etc. But it's sort of messy.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This is a static checker fix and I don't have the hardware. Sorry.
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 4f20f8d..17f6dfd 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -694,10 +694,10 @@ MODULE_DEVICE_TABLE(acpi, ideapad_device_ids);
> static int __devinit ideapad_acpi_add(struct acpi_device *adevice)
> {
> int ret, i;
> - unsigned long cfg;
> + int cfg;
> struct ideapad_private *priv;
>
> - if (read_method_int(adevice->handle, "_CFG", (int *)&cfg))
> + if (read_method_int(adevice->handle, "_CFG", &cfg))
> return -ENODEV;
>
> priv = kzalloc(sizeof(*priv), GFP_KERNEL);
> @@ -721,7 +721,7 @@ static int __devinit ideapad_acpi_add(struct acpi_device *adevice)
> goto input_failed;
>
> for (i = 0; i < IDEAPAD_RFKILL_DEV_NUM; i++) {
> - if (test_bit(ideapad_rfk_data[i].cfgbit, &cfg))
> + if (test_bit(ideapad_rfk_data[i].cfgbit, &priv->cfg))
> ideapad_register_rfkill(adevice, i);
> else
> priv->rfk[i] = NULL;
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Ike Panhc <ike.pan@canonical.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Matthew Garrett <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ideapad: uninitialized data in ideapad_acpi_add()
Date: Wed, 20 Jun 2012 20:23:13 +0800 [thread overview]
Message-ID: <4FE1C0B1.9050901@canonical.com> (raw)
In-Reply-To: <20120612162850.GB11077@elgon.mountain>
Hi Dan,
# cat /sys/kernel/debug/ideapad/cfg
cfg: 0xFFFF8800007DE140
^^^^^^^^ the uninitialized bit
I see your point, perhaps unsigned int will be better then int?
On 06/13/2012 12:28 AM, Dan Carpenter wrote:
> We only initialize the high bits of "cfg". It probably doesn't cause
> a problem given that this is platform specific code and doesn't have to
> worry about endianness etc. But it's sort of messy.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This is a static checker fix and I don't have the hardware. Sorry.
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 4f20f8d..17f6dfd 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -694,10 +694,10 @@ MODULE_DEVICE_TABLE(acpi, ideapad_device_ids);
> static int __devinit ideapad_acpi_add(struct acpi_device *adevice)
> {
> int ret, i;
> - unsigned long cfg;
> + int cfg;
> struct ideapad_private *priv;
>
> - if (read_method_int(adevice->handle, "_CFG", (int *)&cfg))
> + if (read_method_int(adevice->handle, "_CFG", &cfg))
> return -ENODEV;
>
> priv = kzalloc(sizeof(*priv), GFP_KERNEL);
> @@ -721,7 +721,7 @@ static int __devinit ideapad_acpi_add(struct acpi_device *adevice)
> goto input_failed;
>
> for (i = 0; i < IDEAPAD_RFKILL_DEV_NUM; i++) {
> - if (test_bit(ideapad_rfk_data[i].cfgbit, &cfg))
> + if (test_bit(ideapad_rfk_data[i].cfgbit, &priv->cfg))
> ideapad_register_rfkill(adevice, i);
> else
> priv->rfk[i] = NULL;
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-06-20 12:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 16:28 [patch] ideapad: uninitialized data in ideapad_acpi_add() Dan Carpenter
2012-06-12 16:28 ` Dan Carpenter
2012-06-20 12:23 ` Ike Panhc [this message]
2012-06-20 12:23 ` Ike Panhc
2012-06-22 13:57 ` Dan Carpenter
2012-06-22 13:57 ` Dan Carpenter
2012-06-28 9:52 ` Ike Panhc
2012-06-28 9:52 ` Ike Panhc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE1C0B1.9050901@canonical.com \
--to=ike.pan@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.