[LTP] [bug report] a typo in runltp script

[LTP] [bug report] a typo in runltp script

[Li, Jin]

Hi,

When I use runltp with the option [-b DEVICE], notice the typo as follows:

sed -i "" -e "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|"  ${TMP}/alltests

The runltp will hit error and exit.

Is it a typo or I miss something else ?


Thanks,

Jin

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [bug report] a typo in runltp script

[chrubis]

Hi!
> When I use runltp with the option [-b DEVICE], notice the typo as follows:
> 
> sed -i "" -e "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|"  ${TMP}/alltests
> 
> The runltp will hit error and exit.
> 
> Is it a typo or I miss something else ?

That line went in with Garrett's patch to improve the script. I guess he
was using slightly different version of sed (or just typed the line
wrong). (CCed him in case he remebers).

And in any case we should fix that. Do you care to send a patch?

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [bug report] a typo in runltp script

[Garrett Cooper]

On Thu, Jun 21, 2012 at 12:27 AM, Li, Jin <Jin.Li@windriver.com> wrote:
> Hi,
>
> When I use runltp with the option [-b DEVICE], notice the typo as follows:
>
> sed -i "" -e "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|"  ${TMP}/alltests
>
> The runltp will hit error and exit.
>
> Is it a typo or I miss something else ?

    It wasn't an intentional "typo". It's an inconsistency between BSD
sed and GNU sed (something that irritates me from time to time). The
above form works with BSD sed.
    Replacing `-i ""` with `-i '.bk'` should work.
Thanks,
-Garrett

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list