From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch v5 08/13] ARM: imx6q: add config-on-boot gpios
Date: Thu, 21 Jun 2012 16:32:26 -0500 [thread overview]
Message-ID: <4FE392EA.7060103@gmail.com> (raw)
In-Reply-To: <20120620150502.GG2253@S2101-09.ap.freescale.net>
On 06/20/2012 10:05 AM, Shawn Guo wrote:
> On Wed, Jun 20, 2012 at 09:29:39AM -0500, Rob Herring wrote:
>> I mean just something like "fsl,hub-reset-gpios" in the ehci device
>> node. It's at least under a usb node. Whether the ehci driver handles
>> this or you just have a separate piece of code to find this property and
>> setup the gpio is up to you.
>>
> I ever had an argument on this. If we have "fsl,hub-reset-gpios"
> defined in ehci device node, it should simply be ehci driver who needs
> to find this property and set up the gpio. Defining the property in
> ehci device node while having platform code to find the property just
> seems wired to me. That said, if it's not ehci driver who will use
> the property, we should not define the property in in ehci device node.
There's no requirement that 1 DT node be 1 driver. That's purely an OS
decision and it's usually simpler that way. But if it it's just a one
time thing at boot, then its fine for the platform code to handle it.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Richard Zhao
<richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Richard Zhao <linuxzsc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
marex-ynQEQJNshbs@public.gmane.org,
B20596-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
B29397-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org
Subject: Re: [Patch v5 08/13] ARM: imx6q: add config-on-boot gpios
Date: Thu, 21 Jun 2012 16:32:26 -0500 [thread overview]
Message-ID: <4FE392EA.7060103@gmail.com> (raw)
In-Reply-To: <20120620150502.GG2253-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
On 06/20/2012 10:05 AM, Shawn Guo wrote:
> On Wed, Jun 20, 2012 at 09:29:39AM -0500, Rob Herring wrote:
>> I mean just something like "fsl,hub-reset-gpios" in the ehci device
>> node. It's at least under a usb node. Whether the ehci driver handles
>> this or you just have a separate piece of code to find this property and
>> setup the gpio is up to you.
>>
> I ever had an argument on this. If we have "fsl,hub-reset-gpios"
> defined in ehci device node, it should simply be ehci driver who needs
> to find this property and set up the gpio. Defining the property in
> ehci device node while having platform code to find the property just
> seems wired to me. That said, if it's not ehci driver who will use
> the property, we should not define the property in in ehci device node.
There's no requirement that 1 DT node be 1 driver. That's purely an OS
decision and it's usually simpler that way. But if it it's just a one
time thing at boot, then its fine for the platform code to handle it.
Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-06-21 21:32 UTC|newest]
Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 12:34 [Patch v5 00/13] add imx usb driver for mx28/6x Richard Zhao
2012-06-13 12:34 ` Richard Zhao
2012-06-13 12:34 ` [Patch v5 01/13] usb: otg: add notify_connect/notify_disconnect callback Richard Zhao
2012-06-13 12:34 ` Richard Zhao
2012-06-13 12:34 ` [Patch v5 02/13] USB: move transceiver from ehci_hcd and ohci_hcd to hcd and rename it as phy Richard Zhao
2012-06-13 12:34 ` Richard Zhao
2012-06-13 18:17 ` Alan Stern
2012-06-13 18:17 ` Alan Stern
2012-06-13 12:34 ` [Patch v5 03/13] USB: notify phy when root hub port connect change Richard Zhao
2012-06-13 12:34 ` Richard Zhao
2012-06-13 18:25 ` Alan Stern
2012-06-13 18:25 ` Alan Stern
2012-06-14 0:36 ` Richard Zhao
2012-06-14 0:36 ` Richard Zhao
2012-06-14 14:11 ` Alan Stern
2012-06-14 14:11 ` Alan Stern
2012-06-13 12:34 ` [Patch v5 04/13] usb: chipidea: permit driver bindings pass phy pointer Richard Zhao
2012-06-13 12:34 ` Richard Zhao
2012-06-13 12:34 ` [Patch v5 05/13] usb: otg: add basic mxs phy driver support Richard Zhao
2012-06-13 12:34 ` Richard Zhao
2012-06-13 21:33 ` Sascha Hauer
2012-06-13 21:33 ` Sascha Hauer
2012-06-13 21:56 ` Marek Vasut
2012-06-13 21:56 ` Marek Vasut
2012-06-13 22:03 ` Sascha Hauer
2012-06-13 22:03 ` Sascha Hauer
2012-06-14 1:12 ` Richard Zhao
2012-06-14 1:12 ` Richard Zhao
2012-06-13 12:34 ` [Patch v5 06/13] usb: chipidea: add imx platform driver Richard Zhao
2012-06-13 12:34 ` Richard Zhao
2012-06-13 21:46 ` Sascha Hauer
2012-06-13 21:46 ` Sascha Hauer
2012-06-13 21:57 ` Marek Vasut
2012-06-13 21:57 ` Marek Vasut
2012-06-13 22:07 ` Sascha Hauer
2012-06-13 22:07 ` Sascha Hauer
2012-06-14 1:21 ` Richard Zhao
2012-06-14 1:21 ` Richard Zhao
2012-06-14 1:56 ` Richard Zhao
2012-06-14 1:56 ` Richard Zhao
2012-06-13 12:34 ` [Patch v5 07/13] ARM: imx6q: correct device name of usbphy and usb controller clock export Richard Zhao
2012-06-13 12:34 ` Richard Zhao
2012-06-13 12:34 ` [Patch v5 08/13] ARM: imx6q: add config-on-boot gpios Richard Zhao
2012-06-13 12:34 ` Richard Zhao
2012-06-13 15:09 ` Rob Herring
2012-06-13 15:09 ` Rob Herring
2012-06-13 15:19 ` Marek Vasut
2012-06-13 15:19 ` Marek Vasut
2012-06-13 16:45 ` Rob Herring
2012-06-13 16:45 ` Rob Herring
2012-06-13 17:15 ` Marek Vasut
2012-06-13 17:15 ` Marek Vasut
2012-06-13 15:28 ` Richard Zhao
2012-06-13 15:28 ` Richard Zhao
2012-06-13 16:00 ` Marek Vasut
2012-06-13 16:00 ` Marek Vasut
2012-06-15 15:34 ` Shawn Guo
2012-06-15 15:34 ` Shawn Guo
2012-06-13 16:50 ` Rob Herring
2012-06-13 16:50 ` Rob Herring
2012-06-14 1:33 ` Richard Zhao
2012-06-14 1:33 ` Richard Zhao
2012-06-20 14:29 ` Rob Herring
2012-06-20 14:29 ` Rob Herring
2012-06-20 15:05 ` Shawn Guo
2012-06-20 15:05 ` Shawn Guo
2012-06-21 21:32 ` Rob Herring [this message]
2012-06-21 21:32 ` Rob Herring
2012-06-20 15:41 ` Stephen Warren
2012-06-20 15:41 ` Stephen Warren
2012-06-21 1:32 ` Chen Peter-B29397
2012-06-21 1:32 ` Chen Peter-B29397
2012-06-21 22:22 ` Stephen Warren
2012-06-21 22:22 ` Stephen Warren
2012-06-22 0:03 ` Chen Peter-B29397
2012-06-22 0:03 ` Chen Peter-B29397
2012-06-25 15:43 ` Stephen Warren
2012-06-25 15:43 ` Stephen Warren
2012-06-26 2:05 ` Chen Peter-B29397
2012-06-26 2:05 ` Chen Peter-B29397
2012-06-19 23:36 ` Fabio Estevam
2012-06-19 23:36 ` Fabio Estevam
2012-06-19 23:41 ` Richard Zhao
2012-06-19 23:41 ` Richard Zhao
2012-07-17 12:30 ` Dirk Behme
2012-07-17 12:30 ` Dirk Behme
2012-07-19 2:15 ` Richard Zhao
2012-07-19 2:15 ` Richard Zhao
2012-06-13 12:34 ` [Patch v5 09/13] ARM: imx6q: add usbphy clocks Richard Zhao
2012-06-13 12:34 ` Richard Zhao
2012-06-13 21:54 ` Sascha Hauer
2012-06-13 21:54 ` Sascha Hauer
2012-06-14 0:15 ` Chen Peter-B29397
2012-06-14 0:15 ` Chen Peter-B29397
2012-06-13 12:34 ` [Patch v5 10/13] ARM: imx6q: disable usb charger detector Richard Zhao
2012-06-13 12:34 ` Richard Zhao
2012-06-13 12:34 ` [Patch v5 11/13] ARM: dts: imx6q-sabrelite: add usb devices Richard Zhao
2012-06-13 12:34 ` Richard Zhao
2012-06-19 23:39 ` Fabio Estevam
2012-06-19 23:39 ` Fabio Estevam
2012-06-13 12:34 ` [Patch v5 12/13] ARM: mxs: clk_register_clkdev mx28 usb clocks Richard Zhao
2012-06-13 12:34 ` Richard Zhao
2012-06-13 12:34 ` [Patch v5 13/13] ARM: dts: imx28-evk: add usb devices Richard Zhao
2012-06-13 12:34 ` Richard Zhao
2012-06-18 17:10 ` [Patch v5 00/13] add imx usb driver for mx28/6x Fabio Estevam
2012-06-18 17:10 ` Fabio Estevam
2012-06-18 17:13 ` Marek Vasut
2012-06-18 17:13 ` Marek Vasut
2012-06-18 17:25 ` Fabio Estevam
2012-06-18 17:25 ` Fabio Estevam
2012-06-19 1:14 ` Chen Peter-B29397
2012-06-19 1:14 ` Chen Peter-B29397
2012-06-19 1:33 ` Fabio Estevam
2012-06-19 1:33 ` Fabio Estevam
2012-06-19 2:07 ` Marek Vasut
2012-06-19 2:07 ` Marek Vasut
2012-06-19 2:17 ` Fabio Estevam
2012-06-19 2:17 ` Fabio Estevam
2012-06-19 6:14 ` Shawn Guo
2012-06-19 6:14 ` Shawn Guo
2012-06-19 12:24 ` Fabio Estevam
2012-06-19 12:24 ` Fabio Estevam
2012-06-19 12:38 ` Shawn Guo
2012-06-19 12:38 ` Shawn Guo
2012-06-19 13:54 ` Fabio Estevam
2012-06-19 13:54 ` Fabio Estevam
2012-06-19 18:34 ` Fabio Estevam
2012-06-19 18:34 ` Fabio Estevam
2012-06-19 19:03 ` Dirk Behme
2012-06-19 12:59 ` Marek Vasut
2012-06-19 12:59 ` Marek Vasut
2012-06-20 17:53 ` Subodh Nijsure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE392EA.7060103@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.